From: Bjorn Andersson <andersson@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Adam Skladowski <a39.skl@gmail.com>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: add QCOM SM6115 display clock bindings
Date: Mon, 26 Sep 2022 22:09:46 -0500 [thread overview]
Message-ID: <20220927030946.5acxedwvut6ifdmx@builder.lan> (raw)
In-Reply-To: <20220913152620.GA3762864-robh@kernel.org>
On Tue, Sep 13, 2022 at 10:26:20AM -0500, Rob Herring wrote:
> On Sun, Sep 11, 2022 at 06:46:18PM +0200, Adam Skladowski wrote:
> > Add device tree bindings for display clock controller for
> > Qualcomm Technology Inc's SM6115 SoC.
> >
> > Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> > ---
> > .../bindings/clock/qcom,sm6115-dispcc.yaml | 70 +++++++++++++++++++
> > .../dt-bindings/clock/qcom,sm6115-dispcc.h | 36 ++++++++++
> > 2 files changed, 106 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
> > create mode 100644 include/dt-bindings/clock/qcom,sm6115-dispcc.h
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
> > new file mode 100644
> > index 000000000000..a6bf363b5015
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/qcom,sm6115-dispcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Display Clock Controller Binding for SM6115
>
> s/Binding //
>
> > +
> > +maintainers:
> > + - Bjorn Andersson <andersson@kernel.org>
> > +
> > +description: |
>
> Don't need '|' when no formatting to preserve.
>
This follows the other dispcc bindings, where I think the intention is
to keep the formatting over "See also". In contrast to the other dispcc
bindings the "See also" has a ':' at the end in this proposal...
> With those fixes,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
I took the liberty of fixing up the description to align with the others
and applied this, with your R-b.
Regards,
Bjorn
next prev parent reply other threads:[~2022-09-27 3:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 16:46 [PATCH v3 0/2] Add DISPCC driver for SM6115 Adam Skladowski
2022-09-11 16:46 ` [PATCH v3 1/2] dt-bindings: clock: add QCOM SM6115 display clock bindings Adam Skladowski
2022-09-13 15:26 ` Rob Herring
2022-09-27 3:09 ` Bjorn Andersson [this message]
2022-09-11 16:46 ` [PATCH v3 2/2] clk: qcom: Add display clock controller driver for SM6115 Adam Skladowski
2022-09-27 3:22 ` [PATCH v3 0/2] Add DISPCC " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927030946.5acxedwvut6ifdmx@builder.lan \
--to=andersson@kernel.org \
--cc=a39.skl@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).