* [PATCH v5 0/2] arm64: dts: qcom: pwm: Drop PWM reg dependency + update MAINTAINERS
@ 2022-09-27 23:51 Bryan O'Donoghue
2022-09-27 23:51 ` [PATCH v5 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency Bryan O'Donoghue
2022-09-27 23:51 ` [PATCH v5 2/2] MAINTAINERS: Mark Lee as Maintainer not Supporter for MFD yaml Bryan O'Donoghue
0 siblings, 2 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2022-09-27 23:51 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
lee, linux-arm-msm, devicetree
Cc: bryan.odonoghue
V5:
- Resend the yaml fix
- Update MAINTAINERS to mark Lee as Maintainer not Supporter of the YAML
files for MFD.
I rely on scripts/get_mainter.pl to tell me who needs to be mailed and
who doesn't, given the YAML change has to go through Lee, the MAINTAINERS
file should make that show up in get_maintainers.pl
V4:
- Churn patch#1 prefix to "dt-bindings: mfd: qcom,spmi-pmic:" - Krzysztof
- Add's Krzysztof's RB as indicated
V3:
- Splits dtsi and yaml
- Uses Krzysztof's suggested commit log in the yaml
V2:
The accompanying patch removes reg = <> and pwm@reg from the yaml and dtsi.
This follows on from discussions between Bupesh, Dmitry, Bjorn, Krzysztof and myself.
https://lore.kernel.org/all/20220719205058.1004942-1-bhupesh.sharma@linaro.org/
https://lore.kernel.org/all/20220721195502.1525214-1-bhupesh.sharma@linaro.org/
https://lore.kernel.org/all/20220822120300.2633790-1-bryan.odonoghue@linaro.org/
The previous discussion tended towards either removing pwm@reg and reg = <> or
extending out the yaml to support multiple reg declarations for PWM compatible.
This patch does the former. I've left node: label in place, dropped both pwm@reg
and reg = <> I kept "label: nodename" though because it looked more like what we
already have for rpm regulators.
Per our previous discussion I've modified the yaml and dtsi in one go.
Bryan O'Donoghue (2):
dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency
MAINTAINERS: Mark Lee as Maintainer not Supporter for MFD yaml
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
MAINTAINERS | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
--
2.37.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v5 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency
2022-09-27 23:51 [PATCH v5 0/2] arm64: dts: qcom: pwm: Drop PWM reg dependency + update MAINTAINERS Bryan O'Donoghue
@ 2022-09-27 23:51 ` Bryan O'Donoghue
2022-09-27 23:51 ` [PATCH v5 2/2] MAINTAINERS: Mark Lee as Maintainer not Supporter for MFD yaml Bryan O'Donoghue
1 sibling, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2022-09-27 23:51 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
lee, linux-arm-msm, devicetree
Cc: bryan.odonoghue, Krzysztof Kozlowski
The PWM node is not a separate device and is expected to be part of parent
SPMI PMIC node, thus it obtains the address space from the parent. One IO
address in "reg" is also not correct description because LPG block maps to
several regions.
Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC")
Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 65cbc6dee545e..2a5bafe0660a0 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -92,6 +92,10 @@ properties:
type: object
$ref: /schemas/regulator/regulator.yaml#
+ pwm:
+ type: object
+ $ref: /schemas/leds/leds-qcom-lpg.yaml#
+
patternProperties:
"^adc@[0-9a-f]+$":
type: object
@@ -117,10 +121,6 @@ patternProperties:
type: object
$ref: /schemas/power/reset/qcom,pon.yaml#
- "pwm@[0-9a-f]+$":
- type: object
- $ref: /schemas/leds/leds-qcom-lpg.yaml#
-
"^rtc@[0-9a-f]+$":
type: object
$ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml#
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v5 2/2] MAINTAINERS: Mark Lee as Maintainer not Supporter for MFD yaml
2022-09-27 23:51 [PATCH v5 0/2] arm64: dts: qcom: pwm: Drop PWM reg dependency + update MAINTAINERS Bryan O'Donoghue
2022-09-27 23:51 ` [PATCH v5 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency Bryan O'Donoghue
@ 2022-09-27 23:51 ` Bryan O'Donoghue
2022-09-28 0:01 ` Bryan O'Donoghue
1 sibling, 1 reply; 5+ messages in thread
From: Bryan O'Donoghue @ 2022-09-27 23:51 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
lee, linux-arm-msm, devicetree
Cc: bryan.odonoghue
Running scripts/get_maintainer.pl on
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml gives Andy Gross,
Bjorn Andersson, Rob Herring and Krzysztof Kozlowski but I'm told my yaml
changes needs to go through Lee.
Change up the MAINTAINERS file so that get_maintainers.pl includes Lee as
Maintainer in the output list as per
Documentation/process/submitting-patches.rst.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 936490dcc97b6..ee3bafe9a08d9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13905,7 +13905,7 @@ F: drivers/media/i2c/mt9v111.c
MULTIFUNCTION DEVICES (MFD)
M: Lee Jones <lee@kernel.org>
-S: Supported
+S: Maintained
T: git git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
F: Documentation/devicetree/bindings/mfd/
F: drivers/mfd/
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v5 2/2] MAINTAINERS: Mark Lee as Maintainer not Supporter for MFD yaml
2022-09-27 23:51 ` [PATCH v5 2/2] MAINTAINERS: Mark Lee as Maintainer not Supporter for MFD yaml Bryan O'Donoghue
@ 2022-09-28 0:01 ` Bryan O'Donoghue
2022-09-28 8:22 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Bryan O'Donoghue @ 2022-09-28 0:01 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
lee, linux-arm-msm, devicetree
On 28/09/2022 00:51, Bryan O'Donoghue wrote:
> Running scripts/get_maintainer.pl on
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml gives Andy Gross,
> Bjorn Andersson, Rob Herring and Krzysztof Kozlowski but I'm told my yaml
> changes needs to go through Lee.
>
> Change up the MAINTAINERS file so that get_maintainers.pl includes Lee as
> Maintainer in the output list as per
> Documentation/process/submitting-patches.rst.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 936490dcc97b6..ee3bafe9a08d9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13905,7 +13905,7 @@ F: drivers/media/i2c/mt9v111.c
>
> MULTIFUNCTION DEVICES (MFD)
> M: Lee Jones <lee@kernel.org>
> -S: Supported
> +S: Maintained
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
> F: Documentation/devicetree/bindings/mfd/
> F: drivers/mfd/
Hmm.
Actually maybe Documentation/process/submitting-patches.rst should be
updated to state that anybody appearing as "supported" in
get_maintainers.pl should be mailed, instead.
I'll V6 the yaml standalone and propose a change to
Documentation/process/submitting-patches.rst separately.
---
bod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 2/2] MAINTAINERS: Mark Lee as Maintainer not Supporter for MFD yaml
2022-09-28 0:01 ` Bryan O'Donoghue
@ 2022-09-28 8:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-28 8:22 UTC (permalink / raw)
To: Bryan O'Donoghue, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, lee, linux-arm-msm, devicetree
On 28/09/2022 02:01, Bryan O'Donoghue wrote:
>>
>> MULTIFUNCTION DEVICES (MFD)
>> M: Lee Jones <lee@kernel.org>
>> -S: Supported
>> +S: Maintained
>> T: git git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
>> F: Documentation/devicetree/bindings/mfd/
>> F: drivers/mfd/
>
> Hmm.
>
> Actually maybe Documentation/process/submitting-patches.rst should be
> updated to state that anybody appearing as "supported" in
> get_maintainers.pl should be mailed, instead.
Supporter is a maintainer, just not only in spare time.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-28 8:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-27 23:51 [PATCH v5 0/2] arm64: dts: qcom: pwm: Drop PWM reg dependency + update MAINTAINERS Bryan O'Donoghue
2022-09-27 23:51 ` [PATCH v5 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency Bryan O'Donoghue
2022-09-27 23:51 ` [PATCH v5 2/2] MAINTAINERS: Mark Lee as Maintainer not Supporter for MFD yaml Bryan O'Donoghue
2022-09-28 0:01 ` Bryan O'Donoghue
2022-09-28 8:22 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).