From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE862C433F5 for ; Thu, 29 Sep 2022 17:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235001AbiI2RXi (ORCPT ); Thu, 29 Sep 2022 13:23:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235967AbiI2RXT (ORCPT ); Thu, 29 Sep 2022 13:23:19 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38FB01F11ED for ; Thu, 29 Sep 2022 10:22:04 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id b23so2012252pfp.9 for ; Thu, 29 Sep 2022 10:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=SIbDPYXTiEpHr31cowPm5hEWT0Dsj29GpYNVG6B6LlQ=; b=mB8DS4FtbYahqmKbTsOUSTFLoTQRXcbJ3S67QhTIGmqSBDz/tWrFlwMcQ+cr23xX+b QjG8yy4p2rhzXPmzYoPpJETh+MOcZ4yLkpS+xe/4UC0kekmTGp2l0FOavxZbRoTOhb+3 XH0z/AGyy1pyfbaQ0b8WlaXjjULk5lXJ98RdhAuDRK1jZK174zRJLrai1dB3qYm7C9bi mfxenLf2PEEAJXuAgS23CChpXtK7E5L++pMmei3EFlv/p6bQLa1s2fnPxLJwYph9MUyh Id4k8Zu0gFKur4uSD2lyGzTjCb8tFTcmzTfGvpSNt2i8W6+NVwbl2mPn83HI9mJB9uQj Gugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=SIbDPYXTiEpHr31cowPm5hEWT0Dsj29GpYNVG6B6LlQ=; b=iZ4kkKQCKh6wIUjTAsli5PC6TGoLFVhQmV73RkXmFctLg53omfaF1AWhLWJNpuYX8+ QD13j4M7fq6sqMN7uqG6KkqvvuZJ4iMKfBM5RyQ9kIFEczGKszz8ELDmWIt4pCklFto7 XG9qQZdOMKcwKy4TsYqtHuluh0nG2fTh2Z+k9ehLQCCw+KaURtiU+6WZRHX2fD4KVjo9 Gb+81X9XBhxE2zaJFmuosO44PncBfrggODtyguORJU/s0gtIJppuvNIIPFqUu8AoL627 6HXG5S0x3DrvGs2XCpGaSqBug5exA662M7KM4oRU3X+YTQjRZHGmhpWr3Qqw7MoZ/XOt z9lg== X-Gm-Message-State: ACrzQf1zEwdFA52fL52Yb45IgyeAYzAMrciHs7Vps1QDx77Uzfr0j1iE HwKWG1BQib3rIsAoxzYHFhwnbg== X-Google-Smtp-Source: AMsMyM4AC3DhaeWsDiKxbTYHV9WoijHDEhKnl9Ddx2dx4JeYbpJ/IXYZuywwehHTWBeATWePCuxzFg== X-Received: by 2002:a05:6a00:1a47:b0:52e:6a8c:5430 with SMTP id h7-20020a056a001a4700b0052e6a8c5430mr4622875pfv.48.1664472123633; Thu, 29 Sep 2022 10:22:03 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id j13-20020a17090a694d00b00205da989de3sm36917pjm.17.2022.09.29.10.22.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 10:22:02 -0700 (PDT) Date: Thu, 29 Sep 2022 11:22:00 -0600 From: Mathieu Poirier To: Tanmay Shah Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, ben.levinsky@xilinx.com, tanmay.shah@xilinx.com, michal.simek@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v9 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver Message-ID: <20220929172200.GB3107608@p14s> References: <20220708013955.2340449-1-tanmay.shah@amd.com> <20220708013955.2340449-7-tanmay.shah@amd.com> <20220901202517.GB626605@p14s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Sep 26, 2022 at 03:02:22PM -0700, Tanmay Shah wrote: > > On 9/1/22 1:25 PM, Mathieu Poirier wrote: > > On Thu, Jul 07, 2022 at 06:39:55PM -0700, Tanmay Shah wrote: > [ ... ] > > > --- /dev/null > > > +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c > > > @@ -0,0 +1,1055 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > Hi Mathieu, > > I tried to fix SPDX-License-Identifier to GPL (same as MODULE_LICENSE > below), However checkpatch.pl reports this as following warning: > > "WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/..." > > I see that GPL-1.0 is under LICENSE/deprecated directory. > > > > +/* > > > + * ZynqMP R5 Remote Processor driver > > > + * > > > + */ > > > + > > > +#include > > [ ... ] > > > > +MODULE_DEVICE_TABLE(of, zynqmp_r5_remoteproc_match); > > > + > > > +static struct platform_driver zynqmp_r5_remoteproc_driver = { > > > + .probe = zynqmp_r5_remoteproc_probe, > > > + .driver = { > > > + .name = "zynqmp_r5_remoteproc", > > > + .of_match_table = zynqmp_r5_remoteproc_match, > > > + }, > > > +}; > > > +module_platform_driver(zynqmp_r5_remoteproc_driver); > > > + > > > +MODULE_DESCRIPTION("Xilinx R5F remote processor driver"); > > > +MODULE_AUTHOR("Xilinx Inc."); > > > +MODULE_LICENSE("GPL"); > > There is a discrepency between the GPL-2.0 in the SPDS identifier and the above. > > Also, changing to MODULE_LICENSE("GPL v2") gives following warning: > > WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure > the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") > #1115: FILE: drivers/remoteproc/xlnx_r5_remoteproc.c:1034: > +MODULE_LICENSE("GPL v2"); > > So, It looks like SPDX-License-Identifier should be GPL-2.0-only and > MODULE_LICENSE should be change to "GPL". Commit bf7fbeeae6db is an interesting read - thanks for pointing it out. > > It this ok? Any other suggestions ? What you have looks good, in that regard there is no need to change anything from your patch. > > Thanks, > > Tanmay > > > > > More comments tomorrow or Tuesday. > > > > Thanks, > > Mathieu > > > > > -- > > > 2.25.1 > > >