* [PATCH] ARM: dts: lan966x: add led configuration
@ 2022-08-31 19:44 Horatiu Vultur
2022-09-01 9:56 ` Claudiu.Beznea
2022-09-30 10:45 ` Pavel Machek
0 siblings, 2 replies; 3+ messages in thread
From: Horatiu Vultur @ 2022-08-31 19:44 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, claudiu.beznea, nicolas.ferre,
UNGLinuxDriver, Horatiu Vultur
Add led configuration for pcb8291 and pcb8309. Both pcbs have 4 leds which
are connected to the sgpio controller.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
arch/arm/boot/dts/lan966x-pcb8291.dts | 29 +++++++++++++++++++++++++++
arch/arm/boot/dts/lan966x-pcb8309.dts | 29 +++++++++++++++++++++++++++
2 files changed, 58 insertions(+)
diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
index 24d9055c4a08..649cfe69d98d 100644
--- a/arch/arm/boot/dts/lan966x-pcb8291.dts
+++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
@@ -23,6 +23,35 @@ gpio-restart {
gpios = <&gpio 56 GPIO_ACTIVE_LOW>;
priority = <200>;
};
+
+ leds {
+ compatible = "gpio-leds";
+ status = "okay";
+
+ led-s0-blue {
+ label = "s0:blue";
+ gpios = <&sgpio_out 2 0 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+
+ led-s0-green {
+ label = "s0:green";
+ gpios = <&sgpio_out 2 1 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+
+ led-s1-blue {
+ label = "s1:blue";
+ gpios = <&sgpio_out 3 0 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+
+ led-s1-green {
+ label = "s1:green";
+ gpios = <&sgpio_out 3 1 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ };
};
&gpio {
diff --git a/arch/arm/boot/dts/lan966x-pcb8309.dts b/arch/arm/boot/dts/lan966x-pcb8309.dts
index 05ce27ed5648..4f30975b4a13 100644
--- a/arch/arm/boot/dts/lan966x-pcb8309.dts
+++ b/arch/arm/boot/dts/lan966x-pcb8309.dts
@@ -42,6 +42,35 @@ i2c103: i2c-sfp@2 {
};
};
+ leds {
+ compatible = "gpio-leds";
+ status = "okay";
+
+ led-s0-green {
+ label = "s0:green";
+ gpios = <&sgpio_out 2 0 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+
+ led-s0-red {
+ label = "s0:red";
+ gpios = <&sgpio_out 2 1 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+
+ led-s1-green {
+ label = "s1:green";
+ gpios = <&sgpio_out 3 0 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+
+ led-s1-red {
+ label = "s1:red";
+ gpios = <&sgpio_out 3 1 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ };
+
mux: mux-controller {
compatible = "gpio-mux";
#mux-control-cells = <0>;
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: lan966x: add led configuration
2022-08-31 19:44 [PATCH] ARM: dts: lan966x: add led configuration Horatiu Vultur
@ 2022-09-01 9:56 ` Claudiu.Beznea
2022-09-30 10:45 ` Pavel Machek
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu.Beznea @ 2022-09-01 9:56 UTC (permalink / raw)
To: Horatiu.Vultur, devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, Nicolas.Ferre, UNGLinuxDriver
On 31.08.2022 22:44, Horatiu Vultur wrote:
> Add led configuration for pcb8291 and pcb8309. Both pcbs have 4 leds which
> are connected to the sgpio controller.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> arch/arm/boot/dts/lan966x-pcb8291.dts | 29 +++++++++++++++++++++++++++
> arch/arm/boot/dts/lan966x-pcb8309.dts | 29 +++++++++++++++++++++++++++
> 2 files changed, 58 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 24d9055c4a08..649cfe69d98d 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -23,6 +23,35 @@ gpio-restart {
> gpios = <&gpio 56 GPIO_ACTIVE_LOW>;
> priority = <200>;
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + status = "okay";
There is no need for status here. Default is okay.
> +
> + led-s0-blue {
> + label = "s0:blue";
> + gpios = <&sgpio_out 2 0 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> +
> + led-s0-green {
> + label = "s0:green";
> + gpios = <&sgpio_out 2 1 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> +
> + led-s1-blue {
> + label = "s1:blue";
> + gpios = <&sgpio_out 3 0 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> +
> + led-s1-green {
> + label = "s1:green";
> + gpios = <&sgpio_out 3 1 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> };
>
> &gpio {
> diff --git a/arch/arm/boot/dts/lan966x-pcb8309.dts b/arch/arm/boot/dts/lan966x-pcb8309.dts
> index 05ce27ed5648..4f30975b4a13 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8309.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8309.dts
> @@ -42,6 +42,35 @@ i2c103: i2c-sfp@2 {
> };
> };
>
> + leds {
> + compatible = "gpio-leds";
> + status = "okay";
Ditto
> +
> + led-s0-green {
> + label = "s0:green";
> + gpios = <&sgpio_out 2 0 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> +
> + led-s0-red {
> + label = "s0:red";
> + gpios = <&sgpio_out 2 1 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> +
> + led-s1-green {
> + label = "s1:green";
> + gpios = <&sgpio_out 3 0 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> +
> + led-s1-red {
> + label = "s1:red";
> + gpios = <&sgpio_out 3 1 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> +
> mux: mux-controller {
> compatible = "gpio-mux";
> #mux-control-cells = <0>;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: lan966x: add led configuration
2022-08-31 19:44 [PATCH] ARM: dts: lan966x: add led configuration Horatiu Vultur
2022-09-01 9:56 ` Claudiu.Beznea
@ 2022-09-30 10:45 ` Pavel Machek
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2022-09-30 10:45 UTC (permalink / raw)
To: Horatiu Vultur
Cc: devicetree, linux-kernel, robh+dt, krzysztof.kozlowski+dt,
claudiu.beznea, nicolas.ferre, UNGLinuxDriver
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Hi!
> Add led configuration for pcb8291 and pcb8309. Both pcbs have 4 leds which
> are connected to the sgpio controller.
> + led-s0-blue {
> + label = "s0:blue";
> + label = "s0:green";
> + label = "s1:blue";
> + label = "s1:green";
Can we get more usefule led labels, please?
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-30 11:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-31 19:44 [PATCH] ARM: dts: lan966x: add led configuration Horatiu Vultur
2022-09-01 9:56 ` Claudiu.Beznea
2022-09-30 10:45 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).