From: Jonathan Cameron <jic23@kernel.org>
To: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Cc: <linux-iio@vger.kernel.org>, <Nuno.Sa@analog.com>,
<Nurettin.Bolucu@analog.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/3] iio: adc: add max11410 adc driver
Date: Sun, 2 Oct 2022 14:13:44 +0100 [thread overview]
Message-ID: <20221002141344.19b0622d@jic23-huawei> (raw)
In-Reply-To: <20220927141851.279-2-Ibrahim.Tilki@analog.com>
On Tue, 27 Sep 2022 17:18:49 +0300
Ibrahim Tilki <Ibrahim.Tilki@analog.com> wrote:
> Adding support for max11410 24-bit, 1.9ksps delta-sigma adc which
> has 3 differential reference and 10 differential channel inputs.
> Inputs and references can be buffered internally. Inputs can also
> be amplified with internal PGA.
>
> Device has four digital filter modes: FIR50/60, FIR50, FIR60 and SINC4.
> FIR 50Hz and 60Hz rejections can be enabled/disabled separately.
> Digital filter selection affects sampling frequency range so driver
> has to consider the configured filter when configuring sampling frequency.
>
> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Hi Ibrahim,
Other than the obvious (form the build bug report) missing
#include <asm/unaligned.h>
this looks good to me. I may of course spot something on v7, but hopefully
we can get the binding issues resolved and get this queued up.
Thanks,
Jonathan
next prev parent reply other threads:[~2022-10-02 13:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 14:18 [PATCH v6 0/3] iio: adc: add max11410 adc driver Ibrahim Tilki
2022-09-27 14:18 ` [PATCH v6 1/3] " Ibrahim Tilki
2022-09-28 0:47 ` kernel test robot
2022-10-02 13:13 ` Jonathan Cameron [this message]
2022-09-27 14:18 ` [PATCH v6 2/3] dt-bindings: iio: adc: add adi,max11410.yaml Ibrahim Tilki
2022-09-29 9:35 ` Krzysztof Kozlowski
2022-10-02 13:06 ` Jonathan Cameron
2022-10-03 6:53 ` Krzysztof Kozlowski
2022-09-27 14:18 ` [PATCH v6 3/3] Documentation: ABI: testing: add max11410 doc Ibrahim Tilki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221002141344.19b0622d@jic23-huawei \
--to=jic23@kernel.org \
--cc=Ibrahim.Tilki@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=Nurettin.Bolucu@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).