From: Richard Acayan <mailingradian@gmail.com>
To: linux-arm-msm@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Richard Acayan <mailingradian@gmail.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v6 3/3] pinctrl: qcom: add sdm670 pinctrl
Date: Mon, 3 Oct 2022 21:00:10 -0400 [thread overview]
Message-ID: <20221004010010.34499-1-mailingradian@gmail.com> (raw)
In-Reply-To: <20221004002333.g5yfjx6lol3pmc23@baldur>
> On Sat, Oct 01, 2022 at 05:07:25PM -0400, Richard Acayan wrote:
> > The Snapdragon 670 has a Top-Level Mode Multiplexer (TLMM) for various
> > features. Add a driver to support it.
> >
> > Link: https://android.googlesource.com/kernel/msm/+/de5a12173c7fa6d65bedee9ad36af55b2dbfeb36%5E%21/#F6
> > Link: https://android.googlesource.com/kernel/msm/+/04f083156d9b9f3bfcf204c1c6da88632fbb3863%5E%21/#F22
> > Link: https://android.googlesource.com/kernel/msm/+/54837652e3400ecc63ccc78b2193faf4f349a32e%5E%21/#F0
> > Link: https://android.googlesource.com/kernel/msm/+/f0409b07174ceca217f8b7fd255418feff06092d%5E%21/#F0
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
>
> Pending the question about overriding reserved_gpios, the rest of this
> patch looks good.
Except for these somewhat inconsistent lines:
static const char * const qdss_groups[] = {
"gpio13", "gpio14", "gpio15", "gpio16", "gpio17", "gpio18", "gpio19",
"gpio20", "gpio21", "gpio22", "gpio23", "gpio24", "gpio25", "gpio26",
"gpio27", "gpio28", "gpio29", "gpio30", "gpio41", "gpio42", "gpio43",
"gpio44", "gpio75", "gpio76", "gpio77", "gpio79", "gpio80", "gpio93",
"gpio117", "gpio118", "gpio119", "gpio120", "gpio121", "gpio122",
"gpio123", "gpio124",
};
static const char * const phase_flag_groups[] = {
"gpio29",
"gpio30",
"gpio52",
"gpio53",
"gpio54",
"gpio55",
"gpio56",
"gpio57",
"gpio75",
"gpio76",
"gpio77",
"gpio89",
"gpio90",
"gpio96",
"gpio99",
"gpio100",
"gpio101",
"gpio137",
"gpio138",
"gpio139",
"gpio140",
"gpio141",
"gpio142",
"gpio143",
};
It should be this, will post tomorrow:
static const char * const phase_flag_groups[] = {
"gpio29", "gpio30", "gpio52", "gpio53", "gpio54", "gpio55", "gpio56",
"gpio57", "gpio75", "gpio76", "gpio77", "gpio89", "gpio90", "gpio96",
"gpio99", "gpio100", "gpio101", "gpio137", "gpio138", "gpio139",
"gpio140", "gpio141", "gpio142", "gpio143",
};
>
> Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Assuming this isn't invalidated by the above change.
>
> Regards,
> Bjorn
next prev parent reply other threads:[~2022-10-04 1:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 21:07 [PATCH v6 0/3] SDM670 Pin Control Driver Richard Acayan
2022-10-01 21:07 ` [PATCH v6 1/3] dt-bindings: pinctrl: qcom: add sdm670 pinctrl Richard Acayan
2022-10-04 0:25 ` Bjorn Andersson
2022-10-01 21:07 ` [PATCH v6 2/3] pinctrl: qcom: add support for complementary reserved gpios Richard Acayan
2022-10-04 0:17 ` Bjorn Andersson
2022-10-04 0:52 ` Richard Acayan
2022-10-01 21:07 ` [PATCH v6 3/3] pinctrl: qcom: add sdm670 pinctrl Richard Acayan
2022-10-04 0:23 ` Bjorn Andersson
2022-10-04 1:00 ` Richard Acayan [this message]
2022-10-03 19:16 ` [PATCH v6 0/3] SDM670 Pin Control Driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004010010.34499-1-mailingradian@gmail.com \
--to=mailingradian@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).