From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE72C433FE for ; Tue, 4 Oct 2022 16:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbiJDQgy (ORCPT ); Tue, 4 Oct 2022 12:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbiJDQgy (ORCPT ); Tue, 4 Oct 2022 12:36:54 -0400 Received: from smtp1.tecnico.ulisboa.pt (smtp1.tecnico.ulisboa.pt [IPv6:2001:690:2100:1::15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 703615E579; Tue, 4 Oct 2022 09:36:52 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp1.tecnico.ulisboa.pt (Postfix) with ESMTP id 074816005417; Tue, 4 Oct 2022 17:36:50 +0100 (WEST) X-Virus-Scanned: by amavisd-new-2.11.0 (20160426) (Debian) at tecnico.ulisboa.pt Received: from smtp1.tecnico.ulisboa.pt ([127.0.0.1]) by localhost (smtp1.tecnico.ulisboa.pt [127.0.0.1]) (amavisd-new, port 10025) with LMTP id j8yPc4mpqb_j; Tue, 4 Oct 2022 17:36:47 +0100 (WEST) Received: from mail1.tecnico.ulisboa.pt (mail1.ist.utl.pt [IPv6:2001:690:2100:1::b3dd:b9ac]) by smtp1.tecnico.ulisboa.pt (Postfix) with ESMTPS id 0E566600881E; Tue, 4 Oct 2022 17:36:45 +0100 (WEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tecnico.ulisboa.pt; s=mail; t=1664901407; bh=DMhcGkQbTq6SDO0SLsiFN4a0xZV0HfX1yyp+AGRsmVo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=fabVcPBNbSXlLC7+WUv5tqiPTOvXo7j6AWxsirSb9ZAAs5TBaofkbX8nH15fURDWi b0YZ/T8CHc5BQt9d0Gp0oe2dJQAshoByDzia6i6beu2KnhknCX6/BpU3VC4jUwwq3Z KzCcthCBp5fPl8PwJtoa0cSOlD5HAnue6jO9lJOo= Received: from wslaptop (unknown [IPv6:2001:818:dcb5:dc00:7a88:7f12:8ed8:518d]) (Authenticated sender: ist187313) by mail1.tecnico.ulisboa.pt (Postfix) with ESMTPSA id B7304360083; Tue, 4 Oct 2022 17:36:44 +0100 (WEST) Date: Tue, 4 Oct 2022 17:37:18 +0100 From: Diogo Ivo To: Krzysztof Kozlowski Cc: thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, jonathanh@nvidia.com, arnd@arndb.de, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, diogo.ivo@tecnico.ulisboa.pt Subject: Re: [PATCH 1/4] dt-bindings: display: Add bindings for JDI LPM102A188A Message-ID: <20221004163718.ederwgmvt24kvhms@wslaptop> References: <20220929170502.1034040-1-diogo.ivo@tecnico.ulisboa.pt> <20220929170502.1034040-2-diogo.ivo@tecnico.ulisboa.pt> <20221003170634.56jibls3xjxiiulg@wslaptop> <98d3b42d-3f9f-9b6e-8c17-46deae4b4030@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98d3b42d-3f9f-9b6e-8c17-46deae4b4030@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Oct 04, 2022 at 01:05:04PM +0200, Krzysztof Kozlowski wrote: > On 03/10/2022 19:06, Diogo Ivo wrote: > > On Fri, Sep 30, 2022 at 12:49:31PM +0200, Krzysztof Kozlowski wrote: > >> Isn't touchscreen a separate (input) device? > > > > Hello, thank you for the feedback. > > > > According to the downstream kernel's log, it seems like the panel and > > the touchscreen controller are considered to be embedded in the same unit > > (for example in [1]), > > Downstream kernel is not a proof of proper description of hardware. If > downstream says orange is an apple, does it mean orange is really an > apple? No... Downstream creates a lot of junk, hacks and workarounds. After some searching (which I should have done sooner, so apologies) I came across a teardown of the Pixel C ([1], for completeness), which incorporates this panel. Indeed a separate touch controller was found, so it seems the downstream kernel threw me off as per your warning. [1]: https://www.ifixit.com/Teardown/Google+Pixel+C+Teardown/62277 (Step 4) > > with the touch input being transmitted via HID-over-I2C, > > and since I did not find any reset gpio handling in that driver I opted to > > include this reset here, unless there is a better way of going about this. > > Instead it should be in touch screen device. Noted, I will remove it from the binding in the next version. > Where is the DTS of that device? The relevant part of the DTS can be found here: https://android.googlesource.com/kernel/tegra/+/refs/heads/android-tegra-dragon-3.18-oreo/arch/arm64/boot/dts/tegra/tegra210-smaug.dtsi Best regards, Diogo