From: Richard Acayan <mailingradian@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Richard Acayan <mailingradian@gmail.com>,
Lee Jones <lee@kernel.org>,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v7 3/3] pinctrl: qcom: add sdm670 pinctrl
Date: Wed, 5 Oct 2022 18:23:50 -0400 [thread overview]
Message-ID: <20221005222350.47420-1-mailingradian@gmail.com> (raw)
In-Reply-To: <1ed91afd-74d2-1ab0-0d15-1b6e0dfba13b@linaro.org>
> On 04/10/2022 23:58, Richard Acayan wrote:
> > The Snapdragon 670 has a Top-Level Mode Multiplexer (TLMM) for various
> > features. Add a driver to support it.
>
> (...)
>
> > +
> > +const int sdm670_reserved_gpios[] = {
> > + 58, 59, 60, 61, 62, 63, 64, 69, 70, 71, 72, 73, 74, 104, -1
> > +};
> > +
> > +static const struct msm_pinctrl_soc_data sdm670_pinctrl = {
> > + .pins = sdm670_pins,
> > + .npins = ARRAY_SIZE(sdm670_pins),
> > + .functions = sdm670_functions,
> > + .nfunctions = ARRAY_SIZE(sdm670_functions),
> > + .groups = sdm670_groups,
> > + .ngroups = ARRAY_SIZE(sdm670_groups),
> > + .ngpios = 151,
> > + .reserved_gpios = sdm670_reserved_gpios,
> > + .complement_fw_gpio_ranges = true,
>
> This still fails to build... v6 was not compilable, v7 is still.
Sorry, I only see the problem with complement_fw_gpio_ranges being removed from
the struct and not being removed here (in v7). Is there another issue that
affected v6?
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-10-05 22:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 21:58 [PATCH v7 0/3] SDM670 Pin Control Driver Richard Acayan
2022-10-04 21:58 ` [PATCH v7 1/3] dt-bindings: pinctrl: qcom: add sdm670 pinctrl Richard Acayan
2022-10-04 21:58 ` [PATCH v7 2/3] pinctrl: qcom: do not reinitialize gpio valid mask Richard Acayan
2022-10-04 21:58 ` [PATCH v7 3/3] pinctrl: qcom: add sdm670 pinctrl Richard Acayan
2022-10-05 5:46 ` kernel test robot
2022-10-05 14:35 ` Krzysztof Kozlowski
2022-10-05 22:23 ` Richard Acayan [this message]
2022-10-06 7:14 ` Krzysztof Kozlowski
2022-10-05 15:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005222350.47420-1-mailingradian@gmail.com \
--to=mailingradian@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).