From: Rob Herring <robh@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, Rich Felker <dalias@libc.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] of: fdt: add stub for early_init_dt_scan()
Date: Thu, 6 Oct 2022 14:38:20 -0500 [thread overview]
Message-ID: <20221006193820.GA61296-robh@kernel.org> (raw)
In-Reply-To: <20221006031116.13586-1-rdunlap@infradead.org>
On Wed, Oct 05, 2022 at 08:11:16PM -0700, Randy Dunlap wrote:
> When CONFIG_OF_EARLY_FLATTREE and CONFIG_SH_DEVICE_TREE are not set,
> SH3 build fails with a call to early_init_dt_scan(), so add a stub for
> this function.
>
> ../arch/sh/kernel/setup.c: In function 'sh_fdt_init':
> ../arch/sh/kernel/setup.c:262:26: error: implicit declaration of function 'early_init_dt_scan' [-Werror=implicit-function-declaration]
> 262 | if (!dt_virt || !early_init_dt_scan(dt_virt)) {
I think that sh_fdt_init() needs to be enclosed in
CONFIG_OF_EARLY_FLATTREE instead of CONFIG_OF_FLATTREE.
>
> Fixes: 7480e0aabd5f ("sh: add device tree support and generic board using device tree")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: Rich Felker <dalias@libc.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
> include/linux/of_fdt.h | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -85,6 +85,7 @@ extern void early_init_devtree(void *);
> extern void early_get_first_memblock_info(void *, phys_addr_t *);
> #else /* CONFIG_OF_EARLY_FLATTREE */
> static inline void early_init_dt_check_for_usable_mem_range(void) {}
> +static inline bool early_init_dt_scan(void *params) { return false; }
> static inline int early_init_dt_scan_chosen_stdout(void) { return -ENODEV; }
> static inline void early_init_fdt_scan_reserved_mem(void) {}
> static inline void early_init_fdt_reserve_self(void) {}
>
next prev parent reply other threads:[~2022-10-06 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 3:11 [PATCH] of: fdt: add stub for early_init_dt_scan() Randy Dunlap
2022-10-06 19:38 ` Rob Herring [this message]
2022-10-06 19:43 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006193820.GA61296-robh@kernel.org \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).