From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD7B4C433FE for ; Sun, 9 Oct 2022 11:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbiJILPl (ORCPT ); Sun, 9 Oct 2022 07:15:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbiJILPl (ORCPT ); Sun, 9 Oct 2022 07:15:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4777E2B24C; Sun, 9 Oct 2022 04:15:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 48064B80CB9; Sun, 9 Oct 2022 11:15:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF917C433C1; Sun, 9 Oct 2022 11:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665314133; bh=wccPJLuH2DYbLdfSoyHm5U/6vyVfxSEwO2LCbBJoTmI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZAkjhh3wUFCs0GYGGZ9pZ1dsGpWfE69dKhRZTTCMzzjAx+079DTo1wkrqXH5yiKPe bN+W3QxzOWnvM8UsuY/qkgLD+xwwZbyFEV4JpBHfvdVgNnSo69wnyAqcr/Hg3XhgSl Z2TFiosUqGaNAOSopU7przq4zwTXZ3AZIrDUDWByqDW67BNt2/I+Ty8nVfu1vkmWAx urKUZQ6beZoqbfW+HZR9W+9N+pzCiQ7mij4K8IRXb+0pSmet1b4MtahQWEqDHaA2PR uLYbf8VXptd28KvqFbB+AHry00Q2EaLwX5s6tl7LVvTwJy+qIh5YYIIQmp/gKM2yIm SGln/Ve6gFTYg== Received: by pali.im (Postfix) id E03897C1; Sun, 9 Oct 2022 13:15:29 +0200 (CEST) Date: Sun, 9 Oct 2022 13:15:29 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Gregory Clement Cc: Andrew Lunn , Sebastian Hesselbarth , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marek =?utf-8?B?QmVow7pu?= Subject: Re: [PATCH 0/6] ARM: dts: pci-mvebu: Fix assigned-addresses for every PCIe Root Port Message-ID: <20221009111529.2eo2mwca3ywfkajy@pali> References: <20220817223053.31141-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220817223053.31141-1-pali@kernel.org> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Gregory, ping? On Thursday 18 August 2022 00:30:47 Pali Rohár wrote: > Per IEEE Std 1275-1994 bindings documentation (to which kernel DT > bindings refers), DT property assigned-addresses contains BDF address > of resource. Currently more PCIe Root Port nodes have BDF address in > assigned-addresses which points to different PCIe Root Port nodes. This > obviously does not make sense as the address resource specified in > assigned-addresses of every PCIe Root Port describes address range of > internal registers which are specific for corresponding Marvell PCIe > Root Port. Fix this issue and align all BDF addresses in > assigned-addresses DT property to specify correct BDF address of the > current PCIe Root Port. > > Note that current version of pci-mvebu.c controller driver, which > registers Marvell PCIe Root Ports, ignores BDF value in DT property > assigned-addresses. It expects that Root Port's assigned-addresses > contains address range of that root port. That is why driver currently > works without any issue and nobody spotted it. But if driver or > something else would do device tree validation then this issue should be > spotted and throws error. Also device tree files may be used by other > projects where drivers may require correct values. > > This patch series aligns BDF address of every Marvell PCIe Root Port in > node name, config space in reg property and mem in assigned-address > property of internal registers resource. > > Pali Rohár (6): > ARM: dts: dove: Fix assigned-addresses for every PCIe Root Port > ARM: dts: armada-370: Fix assigned-addresses for every PCIe Root Port > ARM: dts: armada-xp: Fix assigned-addresses for every PCIe Root Port > ARM: dts: armada-375: Fix assigned-addresses for every PCIe Root Port > ARM: dts: armada-38x: Fix assigned-addresses for every PCIe Root Port > ARM: dts: armada-39x: Fix assigned-addresses for every PCIe Root Port > > arch/arm/boot/dts/armada-370.dtsi | 2 +- > arch/arm/boot/dts/armada-375.dtsi | 2 +- > arch/arm/boot/dts/armada-380.dtsi | 4 ++-- > arch/arm/boot/dts/armada-385.dtsi | 6 +++--- > arch/arm/boot/dts/armada-39x.dtsi | 6 +++--- > arch/arm/boot/dts/armada-xp-mv78230.dtsi | 8 ++++---- > arch/arm/boot/dts/armada-xp-mv78260.dtsi | 16 ++++++++-------- > arch/arm/boot/dts/dove.dtsi | 2 +- > 8 files changed, 23 insertions(+), 23 deletions(-) > > -- > 2.20.1 >