From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F01ADC43217 for ; Thu, 13 Oct 2022 10:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbiJMKOa (ORCPT ); Thu, 13 Oct 2022 06:14:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbiJMKO0 (ORCPT ); Thu, 13 Oct 2022 06:14:26 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B67142E6D for ; Thu, 13 Oct 2022 03:14:25 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oivEC-0004MS-Vg; Thu, 13 Oct 2022 12:14:12 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oivEC-0008EZ-EU; Thu, 13 Oct 2022 12:14:12 +0200 Date: Thu, 13 Oct 2022 12:14:12 +0200 From: Sascha Hauer To: Rob Herring Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Chen , Peng Fan , Pengutronix Kernel Team , devicetree@vger.kernel.org Subject: Re: [PATCH 6/6] dt-bindings: usb: ci-hdrc-usb2: Add more phy tuning properties Message-ID: <20221013101412.GI6702@pengutronix.de> References: <20221011082924.884123-1-s.hauer@pengutronix.de> <20221011082924.884123-7-s.hauer@pengutronix.de> <20221012160806.GA2189350-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221012160806.GA2189350-robh@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Oct 12, 2022 at 11:08:06AM -0500, Rob Herring wrote: > On Tue, Oct 11, 2022 at 10:29:24AM +0200, Sascha Hauer wrote: > > Following the example of samsung,picophy-dc-vol-level-adjust more > > phy tuning properties are added for configuring the remaining bitfields > > in the USBNC_n_PHY_CFG1 register. > > All these properties really doesn't scale. These properties should go > in the phy node as they are properties or the phy. There's no rule that > you can only read properties from the driver's device node. I understand and agree. On i.MX8M we currently use the usb-nop-xceiv. I guess it's not an option to just add these properties there, so we'll need a phy node with a new compatible like fsl,imx8mm-usbphy. The driver would basically just register a usb-nop-xceiv and the node would be a container for the new property. Does this sound sane? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |