From: Rob Herring <robh@kernel.org>
To: Dominic Rath <dominic.rath@ibv-augsburg.de>
Cc: krzysztof.kozlowski+dt@linaro.org, tjoseph@cadence.com,
bhelgaas@google.com, lpieralisi@kernel.org, nm@ti.com,
vigneshr@ti.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Alexander Bahle <bahle@ibv-augsburg.de>,
Dominic Rath <rath@ibv-augsburg.de>
Subject: Re: [PATCH 1/3] dt-bindings: PCI: cdns: Add PHY latency properties
Date: Thu, 13 Oct 2022 14:12:49 -0500 [thread overview]
Message-ID: <20221013191249.GA38183-robh@kernel.org> (raw)
In-Reply-To: <20221013062649.303184-2-dominic.rath@ibv-augsburg.de>
On Thu, Oct 13, 2022 at 08:26:47AM +0200, Dominic Rath wrote:
> From: Alexander Bahle <bahle@ibv-augsburg.de>
>
> Add "cdns,tx-phy-latency-ps" and "cdns,rx-phy-latency-ps" DT bindings for
> setting the PCIe PHY latencies.
> The properties expect a list of uint32 PHY latencies in picoseconds for
> every supported speed starting at PCIe Gen1, e.g.:
>
> max-link-speed = <2>;
> tx-phy-latency-ps = <100000 200000>; /* Gen1: 100ns, Gen2: 200ns */
> rx-phy-latency-ps = <150000 250000>; /* Gen1: 150ns, Gen2: 250ns */
These are a property of the PHY or PCI host? Sounds like PHY to me and
that should be in the PHY node. No reason the PCI driver can't go read
PHY node properties.
If PTM is a standard PCIe thing, then I don't think these should be
Cadence specific. IOW, drop 'cdns'.
Rob
next prev parent reply other threads:[~2022-10-13 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 6:26 [PATCH 0/3] Cadence PCIe PHY latency for PTM Dominic Rath
2022-10-13 6:26 ` [PATCH 1/3] dt-bindings: PCI: cdns: Add PHY latency properties Dominic Rath
2022-10-13 11:22 ` Rob Herring
2022-10-13 19:12 ` Rob Herring [this message]
2022-10-13 19:32 ` Bjorn Helgaas
2022-10-14 13:41 ` Dominic Rath
2022-11-08 8:02 ` Vignesh Raghavendra
2023-03-21 8:42 ` Christian Gmeiner
2022-10-13 6:26 ` [PATCH 2/3] PCI: cadence: Use DT bindings to set PHY latencies Dominic Rath
2022-10-13 13:59 ` Bjorn Helgaas
2022-10-13 6:26 ` [PATCH 3/3] arm64: dts: ti: k3-am64-main: Add latency DT binding Dominic Rath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013191249.GA38183-robh@kernel.org \
--to=robh@kernel.org \
--cc=bahle@ibv-augsburg.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dominic.rath@ibv-augsburg.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=nm@ti.com \
--cc=rath@ibv-augsburg.de \
--cc=tjoseph@cadence.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).