* [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
2022-10-14 9:51 [PATCH V2 0/6] dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml Peng Fan (OSS)
@ 2022-10-14 9:51 ` Peng Fan (OSS)
2022-10-14 11:56 ` Greg KH
2022-10-15 14:53 ` Krzysztof Kozlowski
2022-10-14 9:51 ` [PATCH V2 2/6] dt-bindings: usb: usbmisc-imx: add clocks property Peng Fan (OSS)
` (4 subsequent siblings)
5 siblings, 2 replies; 24+ messages in thread
From: Peng Fan (OSS) @ 2022-10-14 9:51 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer,
xu.yang_2
Cc: kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Convert usbmisc-imx to DT schema format.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/fsl,usbmisc.yaml | 52 +++++++++++++++++++
.../devicetree/bindings/usb/usbmisc-imx.txt | 18 -------
2 files changed, 52 insertions(+), 18 deletions(-)
create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
new file mode 100644
index 000000000000..c83ffb6729b5
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/fsl,usbmisc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale i.MX non-core registers
+
+maintainers:
+ - Xu Yang <xu.yang_2@nxp.com>
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - fsl,imx6q-usbmisc
+ - fsl,imx7ulp-usbmisc
+ - fsl,vf610-usbmisc
+ - items:
+ - enum:
+ - fsl,imx6ul-usbmisc
+ - fsl,imx6sx-usbmisc
+ - fsl,imx7d-usbmisc
+ - const: fsl,imx6q-usbmisc
+ - items:
+ - enum:
+ - fsl,imx7ulp-usbmisc
+ - const: fsl,imx7d-usbmisc
+
+ reg:
+ maxItems: 1
+
+ '#index-cells':
+ const: 1
+ description: Cells used to describe usb controller index.
+
+required:
+ - compatible
+ - reg
+ - '#index-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ usbmisc@2184800 {
+ #index-cells = <1>;
+ compatible = "fsl,imx6q-usbmisc";
+ reg = <0x02184800 0x200>;
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
deleted file mode 100644
index b796836d2ce7..000000000000
--- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-* Freescale i.MX non-core registers
-
-Required properties:
-- #index-cells: Cells used to describe usb controller index. Should be <1>
-- compatible: Should be one of below:
- "fsl,imx6q-usbmisc" for imx6q
- "fsl,vf610-usbmisc" for Vybrid vf610
- "fsl,imx6sx-usbmisc" for imx6sx
- "fsl,imx7d-usbmisc" for imx7d
- "fsl,imx7ulp-usbmisc" for imx7ulp
-- reg: Should contain registers location and length
-
-Examples:
-usbmisc@2184800 {
- #index-cells = <1>;
- compatible = "fsl,imx6q-usbmisc";
- reg = <0x02184800 0x200>;
-};
--
2.37.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
2022-10-14 9:51 ` [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema Peng Fan (OSS)
@ 2022-10-14 11:56 ` Greg KH
2022-10-17 2:53 ` Peng Fan
2022-10-15 14:53 ` Krzysztof Kozlowski
1 sibling, 1 reply; 24+ messages in thread
From: Greg KH @ 2022-10-14 11:56 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, xu.yang_2,
kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
On Fri, Oct 14, 2022 at 05:51:43PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert usbmisc-imx to DT schema format.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../devicetree/bindings/usb/fsl,usbmisc.yaml | 52 +++++++++++++++++++
> .../devicetree/bindings/usb/usbmisc-imx.txt | 18 -------
> 2 files changed, 52 insertions(+), 18 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> new file mode 100644
> index 000000000000..c83ffb6729b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/fsl,usbmisc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX non-core registers
> +
> +maintainers:
> + - Xu Yang <xu.yang_2@nxp.com>
Signing someone else up to be a maintainer requires them to sign off on
the patch to agree with this. Why not list yourself instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
2022-10-14 11:56 ` Greg KH
@ 2022-10-17 2:53 ` Peng Fan
0 siblings, 0 replies; 24+ messages in thread
From: Peng Fan @ 2022-10-17 2:53 UTC (permalink / raw)
To: Greg KH, Peng Fan (OSS)
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de, Xu Yang,
kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jun Li
Hi Greg,
> Subject: Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT
> schema
>
> On Fri, Oct 14, 2022 at 05:51:43PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Convert usbmisc-imx to DT schema format.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > .../devicetree/bindings/usb/fsl,usbmisc.yaml | 52 +++++++++++++++++++
> > .../devicetree/bindings/usb/usbmisc-imx.txt | 18 -------
> > 2 files changed, 52 insertions(+), 18 deletions(-) create mode
> > 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > delete mode 100644
> > Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > new file mode 100644
> > index 000000000000..c83ffb6729b5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmisc.yaml%23&data=05
> %7C01%7
> >
> +Cpeng.fan%40nxp.com%7C15ebc6c1040f46f3ecef08daaddafa7a%7C686ea
> 1d3bc2b
> >
> +4c6fa92cd99c5c301635%7C0%7C0%7C638013453273330209%7CUnknown
> %7CTWFpbGZ
> >
> +sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%
> >
> +3D%7C3000%7C%7C%7C&sdata=NZ4SFEve9DqdFVremHTDVGgrpISKyj
> yoEJKYE4sk
> > +7tA%3D&reserved=0
> > +$schema:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > +cetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&data=05%7C01%7Cpeng.fan%
> >
> +40nxp.com%7C15ebc6c1040f46f3ecef08daaddafa7a%7C686ea1d3bc2b4c6f
> a92cd9
> >
> +9c5c301635%7C0%7C0%7C638013453273330209%7CUnknown%7CTWFpb
> GZsb3d8eyJWI
> >
> +joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> C3000%
> >
> +7C%7C%7C&sdata=SYlpPoSmOQxNYaJFAlvwPQRFq0Oaugwc%2F52w6
> tvgcrk%3D&a
> > +mp;reserved=0
> > +
> > +title: Freescale i.MX non-core registers
> > +
> > +maintainers:
> > + - Xu Yang <xu.yang_2@nxp.com>
>
> Signing someone else up to be a maintainer requires them to sign off on the
> patch to agree with this. Why not list yourself instead?
I am not expert in USB area. I am just convert the file to yaml to ease the upstream
of i.MX device tree.
Is it ok for for Xu Yang to Ack the patch or I must add:
Signed-off-by: Xu Yang <xu.yang_2@nxp.com> in the patch?
Thanks,
Peng.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
2022-10-14 9:51 ` [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema Peng Fan (OSS)
2022-10-14 11:56 ` Greg KH
@ 2022-10-15 14:53 ` Krzysztof Kozlowski
2022-10-17 3:17 ` [EXT] " Xu Yang
1 sibling, 1 reply; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-15 14:53 UTC (permalink / raw)
To: Peng Fan (OSS), gregkh, robh+dt, krzysztof.kozlowski+dt, shawnguo,
s.hauer, xu.yang_2
Cc: kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
On 14/10/2022 05:51, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert usbmisc-imx to DT schema format.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../devicetree/bindings/usb/fsl,usbmisc.yaml | 52 +++++++++++++++++++
> .../devicetree/bindings/usb/usbmisc-imx.txt | 18 -------
> 2 files changed, 52 insertions(+), 18 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> new file mode 100644
> index 000000000000..c83ffb6729b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/fsl,usbmisc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX non-core registers
You sent v2 before we finished this topic. Is it correct? Even if TXT
had such title, let's don't keep the wrong name.
If it is non-core registers, why it is in USB? Why it is an usb-misc device?
> +
> +maintainers:
> + - Xu Yang <xu.yang_2@nxp.com>
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
2022-10-15 14:53 ` Krzysztof Kozlowski
@ 2022-10-17 3:17 ` Xu Yang
2022-10-18 22:51 ` Krzysztof Kozlowski
0 siblings, 1 reply; 24+ messages in thread
From: Xu Yang @ 2022-10-17 3:17 UTC (permalink / raw)
To: Krzysztof Kozlowski, Peng Fan (OSS), gregkh@linuxfoundation.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jun Li, Peng Fan
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Saturday, October 15, 2022 10:53 PM
> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>; gregkh@linuxfoundation.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; s.hauer@pengutronix.de; Xu Yang <xu.yang_2@nxp.com>
> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jun Li <jun.li@nxp.com>;
> Peng Fan <peng.fan@nxp.com>
> Subject: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
>
> Caution: EXT Email
>
> On 14/10/2022 05:51, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Convert usbmisc-imx to DT schema format.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > .../devicetree/bindings/usb/fsl,usbmisc.yaml | 52 +++++++++++++++++++
> > .../devicetree/bindings/usb/usbmisc-imx.txt | 18 -------
> > 2 files changed, 52 insertions(+), 18 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > new file mode 100644
> > index 000000000000..c83ffb6729b5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmi
> sc.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C686ea1d3bc2b4c6
> fa92cd99c5c301635%7C0%7C0%7C638014423898086337%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gNwMbGsiuMS1zgvbgATYAY70gv2nIhX%2F
> 16IxiSYBf3s%3D&reserved=0
> > +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C68
> 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638014423898242035%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jJUP5aKNkfkAefhNQL9almV
> Gqzn8cTNyjcRlZMOZwRk%3D&reserved=0
> > +
> > +title: Freescale i.MX non-core registers
>
> You sent v2 before we finished this topic. Is it correct? Even if TXT
> had such title, let's don't keep the wrong name.
>
> If it is non-core registers, why it is in USB? Why it is an usb-misc device?
The chipidea's doc has a more clear explanation about core and non-core
registers as follow:
"There are two kinds of registers in the USB module: USB core registers
and USB non-core registers. USB core registers are used to control USB
core functions, and more independent of USB features. Each USB controller
core has its own core registers. USB non-core registers are additional
to USB core registers, and more dependent on USB features. i.MX series
products vary in non-core registers."
So we have named it like this.
Thanks,
Xu Yang
>
> > +
> > +maintainers:
> > + - Xu Yang <xu.yang_2@nxp.com>
> > +
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
2022-10-17 3:17 ` [EXT] " Xu Yang
@ 2022-10-18 22:51 ` Krzysztof Kozlowski
2022-10-19 2:10 ` Jun Li
0 siblings, 1 reply; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-18 22:51 UTC (permalink / raw)
To: Xu Yang, Peng Fan (OSS), gregkh@linuxfoundation.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jun Li, Peng Fan
On 16/10/2022 23:17, Xu Yang wrote:
> Hi Krzysztof,
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Saturday, October 15, 2022 10:53 PM
>> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>; gregkh@linuxfoundation.org; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; s.hauer@pengutronix.de; Xu Yang <xu.yang_2@nxp.com>
>> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jun Li <jun.li@nxp.com>;
>> Peng Fan <peng.fan@nxp.com>
>> Subject: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
>>
>> Caution: EXT Email
>>
>> On 14/10/2022 05:51, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> Convert usbmisc-imx to DT schema format.
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>> .../devicetree/bindings/usb/fsl,usbmisc.yaml | 52 +++++++++++++++++++
>>> .../devicetree/bindings/usb/usbmisc-imx.txt | 18 -------
>>> 2 files changed, 52 insertions(+), 18 deletions(-)
>>> create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>>> delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>> b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>>> new file mode 100644
>>> index 000000000000..c83ffb6729b5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>>> @@ -0,0 +1,52 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id:
>> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmi
>> sc.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C686ea1d3bc2b4c6
>> fa92cd99c5c301635%7C0%7C0%7C638014423898086337%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
>> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gNwMbGsiuMS1zgvbgATYAY70gv2nIhX%2F
>> 16IxiSYBf3s%3D&reserved=0
>>> +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-
>> schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C68
>> 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638014423898242035%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
>> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jJUP5aKNkfkAefhNQL9almV
>> Gqzn8cTNyjcRlZMOZwRk%3D&reserved=0
>>> +
>>> +title: Freescale i.MX non-core registers
>>
>> You sent v2 before we finished this topic. Is it correct? Even if TXT
>> had such title, let's don't keep the wrong name.
>>
>> If it is non-core registers, why it is in USB? Why it is an usb-misc device?
>
> The chipidea's doc has a more clear explanation about core and non-core
> registers as follow:
>
> "There are two kinds of registers in the USB module: USB core registers
> and USB non-core registers. USB core registers are used to control USB
> core functions, and more independent of USB features. Each USB controller
> core has its own core registers. USB non-core registers are additional
> to USB core registers, and more dependent on USB features. i.MX series
> products vary in non-core registers."
>
> So we have named it like this.
"Freescale i.MX non-core registers" implies this hardware is about i.MX
registers. i.MX like for all SoCs.
What you wrote now, about USB registers - quite different.
However if you describe here registers, not some device, usually it's
place is not USB...
And actually all devices are bunch of registers, right? So everything
should be called registers?
Name is poor choice, so please find more appropriate one matching real
purpose of this block.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
2022-10-18 22:51 ` Krzysztof Kozlowski
@ 2022-10-19 2:10 ` Jun Li
2022-10-19 2:16 ` Krzysztof Kozlowski
0 siblings, 1 reply; 24+ messages in thread
From: Jun Li @ 2022-10-19 2:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Xu Yang, Peng Fan (OSS),
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Peng Fan
Hi,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, October 19, 2022 6:52 AM
> To: Xu Yang <xu.yang_2@nxp.com>; Peng Fan (OSS) <peng.fan@oss.nxp.com>;
> gregkh@linuxfoundation.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de
> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; Jun Li <jun.li@nxp.com>; Peng Fan
> <peng.fan@nxp.com>
> Subject: Re: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert
> to DT schema
>
> On 16/10/2022 23:17, Xu Yang wrote:
> > Hi Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Saturday, October 15, 2022 10:53 PM
> >> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>;
> >> gregkh@linuxfoundation.org; robh+dt@kernel.org;
> >> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> >> s.hauer@pengutronix.de; Xu Yang <xu.yang_2@nxp.com>
> >> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> >> <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> linux-arm-kernel@lists.infradead.org; Jun Li <jun.li@nxp.com>; Peng
> >> Fan <peng.fan@nxp.com>
> >> Subject: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx:
> >> convert to DT schema
> >>
> >> Caution: EXT Email
> >>
> >> On 14/10/2022 05:51, Peng Fan (OSS) wrote:
> >>> From: Peng Fan <peng.fan@nxp.com>
> >>>
> >>> Convert usbmisc-imx to DT schema format.
> >>>
> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >>> ---
> >>> .../devicetree/bindings/usb/fsl,usbmisc.yaml | 52
> +++++++++++++++++++
> >>> .../devicetree/bindings/usb/usbmisc-imx.txt | 18 -------
> >>> 2 files changed, 52 insertions(+), 18 deletions(-) create mode
> >>> 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >>> delete mode 100644
> >>> Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >> b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >>> new file mode 100644
> >>> index 000000000000..c83ffb6729b5
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >>> @@ -0,0 +1,52 @@
> >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> >>> +---
> >>> +$id:
> >>
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >>
> cetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmi&data=05%7C01%7Cjun.li%40
> >>
> nxp.com%7C15ee8a29acf04f95ff4108dab15b5b88%7C686ea1d3bc2b4c6fa92cd99c
> >>
> 5c301635%7C0%7C0%7C638017303177794862%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
> >>
> iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> >> %7C%7C&sdata=tovO%2F6fnxAMSUu9hTFv1Kgarmo%2BwxKCxS%2FeJAbt3e0k%3
> D
> >> &reserved=0
> >>
> sc.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018
> >> ff408daaebcf83d%7C686ea1d3bc2b4c6
> >>
> fa92cd99c5c301635%7C0%7C0%7C638014423898086337%7CUnknown%7CTWFpbGZsb3
> >> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
> >>
> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gNwM
> >> bGsiuMS1zgvbgATYAY70gv2nIhX%2F
> >> 16IxiSYBf3s%3D&reserved=0
> >>> +$schema:
> >>>
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde
> >>>
> +vicetree.org%2Fmeta-&data=05%7C01%7Cjun.li%40nxp.com%7C15ee8a29
> >>>
> +acf04f95ff4108dab15b5b88%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> >>>
> +%7C638017303177794862%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> >>>
> +CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&s
> >>>
> +data=NxKdgHlJ9q%2F82XtXwWxHf5UFJR3v08L83jomQxg3Blo%3D&reserved=
> >>> +0
> >>
> schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82
> >> b830d9f47018ff408daaebcf83d%7C68
> >>
> 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638014423898242035%7CUnknown
> >> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> >>
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a
> >> mp;sdata=jJUP5aKNkfkAefhNQL9almV
> >> Gqzn8cTNyjcRlZMOZwRk%3D&reserved=0
> >>> +
> >>> +title: Freescale i.MX non-core registers
> >>
> >> You sent v2 before we finished this topic. Is it correct? Even if TXT
> >> had such title, let's don't keep the wrong name.
> >>
> >> If it is non-core registers, why it is in USB? Why it is an usb-misc device?
> >
> > The chipidea's doc has a more clear explanation about core and
> > non-core registers as follow:
> >
> > "There are two kinds of registers in the USB module: USB core
> > registers and USB non-core registers. USB core registers are used to
> > control USB core functions, and more independent of USB features. Each
> > USB controller core has its own core registers. USB non-core registers
> > are additional to USB core registers, and more dependent on USB
> > features. i.MX series products vary in non-core registers."
> >
> > So we have named it like this.
>
> "Freescale i.MX non-core registers" implies this hardware is about i.MX
> registers. i.MX like for all SoCs.
>
> What you wrote now, about USB registers - quite different.
>
> However if you describe here registers, not some device, usually it's place
> is not USB...
>
> And actually all devices are bunch of registers, right? So everything should
> be called registers?
>
> Name is poor choice, so please find more appropriate one matching real purpose
> of this block.
How about "Freescale i.MX wrapper module for Chipidea USB2 controller"
Thanks
Li Jun
>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
2022-10-19 2:10 ` Jun Li
@ 2022-10-19 2:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-19 2:16 UTC (permalink / raw)
To: Jun Li, Xu Yang, Peng Fan (OSS), gregkh@linuxfoundation.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Peng Fan
On 18/10/2022 22:10, Jun Li wrote:
>>> So we have named it like this.
>>
>> "Freescale i.MX non-core registers" implies this hardware is about i.MX
>> registers. i.MX like for all SoCs.
>>
>> What you wrote now, about USB registers - quite different.
>>
>> However if you describe here registers, not some device, usually it's place
>> is not USB...
>>
>> And actually all devices are bunch of registers, right? So everything should
>> be called registers?
>>
>> Name is poor choice, so please find more appropriate one matching real purpose
>> of this block.
>
> How about "Freescale i.MX wrapper module for Chipidea USB2 controller"
>
Sounds very good, thank you.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH V2 2/6] dt-bindings: usb: usbmisc-imx: add clocks property
2022-10-14 9:51 [PATCH V2 0/6] dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml Peng Fan (OSS)
2022-10-14 9:51 ` [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema Peng Fan (OSS)
@ 2022-10-14 9:51 ` Peng Fan (OSS)
2022-10-14 21:29 ` Rob Herring
2022-10-14 9:51 ` [PATCH V2 3/6] dt-bindings: usb: usbmisc-imx: add more i.MX compatible Peng Fan (OSS)
` (3 subsequent siblings)
5 siblings, 1 reply; 24+ messages in thread
From: Peng Fan (OSS) @ 2022-10-14 9:51 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer,
xu.yang_2
Cc: kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Add optional clocks property
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
index c83ffb6729b5..89e2035436f8 100644
--- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
+++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
@@ -27,6 +27,9 @@ properties:
- fsl,imx7ulp-usbmisc
- const: fsl,imx7d-usbmisc
+ clocks:
+ maxItems: 1
+
reg:
maxItems: 1
--
2.37.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH V2 2/6] dt-bindings: usb: usbmisc-imx: add clocks property
2022-10-14 9:51 ` [PATCH V2 2/6] dt-bindings: usb: usbmisc-imx: add clocks property Peng Fan (OSS)
@ 2022-10-14 21:29 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-10-14 21:29 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: s.hauer, Peng Fan, krzysztof.kozlowski+dt, robh+dt, xu.yang_2,
linux-imx, linux-kernel, linux-usb, kernel, jun.li, gregkh,
shawnguo, devicetree, festevam, linux-arm-kernel
On Fri, 14 Oct 2022 17:51:44 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add optional clocks property
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH V2 3/6] dt-bindings: usb: usbmisc-imx: add more i.MX compatible
2022-10-14 9:51 [PATCH V2 0/6] dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml Peng Fan (OSS)
2022-10-14 9:51 ` [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema Peng Fan (OSS)
2022-10-14 9:51 ` [PATCH V2 2/6] dt-bindings: usb: usbmisc-imx: add clocks property Peng Fan (OSS)
@ 2022-10-14 9:51 ` Peng Fan (OSS)
2022-10-14 21:29 ` Rob Herring
2022-10-14 9:51 ` [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format Peng Fan (OSS)
` (2 subsequent siblings)
5 siblings, 1 reply; 24+ messages in thread
From: Peng Fan (OSS) @ 2022-10-14 9:51 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer,
xu.yang_2
Cc: kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Add more i.MX chips support
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/fsl,usbmisc.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
index 89e2035436f8..b465bdd12cc0 100644
--- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
+++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
@@ -13,19 +13,31 @@ properties:
compatible:
oneOf:
- enum:
+ - fsl,imx25-usbmisc
+ - fsl,imx27-usbmisc
+ - fsl,imx35-usbmisc
+ - fsl,imx51-usbmisc
+ - fsl,imx53-usbmisc
- fsl,imx6q-usbmisc
- fsl,imx7ulp-usbmisc
- fsl,vf610-usbmisc
- items:
- enum:
- fsl,imx6ul-usbmisc
+ - fsl,imx6sl-usbmisc
- fsl,imx6sx-usbmisc
- fsl,imx7d-usbmisc
- const: fsl,imx6q-usbmisc
- items:
- enum:
- fsl,imx7ulp-usbmisc
+ - fsl,imx8mm-usbmisc
+ - fsl,imx8mn-usbmisc
- const: fsl,imx7d-usbmisc
+ - items:
+ - const: fsl,imx6sll-usbmisc
+ - const: fsl,imx6ul-usbmisc
+ - const: fsl,imx6q-usbmisc
clocks:
maxItems: 1
--
2.37.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH V2 3/6] dt-bindings: usb: usbmisc-imx: add more i.MX compatible
2022-10-14 9:51 ` [PATCH V2 3/6] dt-bindings: usb: usbmisc-imx: add more i.MX compatible Peng Fan (OSS)
@ 2022-10-14 21:29 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-10-14 21:29 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: linux-imx, Peng Fan, xu.yang_2, robh+dt, shawnguo, kernel,
krzysztof.kozlowski+dt, linux-kernel, s.hauer, jun.li,
linux-arm-kernel, linux-usb, devicetree, festevam, gregkh
On Fri, 14 Oct 2022 17:51:45 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add more i.MX chips support
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../devicetree/bindings/usb/fsl,usbmisc.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format
2022-10-14 9:51 [PATCH V2 0/6] dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml Peng Fan (OSS)
` (2 preceding siblings ...)
2022-10-14 9:51 ` [PATCH V2 3/6] dt-bindings: usb: usbmisc-imx: add more i.MX compatible Peng Fan (OSS)
@ 2022-10-14 9:51 ` Peng Fan (OSS)
2022-10-14 14:28 ` Rob Herring
` (2 more replies)
2022-10-14 9:51 ` [PATCH V2 5/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX53/6SLL/UL compatible Peng Fan (OSS)
2022-10-14 9:51 ` [PATCH V2 6/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX8DXL/M[M,N] support Peng Fan (OSS)
5 siblings, 3 replies; 24+ messages in thread
From: Peng Fan (OSS) @ 2022-10-14 9:51 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer,
xu.yang_2
Cc: kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Convert the binding to DT schema format
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/ci-hdrc-usb2.txt | 158 --------
.../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 341 ++++++++++++++++++
2 files changed, 341 insertions(+), 158 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
deleted file mode 100644
index ba51fb1252b9..000000000000
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
+++ /dev/null
@@ -1,158 +0,0 @@
-* USB2 ChipIdea USB controller for ci13xxx
-
-Required properties:
-- compatible: should be one of:
- "fsl,imx23-usb"
- "fsl,imx27-usb"
- "fsl,imx28-usb"
- "fsl,imx6q-usb"
- "fsl,imx6sl-usb"
- "fsl,imx6sx-usb"
- "fsl,imx6ul-usb"
- "fsl,imx7d-usb"
- "fsl,imx7ulp-usb"
- "lsi,zevio-usb"
- "qcom,ci-hdrc"
- "chipidea,usb2"
- "xlnx,zynq-usb-2.20a"
- "nvidia,tegra20-udc"
- "nvidia,tegra30-udc"
- "nvidia,tegra114-udc"
- "nvidia,tegra124-udc"
-- reg: base address and length of the registers
-- interrupts: interrupt for the USB controller
-
-Recommended properies:
-- phy_type: the type of the phy connected to the core. Should be one
- of "utmi", "utmi_wide", "ulpi", "serial" or "hsic". Without this
- property the PORTSC register won't be touched.
-- dr_mode: One of "host", "peripheral" or "otg". Defaults to "otg"
-
-Deprecated properties:
-- usb-phy: phandle for the PHY device. Use "phys" instead.
-- fsl,usbphy: phandle of usb phy that connects to the port. Use "phys" instead.
-
-Optional properties:
-- clocks: reference to the USB clock
-- phys: reference to the USB PHY
-- phy-names: should be "usb-phy"
-- vbus-supply: reference to the VBUS regulator
-- maximum-speed: limit the maximum connection speed to "full-speed".
-- tpl-support: TPL (Targeted Peripheral List) feature for targeted hosts
-- itc-setting: interrupt threshold control register control, the setting
- should be aligned with ITC bits at register USBCMD.
-- ahb-burst-config: it is vendor dependent, the required value should be
- aligned with AHBBRST at SBUSCFG, the range is from 0x0 to 0x7. This
- property is used to change AHB burst configuration, check the chipidea
- spec for meaning of each value. If this property is not existed, it
- will use the reset value.
-- tx-burst-size-dword: it is vendor dependent, the tx burst size in dword
- (4 bytes), This register represents the maximum length of a the burst
- in 32-bit words while moving data from system memory to the USB
- bus, the value of this property will only take effect if property
- "ahb-burst-config" is set to 0, if this property is missing the reset
- default of the hardware implementation will be used.
-- rx-burst-size-dword: it is vendor dependent, the rx burst size in dword
- (4 bytes), This register represents the maximum length of a the burst
- in 32-bit words while moving data from the USB bus to system memory,
- the value of this property will only take effect if property
- "ahb-burst-config" is set to 0, if this property is missing the reset
- default of the hardware implementation will be used.
-- extcon: phandles to external connector devices. First phandle should point to
- external connector, which provide "USB" cable events, the second should point
- to external connector device, which provide "USB-HOST" cable events. If one
- of the external connector devices is not required, empty <0> phandle should
- be specified.
-- phy-clkgate-delay-us: the delay time (us) between putting the PHY into
- low power mode and gating the PHY clock.
-- non-zero-ttctrl-ttha: after setting this property, the value of register
- ttctrl.ttha will be 0x7f; if not, the value will be 0x0, this is the default
- value. It needs to be very carefully for setting this property, it is
- recommended that consult with your IC engineer before setting this value.
- On the most of chipidea platforms, the "usage_tt" flag at RTL is 0, so this
- property only affects siTD.
- If this property is not set, the max packet size is 1023 bytes, and if
- the total of packet size for pervious transactions are more than 256 bytes,
- it can't accept any transactions within this frame. The use case is single
- transaction, but higher frame rate.
- If this property is set, the max packet size is 188 bytes, it can handle
- more transactions than above case, it can accept transactions until it
- considers the left room size within frame is less than 188 bytes, software
- needs to make sure it does not send more than 90%
- maximum_periodic_data_per_frame. The use case is multiple transactions, but
- less frame rate.
-- mux-controls: The mux control for toggling host/device output of this
- controller. It's expected that a mux state of 0 indicates device mode and a
- mux state of 1 indicates host mode.
-- mux-control-names: Shall be "usb_switch" if mux-controls is specified.
-- pinctrl-names: Names for optional pin modes in "default", "host", "device".
- In case of HSIC-mode, "idle" and "active" pin modes are mandatory. In this
- case, the "idle" state needs to pull down the data and strobe pin
- and the "active" state needs to pull up the strobe pin.
-- pinctrl-n: alternate pin modes
-
-i.mx specific properties
-- fsl,usbmisc: phandler of non-core register device, with one
- argument that indicate usb controller index
-- disable-over-current: disable over current detect
-- over-current-active-low: over current signal polarity is active low.
-- over-current-active-high: over current signal polarity is active high.
- It's recommended to specify the over current polarity.
-- power-active-high: power signal polarity is active high
-- external-vbus-divider: enables off-chip resistor divider for Vbus
-- samsung,picophy-pre-emp-curr-control: HS Transmitter Pre-Emphasis Current
- Control. This signal controls the amount of current sourced to the
- USB_OTG*_DP and USB_OTG*_DN pins after a J-to-K or K-to-J transition.
- The range is from 0x0 to 0x3, the default value is 0x1.
- Details can refer to TXPREEMPAMPTUNE0 bits of USBNC_n_PHY_CFG1.
-- samsung,picophy-dc-vol-level-adjust: HS DC Voltage Level Adjustment.
- Adjust the high-speed transmitter DC level voltage.
- The range is from 0x0 to 0xf, the default value is 0x3.
- Details can refer to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1.
-
-Example:
-
- usb@f7ed0000 {
- compatible = "chipidea,usb2";
- reg = <0xf7ed0000 0x10000>;
- interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&chip CLKID_USB0>;
- phys = <&usb_phy0>;
- phy-names = "usb-phy";
- vbus-supply = <®_usb0_vbus>;
- itc-setting = <0x4>; /* 4 micro-frames */
- /* Incremental burst of unspecified length */
- ahb-burst-config = <0x0>;
- tx-burst-size-dword = <0x10>; /* 64 bytes */
- rx-burst-size-dword = <0x10>;
- extcon = <0>, <&usb_id>;
- phy-clkgate-delay-us = <400>;
- mux-controls = <&usb_switch>;
- mux-control-names = "usb_switch";
- };
-
-Example for HSIC:
-
- usb@2184400 {
- compatible = "fsl,imx6q-usb", "fsl,imx27-usb";
- reg = <0x02184400 0x200>;
- interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX6QDL_CLK_USBOH3>;
- fsl,usbphy = <&usbphynop1>;
- fsl,usbmisc = <&usbmisc 2>;
- phy_type = "hsic";
- dr_mode = "host";
- ahb-burst-config = <0x0>;
- tx-burst-size-dword = <0x10>;
- rx-burst-size-dword = <0x10>;
- pinctrl-names = "idle", "active";
- pinctrl-0 = <&pinctrl_usbh2_idle>;
- pinctrl-1 = <&pinctrl_usbh2_active>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- usbnet: ethernet@1 {
- compatible = "usb424,9730";
- reg = <1>;
- };
- };
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
new file mode 100644
index 000000000000..ed03649f17a6
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
@@ -0,0 +1,341 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/ci-hdrc-usb2.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: USB2 ChipIdea USB controller for ci13xxx Binding
+
+maintainers:
+ - Xu Yang <xu.yang_2@nxp.com>
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - chipidea,usb2
+ - lsi,zevio-usb
+ - nvidia,tegra20-udc
+ - nvidia,tegra30-udc
+ - nvidia,tegra114-udc
+ - nvidia,tegra124-udc
+ - qcom,ci-hdrc
+ - items:
+ - enum:
+ - fsl,imx23-usb
+ - fsl,imx25-usb
+ - fsl,imx28-usb
+ - fsl,imx6q-usb
+ - fsl,imx6sl-usb
+ - fsl,imx6sx-usb
+ - fsl,imx6ul-usb
+ - fsl,imx7d-usb
+ - const: fsl,imx27-usb
+ - items:
+ - const: fsl,imx7ulp-usb
+ - const: fsl,imx6ul-usb
+ - items:
+ - const: xlnx,zynq-usb-2.20a
+ - const: chipidea,usb2
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ dr_mode: true
+
+ phy_type: true
+
+ itc-setting:
+ description:
+ interrupt threshold control register control, the setting should be
+ aligned with ITC bits at register USBCMD.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ ahb-burst-config:
+ description:
+ it is vendor dependent, the required value should be aligned with
+ AHBBRST at SBUSCFG, the range is from 0x0 to 0x7. This property is
+ used to change AHB burst configuration, check the chipidea spec for
+ meaning of each value. If this property is not existed, it will use
+ the reset value.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0x0
+ maximum: 0x7
+
+ tx-burst-size-dword:
+ description:
+ it is vendor dependent, the tx burst size in dword (4 bytes), This
+ register represents the maximum length of a the burst in 32-bit
+ words while moving data from system memory to the USB bus, the value
+ of this property will only take effect if property "ahb-burst-config"
+ is set to 0, if this property is missing the reset default of the
+ hardware implementation will be used.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ rx-burst-size-dword:
+ description:
+ it is vendor dependent, the rx burst size in dword (4 bytes), This
+ register represents the maximum length of a the burst in 32-bit words
+ while moving data from the USB bus to system memory, the value of
+ this property will only take effect if property "ahb-burst-config"
+ is set to 0, if this property is missing the reset default of the
+ hardware implementation will be used.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ extcon:
+ description: |
+ Phandles to external connector devices. First phandle should point
+ to external connector, which provide "USB" cable events, the second
+ should point to external connector device, which provide "USB-HOST"
+ cable events. If one of the external connector devices is not
+ required, empty <0> phandle should be specified.
+
+ phy-clkgate-delay-us:
+ description: |
+ The delay time (us) between putting the PHY into low power mode and
+ gating the PHY clock.
+
+ non-zero-ttctrl-ttha:
+ description: |
+ After setting this property, the value of register ttctrl.ttha
+ will be 0x7f; if not, the value will be 0x0, this is the default
+ value. It needs to be very carefully for setting this property, it
+ is recommended that consult with your IC engineer before setting
+ this value. On the most of chipidea platforms, the "usage_tt" flag
+ at RTL is 0, so this property only affects siTD.
+
+ If this property is not set, the max packet size is 1023 bytes, and
+ if the total of packet size for pervious transactions are more than
+ 256 bytes, it can't accept any transactions within this frame. The
+ use case is single transaction, but higher frame rate.
+
+ If this property is set, the max packet size is 188 bytes, it can
+ handle more transactions than above case, it can accept transactions
+ until it considers the left room size within frame is less than 188
+ bytes, software needs to make sure it does not send more than 90%
+ maximum_periodic_data_per_frame. The use case is multiple
+ transactions, but less frame rate.
+
+ mux-controls:
+ description: |
+ The mux control for toggling host/device output of this controller.
+ It's expected that a mux state of 0 indicates device mode and a mux
+ state of 1 indicates host mode.
+
+ mux-control-names:
+ const: usb_switch
+
+ pinctrl-names:
+ description: |
+ Names for optional pin modes in "default", "host", "device".
+ In case of HSIC-mode, "idle" and "active" pin modes are mandatory.
+ In this case, the "idle" state needs to pull down the data and
+ strobe pin and the "active" state needs to pull up the strobe pin.
+
+ pinctrl-0:
+ maxItems: 1
+
+ pinctrl-1:
+ maxItems: 1
+
+ phys:
+ maxItems: 1
+
+ phy-names:
+ const: usb-phy
+
+ vbus-supply:
+ description: reference to the VBUS regulator.
+
+ fsl,usbmisc:
+ description:
+ Phandler of non-core register device, with one argument that
+ indicate usb controller index
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+
+ disable-over-current:
+ description: disable over current detect
+
+ over-current-active-low:
+ description: over current signal polarity is active low
+
+ over-current-active-high:
+ description: |
+ Over current signal polarity is active high. It's recommended to
+ specify the over current polarity.
+
+ power-active-high:
+ description: power signal polarity is active high
+
+ external-vbus-divider:
+ description: enables off-chip resistor divider for Vbus
+
+ samsung,picophy-pre-emp-curr-control:
+ description: |
+ HS Transmitter Pre-Emphasis Current Control. This signal controls
+ the amount of current sourced to the USB_OTG*_DP and USB_OTG*_DN
+ pins after a J-to-K or K-to-J transition. The range is from 0x0 to
+ 0x3, the default value is 0x1. Details can refer to TXPREEMPAMPTUNE0
+ bits of USBNC_n_PHY_CFG1.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0x0
+ maximum: 0x3
+
+ samsung,picophy-dc-vol-level-adjust:
+ description: |
+ HS DC Voltage Level Adjustment. Adjust the high-speed transmitter DC
+ level voltage. The range is from 0x0 to 0xf, the default value is
+ 0x3. Details can refer to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0x0
+ maximum: 0xf
+
+ usb-phy:
+ description: phandle for the PHY device. Use "phys" instead.
+ $ref: /schemas/types.yaml#/definitions/phandle
+ deprecated: true
+
+ fsl,usbphy:
+ description: phandle of usb phy that connects to the port. Use "phys" instead.
+ $ref: /schemas/types.yaml#/definitions/phandle
+ deprecated: true
+
+patternProperties:
+ "ethernet@[0-9a-f]$":
+ description: The hard wired USB devices
+ type: object
+ $ref: /schemas/net/microchip,lan95xx.yaml
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+allOf:
+ - $ref: usb-hcd.yaml#
+ - $ref: usb-drd.yaml#
+ - if:
+ properties:
+ mux-controls:
+ true
+ then:
+ properties:
+ mux-control-names:
+ const: usb_switch
+ - if:
+ properties:
+ phy_type:
+ const: hsic
+
+ required:
+ - phy_type
+ then:
+ properties:
+ pinctrl-names:
+ items:
+ - const: idle
+ - const: active
+ else:
+ properties:
+ pinctrl-names:
+ oneOf:
+ - items:
+ - const: default
+ - enum:
+ - host
+ - device
+ - items:
+ - const: default
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - chipidea,usb2
+ - lsi,zevio-usb
+ - nvidia,tegra20-udc
+ - nvidia,tegra30-udc
+ - nvidia,tegra114-udc
+ - nvidia,tegra124-udc
+ - qcom,ci-hdrc
+ - xlnx,zynq-usb-2.20a
+ then:
+ properties:
+ fsl,usbmisc: false
+ disable-over-current: false
+ over-current-active-low: false
+ over-current-active-high: false
+ power-active-high: false
+ external-vbus-divider: false
+ samsung,picophy-pre-emp-curr-control: false
+ samsung,picophy-dc-vol-level-adjust: false
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/berlin2.h>
+
+ usb@f7ed0000 {
+ compatible = "chipidea,usb2";
+ reg = <0xf7ed0000 0x10000>;
+ interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&chip CLKID_USB0>;
+ phys = <&usb_phy0>;
+ phy-names = "usb-phy";
+ vbus-supply = <®_usb0_vbus>;
+ itc-setting = <0x4>; /* 4 micro-frames */
+ /* Incremental burst of unspecified length */
+ ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>; /* 64 bytes */
+ rx-burst-size-dword = <0x10>;
+ extcon = <0>, <&usb_id>;
+ phy-clkgate-delay-us = <400>;
+ mux-controls = <&usb_switch>;
+ mux-control-names = "usb_switch";
+ };
+
+ # Example for HSIC:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/imx6qdl-clock.h>
+
+ usb@2184400 {
+ compatible = "fsl,imx6q-usb", "fsl,imx27-usb";
+ reg = <0x02184400 0x200>;
+ interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks IMX6QDL_CLK_USBOH3>;
+ fsl,usbphy = <&usbphynop1>;
+ fsl,usbmisc = <&usbmisc 2>;
+ phy_type = "hsic";
+ dr_mode = "host";
+ ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
+ pinctrl-names = "idle", "active";
+ pinctrl-0 = <&pinctrl_usbh2_idle>;
+ pinctrl-1 = <&pinctrl_usbh2_active>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ usbnet: ethernet@1 {
+ compatible = "usb424,9730";
+ reg = <1>;
+ };
+ };
+
+...
--
2.37.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format
2022-10-14 9:51 ` [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format Peng Fan (OSS)
@ 2022-10-14 14:28 ` Rob Herring
2022-10-17 5:52 ` Peng Fan
2022-10-15 14:58 ` Krzysztof Kozlowski
2022-12-22 15:56 ` Krzysztof Kozlowski
2 siblings, 1 reply; 24+ messages in thread
From: Rob Herring @ 2022-10-14 14:28 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: gregkh, krzysztof.kozlowski+dt, shawnguo, s.hauer, xu.yang_2,
kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
On Fri, Oct 14, 2022 at 05:51:46PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert the binding to DT schema format
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../devicetree/bindings/usb/ci-hdrc-usb2.txt | 158 --------
> .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 341 ++++++++++++++++++
> 2 files changed, 341 insertions(+), 158 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> new file mode 100644
> index 000000000000..ed03649f17a6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> @@ -0,0 +1,341 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/ci-hdrc-usb2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: USB2 ChipIdea USB controller for ci13xxx Binding
> +
> +maintainers:
> + - Xu Yang <xu.yang_2@nxp.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - chipidea,usb2
> + - lsi,zevio-usb
> + - nvidia,tegra20-udc
> + - nvidia,tegra30-udc
> + - nvidia,tegra114-udc
> + - nvidia,tegra124-udc
> + - qcom,ci-hdrc
> + - items:
> + - enum:
> + - fsl,imx23-usb
> + - fsl,imx25-usb
> + - fsl,imx28-usb
> + - fsl,imx6q-usb
> + - fsl,imx6sl-usb
> + - fsl,imx6sx-usb
> + - fsl,imx6ul-usb
> + - fsl,imx7d-usb
> + - const: fsl,imx27-usb
> + - items:
> + - const: fsl,imx7ulp-usb
> + - const: fsl,imx6ul-usb
> + - items:
> + - const: xlnx,zynq-usb-2.20a
> + - const: chipidea,usb2
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + dr_mode: true
> +
> + phy_type: true
> +
> + itc-setting:
> + description:
> + interrupt threshold control register control, the setting should be
> + aligned with ITC bits at register USBCMD.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + ahb-burst-config:
> + description:
> + it is vendor dependent, the required value should be aligned with
> + AHBBRST at SBUSCFG, the range is from 0x0 to 0x7. This property is
> + used to change AHB burst configuration, check the chipidea spec for
> + meaning of each value. If this property is not existed, it will use
> + the reset value.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0x0
> + maximum: 0x7
> +
> + tx-burst-size-dword:
> + description:
> + it is vendor dependent, the tx burst size in dword (4 bytes), This
> + register represents the maximum length of a the burst in 32-bit
> + words while moving data from system memory to the USB bus, the value
> + of this property will only take effect if property "ahb-burst-config"
> + is set to 0, if this property is missing the reset default of the
> + hardware implementation will be used.
> + $ref: /schemas/types.yaml#/definitions/uint32
Constraints? I assume 2^32 is not valid...
> +
> + rx-burst-size-dword:
> + description:
> + it is vendor dependent, the rx burst size in dword (4 bytes), This
> + register represents the maximum length of a the burst in 32-bit words
> + while moving data from the USB bus to system memory, the value of
> + this property will only take effect if property "ahb-burst-config"
> + is set to 0, if this property is missing the reset default of the
> + hardware implementation will be used.
> + $ref: /schemas/types.yaml#/definitions/uint32
Constraints?
> +
> + extcon:
> + description: |
> + Phandles to external connector devices. First phandle should point
> + to external connector, which provide "USB" cable events, the second
> + should point to external connector device, which provide "USB-HOST"
> + cable events. If one of the external connector devices is not
> + required, empty <0> phandle should be specified.
> +
> + phy-clkgate-delay-us:
> + description: |
> + The delay time (us) between putting the PHY into low power mode and
> + gating the PHY clock.
> +
> + non-zero-ttctrl-ttha:
> + description: |
> + After setting this property, the value of register ttctrl.ttha
> + will be 0x7f; if not, the value will be 0x0, this is the default
> + value. It needs to be very carefully for setting this property, it
> + is recommended that consult with your IC engineer before setting
> + this value. On the most of chipidea platforms, the "usage_tt" flag
> + at RTL is 0, so this property only affects siTD.
> +
> + If this property is not set, the max packet size is 1023 bytes, and
> + if the total of packet size for pervious transactions are more than
> + 256 bytes, it can't accept any transactions within this frame. The
> + use case is single transaction, but higher frame rate.
> +
> + If this property is set, the max packet size is 188 bytes, it can
> + handle more transactions than above case, it can accept transactions
> + until it considers the left room size within frame is less than 188
> + bytes, software needs to make sure it does not send more than 90%
> + maximum_periodic_data_per_frame. The use case is multiple
> + transactions, but less frame rate.
> +
> + mux-controls:
> + description: |
> + The mux control for toggling host/device output of this controller.
> + It's expected that a mux state of 0 indicates device mode and a mux
> + state of 1 indicates host mode.
maxItems: 1
> +
> + mux-control-names:
> + const: usb_switch
> +
> + pinctrl-names:
> + description: |
> + Names for optional pin modes in "default", "host", "device".
> + In case of HSIC-mode, "idle" and "active" pin modes are mandatory.
> + In this case, the "idle" state needs to pull down the data and
> + strobe pin and the "active" state needs to pull up the strobe pin.
The names need to be constraints, not freeform text.
> +
> + pinctrl-0:
> + maxItems: 1
> +
> + pinctrl-1:
> + maxItems: 1
> +
> + phys:
> + maxItems: 1
> +
> + phy-names:
> + const: usb-phy
> +
> + vbus-supply:
> + description: reference to the VBUS regulator.
> +
> + fsl,usbmisc:
> + description:
> + Phandler of non-core register device, with one argument that
> + indicate usb controller index
> + $ref: /schemas/types.yaml#/definitions/phandle-array
items:
- items:
- description: phandle to usbmisc node
- description: index of usb controller
> +
> + disable-over-current:
> + description: disable over current detect
type?
> +
> + over-current-active-low:
> + description: over current signal polarity is active low
type?
> +
> + over-current-active-high:
> + description: |
> + Over current signal polarity is active high. It's recommended to
> + specify the over current polarity.
type?
> +
> + power-active-high:
> + description: power signal polarity is active high
type?
> +
> + external-vbus-divider:
> + description: enables off-chip resistor divider for Vbus
type?
> +
> + samsung,picophy-pre-emp-curr-control:
> + description: |
> + HS Transmitter Pre-Emphasis Current Control. This signal controls
> + the amount of current sourced to the USB_OTG*_DP and USB_OTG*_DN
> + pins after a J-to-K or K-to-J transition. The range is from 0x0 to
> + 0x3, the default value is 0x1. Details can refer to TXPREEMPAMPTUNE0
> + bits of USBNC_n_PHY_CFG1.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0x0
> + maximum: 0x3
> +
> + samsung,picophy-dc-vol-level-adjust:
> + description: |
> + HS DC Voltage Level Adjustment. Adjust the high-speed transmitter DC
> + level voltage. The range is from 0x0 to 0xf, the default value is
> + 0x3. Details can refer to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0x0
> + maximum: 0xf
> +
> + usb-phy:
> + description: phandle for the PHY device. Use "phys" instead.
> + $ref: /schemas/types.yaml#/definitions/phandle
> + deprecated: true
> +
> + fsl,usbphy:
> + description: phandle of usb phy that connects to the port. Use "phys" instead.
> + $ref: /schemas/types.yaml#/definitions/phandle
> + deprecated: true
> +
> +patternProperties:
> + "ethernet@[0-9a-f]$":
This is board specific and shouldn't be part of the schema. But you do
need to define child nodes with a reference to common usb schemas.
> + description: The hard wired USB devices
> + type: object
> + $ref: /schemas/net/microchip,lan95xx.yaml
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +allOf:
> + - $ref: usb-hcd.yaml#
> + - $ref: usb-drd.yaml#
> + - if:
> + properties:
> + mux-controls:
> + true
> + then:
> + properties:
> + mux-control-names:
> + const: usb_switch
> + - if:
> + properties:
> + phy_type:
> + const: hsic
> +
> + required:
> + - phy_type
> + then:
> + properties:
> + pinctrl-names:
> + items:
> + - const: idle
> + - const: active
> + else:
> + properties:
> + pinctrl-names:
> + oneOf:
> + - items:
> + - const: default
> + - enum:
> + - host
> + - device
> + - items:
> + - const: default
'minItems: 1' in the 1st (oneOf) entry and drop the 2nd entry.
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - chipidea,usb2
> + - lsi,zevio-usb
> + - nvidia,tegra20-udc
> + - nvidia,tegra30-udc
> + - nvidia,tegra114-udc
> + - nvidia,tegra124-udc
> + - qcom,ci-hdrc
> + - xlnx,zynq-usb-2.20a
> + then:
> + properties:
> + fsl,usbmisc: false
> + disable-over-current: false
> + over-current-active-low: false
> + over-current-active-high: false
> + power-active-high: false
> + external-vbus-divider: false
> + samsung,picophy-pre-emp-curr-control: false
> + samsung,picophy-dc-vol-level-adjust: false
> +
> +additionalProperties: false
unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/berlin2.h>
> +
> + usb@f7ed0000 {
> + compatible = "chipidea,usb2";
> + reg = <0xf7ed0000 0x10000>;
> + interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&chip CLKID_USB0>;
> + phys = <&usb_phy0>;
> + phy-names = "usb-phy";
> + vbus-supply = <®_usb0_vbus>;
> + itc-setting = <0x4>; /* 4 micro-frames */
> + /* Incremental burst of unspecified length */
> + ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>; /* 64 bytes */
> + rx-burst-size-dword = <0x10>;
> + extcon = <0>, <&usb_id>;
> + phy-clkgate-delay-us = <400>;
> + mux-controls = <&usb_switch>;
> + mux-control-names = "usb_switch";
> + };
> +
> + # Example for HSIC:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/imx6qdl-clock.h>
> +
> + usb@2184400 {
> + compatible = "fsl,imx6q-usb", "fsl,imx27-usb";
> + reg = <0x02184400 0x200>;
> + interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6QDL_CLK_USBOH3>;
> + fsl,usbphy = <&usbphynop1>;
> + fsl,usbmisc = <&usbmisc 2>;
> + phy_type = "hsic";
> + dr_mode = "host";
> + ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> + pinctrl-names = "idle", "active";
> + pinctrl-0 = <&pinctrl_usbh2_idle>;
> + pinctrl-1 = <&pinctrl_usbh2_active>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + usbnet: ethernet@1 {
> + compatible = "usb424,9730";
> + reg = <1>;
> + };
> + };
> +
> +...
> --
> 2.37.1
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread* RE: [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format
2022-10-14 14:28 ` Rob Herring
@ 2022-10-17 5:52 ` Peng Fan
0 siblings, 0 replies; 24+ messages in thread
From: Peng Fan @ 2022-10-17 5:52 UTC (permalink / raw)
To: Rob Herring, Peng Fan (OSS)
Cc: gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de, Xu Yang,
kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jun Li
Hi Rob,
> Subject: Re: [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT
> schema format
>
> On Fri, Oct 14, 2022 at 05:51:46PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Convert the binding to DT schema format
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > .../devicetree/bindings/usb/ci-hdrc-usb2.txt | 158 --------
> > .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 341 ++++++++++++++++++
> > 2 files changed, 341 insertions(+), 158 deletions(-) delete mode
> > 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> > create mode 100644
> > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
>
> > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> > b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> > new file mode 100644
> > index 000000000000..ed03649f17a6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> > @@ -0,0 +1,341 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > +cetree.org%2Fschemas%2Fusb%2Fci-hdrc-
> usb2.yaml%23&data=05%7C01%7C
> >
> +peng.fan%40nxp.com%7Cc82aff1e7786408bdfb908daadf05fba%7C686ea1
> d3bc2b4
> >
> +c6fa92cd99c5c301635%7C0%7C0%7C638013545157576176%7CUnknown%
> 7CTWFpbGZs
> >
> +b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3
> >
> +D%7C3000%7C%7C%7C&sdata=WCoRU5%2FlPpdKF984bqAmU7WPU8
> XbDvBZoVyJ6K3
> > +nggY%3D&reserved=0
> > +$schema:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > +cetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&data=05%7C01%7Cpeng.fan%
> >
> +40nxp.com%7Cc82aff1e7786408bdfb908daadf05fba%7C686ea1d3bc2b4c6
> fa92cd9
> >
> +9c5c301635%7C0%7C0%7C638013545157576176%7CUnknown%7CTWFpb
> GZsb3d8eyJWI
> >
> +joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> C3000%
> >
> +7C%7C%7C&sdata=l6g5TrxpwRjZqUgRmqpAbhCIO4%2BLRp0y1IFV5SS
> nkx0%3D&a
> > +mp;reserved=0
> > +
> > +title: USB2 ChipIdea USB controller for ci13xxx Binding
> > +
> > +maintainers:
> > + - Xu Yang <xu.yang_2@nxp.com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - chipidea,usb2
> > + - lsi,zevio-usb
> > + - nvidia,tegra20-udc
> > + - nvidia,tegra30-udc
> > + - nvidia,tegra114-udc
> > + - nvidia,tegra124-udc
> > + - qcom,ci-hdrc
> > + - items:
> > + - enum:
> > + - fsl,imx23-usb
> > + - fsl,imx25-usb
> > + - fsl,imx28-usb
> > + - fsl,imx6q-usb
> > + - fsl,imx6sl-usb
> > + - fsl,imx6sx-usb
> > + - fsl,imx6ul-usb
> > + - fsl,imx7d-usb
> > + - const: fsl,imx27-usb
> > + - items:
> > + - const: fsl,imx7ulp-usb
> > + - const: fsl,imx6ul-usb
> > + - items:
> > + - const: xlnx,zynq-usb-2.20a
> > + - const: chipidea,usb2
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + minItems: 1
> > + maxItems: 2
> > +
> > + dr_mode: true
> > +
> > + phy_type: true
> > +
> > + itc-setting:
> > + description:
> > + interrupt threshold control register control, the setting should be
> > + aligned with ITC bits at register USBCMD.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + ahb-burst-config:
> > + description:
> > + it is vendor dependent, the required value should be aligned with
> > + AHBBRST at SBUSCFG, the range is from 0x0 to 0x7. This property is
> > + used to change AHB burst configuration, check the chipidea spec for
> > + meaning of each value. If this property is not existed, it will use
> > + the reset value.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0x0
> > + maximum: 0x7
> > +
> > + tx-burst-size-dword:
> > + description:
> > + it is vendor dependent, the tx burst size in dword (4 bytes), This
> > + register represents the maximum length of a the burst in 32-bit
> > + words while moving data from system memory to the USB bus, the
> value
> > + of this property will only take effect if property "ahb-burst-config"
> > + is set to 0, if this property is missing the reset default of the
> > + hardware implementation will be used.
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> Constraints? I assume 2^32 is not valid...
Actually I am not sure, per txt binding, it is vendor dependent.
i.MX has value 0x8 or 0x10, but I am not other vendors.
>
> > +
> > + rx-burst-size-dword:
> > + description:
> > + it is vendor dependent, the rx burst size in dword (4 bytes), This
> > + register represents the maximum length of a the burst in 32-bit words
> > + while moving data from the USB bus to system memory, the value of
> > + this property will only take effect if property "ahb-burst-config"
> > + is set to 0, if this property is missing the reset default of the
> > + hardware implementation will be used.
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> Constraints?
Vendor dependent, I am not sure.
>
> > +
> > + extcon:
> > + description: |
> > + Phandles to external connector devices. First phandle should point
> > + to external connector, which provide "USB" cable events, the second
> > + should point to external connector device, which provide "USB-HOST"
> > + cable events. If one of the external connector devices is not
> > + required, empty <0> phandle should be specified.
> > +
> > + phy-clkgate-delay-us:
> > + description: |
> > + The delay time (us) between putting the PHY into low power mode
> and
> > + gating the PHY clock.
> > +
> > + non-zero-ttctrl-ttha:
> > + description: |
> > + After setting this property, the value of register ttctrl.ttha
> > + will be 0x7f; if not, the value will be 0x0, this is the default
> > + value. It needs to be very carefully for setting this property, it
> > + is recommended that consult with your IC engineer before setting
> > + this value. On the most of chipidea platforms, the "usage_tt" flag
> > + at RTL is 0, so this property only affects siTD.
> > +
> > + If this property is not set, the max packet size is 1023 bytes, and
> > + if the total of packet size for pervious transactions are more than
> > + 256 bytes, it can't accept any transactions within this frame. The
> > + use case is single transaction, but higher frame rate.
> > +
> > + If this property is set, the max packet size is 188 bytes, it can
> > + handle more transactions than above case, it can accept transactions
> > + until it considers the left room size within frame is less than 188
> > + bytes, software needs to make sure it does not send more than 90%
> > + maximum_periodic_data_per_frame. The use case is multiple
> > + transactions, but less frame rate.
> > +
> > + mux-controls:
> > + description: |
> > + The mux control for toggling host/device output of this controller.
> > + It's expected that a mux state of 0 indicates device mode and a mux
> > + state of 1 indicates host mode.
>
> maxItems: 1
Fix in v3.
>
> > +
> > + mux-control-names:
> > + const: usb_switch
> > +
> > + pinctrl-names:
> > + description: |
> > + Names for optional pin modes in "default", "host", "device".
> > + In case of HSIC-mode, "idle" and "active" pin modes are mandatory.
> > + In this case, the "idle" state needs to pull down the data and
> > + strobe pin and the "active" state needs to pull up the strobe pin.
>
> The names need to be constraints, not freeform text.
I am not sure, I have added constraints in allOf section.
>
> > +
> > + pinctrl-0:
> > + maxItems: 1
> > +
> > + pinctrl-1:
> > + maxItems: 1
> > +
> > + phys:
> > + maxItems: 1
> > +
> > + phy-names:
> > + const: usb-phy
> > +
> > + vbus-supply:
> > + description: reference to the VBUS regulator.
> > +
> > + fsl,usbmisc:
> > + description:
> > + Phandler of non-core register device, with one argument that
> > + indicate usb controller index
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
>
> items:
> - items:
> - description: phandle to usbmisc node
> - description: index of usb controller
>
> > +
> > + disable-over-current:
> > + description: disable over current detect
>
> type?
It is a Boolean type. I should add "type: boolean"
>
> > +
> > + over-current-active-low:
> > + description: over current signal polarity is active low
>
> type?
type: boolean
>
> > +
> > + over-current-active-high:
> > + description: |
> > + Over current signal polarity is active high. It's recommended to
> > + specify the over current polarity.
>
> type?
type: boolean
>
> > +
> > + power-active-high:
> > + description: power signal polarity is active high
>
> type?
type: boolean
>
> > +
> > + external-vbus-divider:
> > + description: enables off-chip resistor divider for Vbus
>
> type?
type: boolean
>
> > +
> > + samsung,picophy-pre-emp-curr-control:
> > + description: |
> > + HS Transmitter Pre-Emphasis Current Control. This signal controls
> > + the amount of current sourced to the USB_OTG*_DP and
> USB_OTG*_DN
> > + pins after a J-to-K or K-to-J transition. The range is from 0x0 to
> > + 0x3, the default value is 0x1. Details can refer to
> TXPREEMPAMPTUNE0
> > + bits of USBNC_n_PHY_CFG1.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0x0
> > + maximum: 0x3
> > +
> > + samsung,picophy-dc-vol-level-adjust:
> > + description: |
> > + HS DC Voltage Level Adjustment. Adjust the high-speed transmitter
> DC
> > + level voltage. The range is from 0x0 to 0xf, the default value is
> > + 0x3. Details can refer to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0x0
> > + maximum: 0xf
> > +
> > + usb-phy:
> > + description: phandle for the PHY device. Use "phys" instead.
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + deprecated: true
> > +
> > + fsl,usbphy:
> > + description: phandle of usb phy that connects to the port. Use "phys"
> instead.
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + deprecated: true
> > +
> > +patternProperties:
> > + "ethernet@[0-9a-f]$":
>
> This is board specific and shouldn't be part of the schema. But you do need
> to define child nodes with a reference to common usb schemas.
The txt binding has the child node
usbnet: ethernet@1 {
compatible = "usb424,9730";
reg = <1>;
};
I am not sure how to support it. If I not add such patterProperties, there will
be dt binding check error. The child node is a usb ethernet, I think common
usb schemas not has that.
If you have a simple example, I could follow that.
>
> > + description: The hard wired USB devices
> > + type: object
> > + $ref: /schemas/net/microchip,lan95xx.yaml
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > +
> > +allOf:
> > + - $ref: usb-hcd.yaml#
> > + - $ref: usb-drd.yaml#
> > + - if:
> > + properties:
> > + mux-controls:
> > + true
> > + then:
> > + properties:
> > + mux-control-names:
> > + const: usb_switch
> > + - if:
> > + properties:
> > + phy_type:
> > + const: hsic
> > +
> > + required:
> > + - phy_type
> > + then:
> > + properties:
> > + pinctrl-names:
> > + items:
> > + - const: idle
> > + - const: active
> > + else:
> > + properties:
> > + pinctrl-names:
> > + oneOf:
> > + - items:
> > + - const: default
> > + - enum:
> > + - host
> > + - device
> > + - items:
> > + - const: default
>
> 'minItems: 1' in the 1st (oneOf) entry and drop the 2nd entry.
ok
>
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - chipidea,usb2
> > + - lsi,zevio-usb
> > + - nvidia,tegra20-udc
> > + - nvidia,tegra30-udc
> > + - nvidia,tegra114-udc
> > + - nvidia,tegra124-udc
> > + - qcom,ci-hdrc
> > + - xlnx,zynq-usb-2.20a
> > + then:
> > + properties:
> > + fsl,usbmisc: false
> > + disable-over-current: false
> > + over-current-active-low: false
> > + over-current-active-high: false
> > + power-active-high: false
> > + external-vbus-divider: false
> > + samsung,picophy-pre-emp-curr-control: false
> > + samsung,picophy-dc-vol-level-adjust: false
> > +
> > +additionalProperties: false
>
> unevaluatedProperties: false
Will add this.
Thanks,
Peng.
>
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/berlin2.h>
> > +
> > + usb@f7ed0000 {
> > + compatible = "chipidea,usb2";
> > + reg = <0xf7ed0000 0x10000>;
> > + interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&chip CLKID_USB0>;
> > + phys = <&usb_phy0>;
> > + phy-names = "usb-phy";
> > + vbus-supply = <®_usb0_vbus>;
> > + itc-setting = <0x4>; /* 4 micro-frames */
> > + /* Incremental burst of unspecified length */
> > + ahb-burst-config = <0x0>;
> > + tx-burst-size-dword = <0x10>; /* 64 bytes */
> > + rx-burst-size-dword = <0x10>;
> > + extcon = <0>, <&usb_id>;
> > + phy-clkgate-delay-us = <400>;
> > + mux-controls = <&usb_switch>;
> > + mux-control-names = "usb_switch";
> > + };
> > +
> > + # Example for HSIC:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/imx6qdl-clock.h>
> > +
> > + usb@2184400 {
> > + compatible = "fsl,imx6q-usb", "fsl,imx27-usb";
> > + reg = <0x02184400 0x200>;
> > + interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clks IMX6QDL_CLK_USBOH3>;
> > + fsl,usbphy = <&usbphynop1>;
> > + fsl,usbmisc = <&usbmisc 2>;
> > + phy_type = "hsic";
> > + dr_mode = "host";
> > + ahb-burst-config = <0x0>;
> > + tx-burst-size-dword = <0x10>;
> > + rx-burst-size-dword = <0x10>;
> > + pinctrl-names = "idle", "active";
> > + pinctrl-0 = <&pinctrl_usbh2_idle>;
> > + pinctrl-1 = <&pinctrl_usbh2_active>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + usbnet: ethernet@1 {
> > + compatible = "usb424,9730";
> > + reg = <1>;
> > + };
> > + };
> > +
> > +...
> > --
> > 2.37.1
> >
> >
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format
2022-10-14 9:51 ` [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format Peng Fan (OSS)
2022-10-14 14:28 ` Rob Herring
@ 2022-10-15 14:58 ` Krzysztof Kozlowski
2022-10-17 5:55 ` Peng Fan
2022-12-22 15:56 ` Krzysztof Kozlowski
2 siblings, 1 reply; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-15 14:58 UTC (permalink / raw)
To: Peng Fan (OSS), gregkh, robh+dt, krzysztof.kozlowski+dt, shawnguo,
s.hauer, xu.yang_2
Cc: kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
On 14/10/2022 05:51, Peng Fan (OSS) wrote:
> +
> + vbus-supply:
> + description: reference to the VBUS regulator.
> +
> + fsl,usbmisc:
> + description:
> + Phandler of non-core register device, with one argument that
> + indicate usb controller index
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> +
> + disable-over-current:
> + description: disable over current detect
> +
> + over-current-active-low:
> + description: over current signal polarity is active low
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
> +
> + over-current-active-high:
> + description: |
> + Over current signal polarity is active high. It's recommended to
> + specify the over current polarity.
> +
> + power-active-high:
> + description: power signal polarity is active high
> +
> + external-vbus-divider:
> + description: enables off-chip resistor divider for Vbus
> +
> + samsung,picophy-pre-emp-curr-control:
> + description: |
> + HS Transmitter Pre-Emphasis Current Control. This signal controls
> + the amount of current sourced to the USB_OTG*_DP and USB_OTG*_DN
> + pins after a J-to-K or K-to-J transition. The range is from 0x0 to
> + 0x3, the default value is 0x1. Details can refer to TXPREEMPAMPTUNE0
> + bits of USBNC_n_PHY_CFG1.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0x0
> + maximum: 0x3
> +
> + samsung,picophy-dc-vol-level-adjust:
> + description: |
> + HS DC Voltage Level Adjustment. Adjust the high-speed transmitter DC
> + level voltage. The range is from 0x0 to 0xf, the default value is
> + 0x3. Details can refer to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0x0
> + maximum: 0xf
> +
> + usb-phy:
> + description: phandle for the PHY device. Use "phys" instead.
> + $ref: /schemas/types.yaml#/definitions/phandle
> + deprecated: true
> +
> + fsl,usbphy:
> + description: phandle of usb phy that connects to the port. Use "phys" instead.
> + $ref: /schemas/types.yaml#/definitions/phandle
> + deprecated: true
> +
> +patternProperties:
> + "ethernet@[0-9a-f]$":
> + description: The hard wired USB devices
> + type: object
> + $ref: /schemas/net/microchip,lan95xx.yaml
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +allOf:
> + - $ref: usb-hcd.yaml#
> + - $ref: usb-drd.yaml#
> + - if:
> + properties:
> + mux-controls:
> + true
> + then:
> + properties:
> + mux-control-names:
> + const: usb_switch
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Additionally: Blank line
> + - if:
> + properties:
> + phy_type:
> + const: hsic
> +
> + required:
> + - phy_type> + then:
> + properties:
> + pinctrl-names:
> + items:
> + - const: idle
> + - const: active
> + else:
> + properties:
> + pinctrl-names:
> + oneOf:
> + - items:
> + - const: default
> + - enum:
> + - host
> + - device
> + - items:
> + - const: default
No, just minItems: 1
Additionally: blank line
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - chipidea,usb2
> + - lsi,zevio-usb
> + - nvidia,tegra20-udc
> + - nvidia,tegra30-udc
> + - nvidia,tegra114-udc
> + - nvidia,tegra124-udc
> + - qcom,ci-hdrc
> + - xlnx,zynq-usb-2.20a
> + then:
> + properties:
> + fsl,usbmisc: false
> + disable-over-current: false
> + over-current-active-low: false
> + over-current-active-high: false
> + power-active-high: false
> + external-vbus-divider: false
> + samsung,picophy-pre-emp-curr-control: false
> + samsung,picophy-dc-vol-level-adjust: false
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format
2022-10-15 14:58 ` Krzysztof Kozlowski
@ 2022-10-17 5:55 ` Peng Fan
0 siblings, 0 replies; 24+ messages in thread
From: Peng Fan @ 2022-10-17 5:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Peng Fan (OSS), gregkh@linuxfoundation.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de, Xu Yang
Cc: kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jun Li
> Subject: Re: [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT
> schema format
>
> On 14/10/2022 05:51, Peng Fan (OSS) wrote:
>
>
> > +
> > + vbus-supply:
> > + description: reference to the VBUS regulator.
> > +
> > + fsl,usbmisc:
> > + description:
> > + Phandler of non-core register device, with one argument that
> > + indicate usb controller index
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > + disable-over-current:
> > + description: disable over current detect
> > +
> > + over-current-active-low:
> > + description: over current signal polarity is active low
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
I thought no need to add type for boolean property. Compared V1, V2 has
more changes. As I wrote in cover-letter, I may miss some comments, sorry
for that. I will go back and re-check the V1 comments.
Thanks,
Peng.
>
> Thank you.
>
> > +
> > + over-current-active-high:
> > + description: |
> > + Over current signal polarity is active high. It's recommended to
> > + specify the over current polarity.
> > +
> > + power-active-high:
> > + description: power signal polarity is active high
> > +
> > + external-vbus-divider:
> > + description: enables off-chip resistor divider for Vbus
> > +
> > + samsung,picophy-pre-emp-curr-control:
> > + description: |
> > + HS Transmitter Pre-Emphasis Current Control. This signal controls
> > + the amount of current sourced to the USB_OTG*_DP and
> USB_OTG*_DN
> > + pins after a J-to-K or K-to-J transition. The range is from 0x0 to
> > + 0x3, the default value is 0x1. Details can refer to
> TXPREEMPAMPTUNE0
> > + bits of USBNC_n_PHY_CFG1.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0x0
> > + maximum: 0x3
> > +
> > + samsung,picophy-dc-vol-level-adjust:
> > + description: |
> > + HS DC Voltage Level Adjustment. Adjust the high-speed transmitter
> DC
> > + level voltage. The range is from 0x0 to 0xf, the default value is
> > + 0x3. Details can refer to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0x0
> > + maximum: 0xf
> > +
> > + usb-phy:
> > + description: phandle for the PHY device. Use "phys" instead.
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + deprecated: true
> > +
> > + fsl,usbphy:
> > + description: phandle of usb phy that connects to the port. Use "phys"
> instead.
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + deprecated: true
> > +
> > +patternProperties:
> > + "ethernet@[0-9a-f]$":
> > + description: The hard wired USB devices
> > + type: object
> > + $ref: /schemas/net/microchip,lan95xx.yaml
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > +
> > +allOf:
> > + - $ref: usb-hcd.yaml#
> > + - $ref: usb-drd.yaml#
> > + - if:
> > + properties:
> > + mux-controls:
> > + true
> > + then:
> > + properties:
> > + mux-control-names:
> > + const: usb_switch
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
>
> Additionally: Blank line
>
> > + - if:
> > + properties:
> > + phy_type:
> > + const: hsic
> > +
> > + required:
> > + - phy_type> + then:
> > + properties:
> > + pinctrl-names:
> > + items:
> > + - const: idle
> > + - const: active
> > + else:
> > + properties:
> > + pinctrl-names:
> > + oneOf:
> > + - items:
> > + - const: default
> > + - enum:
> > + - host
> > + - device
> > + - items:
> > + - const: default
>
> No, just minItems: 1
>
> Additionally: blank line
>
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - chipidea,usb2
> > + - lsi,zevio-usb
> > + - nvidia,tegra20-udc
> > + - nvidia,tegra30-udc
> > + - nvidia,tegra114-udc
> > + - nvidia,tegra124-udc
> > + - qcom,ci-hdrc
> > + - xlnx,zynq-usb-2.20a
> > + then:
> > + properties:
> > + fsl,usbmisc: false
> > + disable-over-current: false
> > + over-current-active-low: false
> > + over-current-active-high: false
> > + power-active-high: false
> > + external-vbus-divider: false
> > + samsung,picophy-pre-emp-curr-control: false
> > + samsung,picophy-dc-vol-level-adjust: false
> > +
>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format
2022-10-14 9:51 ` [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format Peng Fan (OSS)
2022-10-14 14:28 ` Rob Herring
2022-10-15 14:58 ` Krzysztof Kozlowski
@ 2022-12-22 15:56 ` Krzysztof Kozlowski
2 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-22 15:56 UTC (permalink / raw)
To: Peng Fan (OSS), gregkh, robh+dt, krzysztof.kozlowski+dt, shawnguo,
s.hauer, xu.yang_2
Cc: kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
On 14/10/2022 11:51, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert the binding to DT schema format
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
(...)
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> new file mode 100644
> index 000000000000..ed03649f17a6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> @@ -0,0 +1,341 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/ci-hdrc-usb2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: USB2 ChipIdea USB controller for ci13xxx Binding
> +
> +maintainers:
> + - Xu Yang <xu.yang_2@nxp.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - chipidea,usb2
> + - lsi,zevio-usb
> + - nvidia,tegra20-udc
> + - nvidia,tegra30-udc
> + - nvidia,tegra114-udc
> + - nvidia,tegra124-udc
> + - qcom,ci-hdrc
Except other comments, this conversion does not match existing Qualcomm
driver and Qualcomm DTS. You miss the "ulpi" node.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH V2 5/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX53/6SLL/UL compatible
2022-10-14 9:51 [PATCH V2 0/6] dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml Peng Fan (OSS)
` (3 preceding siblings ...)
2022-10-14 9:51 ` [PATCH V2 4/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format Peng Fan (OSS)
@ 2022-10-14 9:51 ` Peng Fan (OSS)
2022-10-14 14:53 ` Rob Herring
2022-10-14 9:51 ` [PATCH V2 6/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX8DXL/M[M,N] support Peng Fan (OSS)
5 siblings, 1 reply; 24+ messages in thread
From: Peng Fan (OSS) @ 2022-10-14 9:51 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer,
xu.yang_2
Cc: kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Add i.MX53, i.MX6SLL, i.MX6UL compatible
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
index ed03649f17a6..29ea427861c4 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
@@ -25,11 +25,19 @@ properties:
- fsl,imx23-usb
- fsl,imx25-usb
- fsl,imx28-usb
+ - fsl,imx50-usb
+ - fsl,imx51-usb
+ - fsl,imx53-usb
- fsl,imx6q-usb
- fsl,imx6sl-usb
- fsl,imx6sx-usb
- fsl,imx6ul-usb
- fsl,imx7d-usb
+ - fsl,vf610-usb
+ - const: fsl,imx27-usb
+ - items:
+ - const: fsl,imx6sll-usb
+ - const: fsl,imx6ul-usb
- const: fsl,imx27-usb
- items:
- const: fsl,imx7ulp-usb
--
2.37.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH V2 5/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX53/6SLL/UL compatible
2022-10-14 9:51 ` [PATCH V2 5/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX53/6SLL/UL compatible Peng Fan (OSS)
@ 2022-10-14 14:53 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-10-14 14:53 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: krzysztof.kozlowski+dt, shawnguo, linux-imx, robh+dt, s.hauer,
linux-kernel, festevam, kernel, gregkh, xu.yang_2,
linux-arm-kernel, Peng Fan, linux-usb, jun.li, devicetree
On Fri, 14 Oct 2022 17:51:47 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add i.MX53, i.MX6SLL, i.MX6UL compatible
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH V2 6/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX8DXL/M[M,N] support
2022-10-14 9:51 [PATCH V2 0/6] dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml Peng Fan (OSS)
` (4 preceding siblings ...)
2022-10-14 9:51 ` [PATCH V2 5/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX53/6SLL/UL compatible Peng Fan (OSS)
@ 2022-10-14 9:51 ` Peng Fan (OSS)
2022-10-14 13:33 ` Rob Herring
5 siblings, 1 reply; 24+ messages in thread
From: Peng Fan (OSS) @ 2022-10-14 9:51 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer,
xu.yang_2
Cc: kernel, festevam, linux-imx, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, jun.li, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Add i.MX8MM/N compatible strings, which are compatible with i.MX7D.
Add i.MX8DXL compatible string, which is compatible with i.MX7ULP.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
index 29ea427861c4..34cdb1be3b32 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
@@ -35,6 +35,14 @@ properties:
- fsl,imx7d-usb
- fsl,vf610-usb
- const: fsl,imx27-usb
+ - items:
+ - const: fsl,imx8dxl-usb
+ - const: fsl,imx7ulp-usb
+ - items:
+ - enum:
+ - fsl,imx8mm-usb
+ - fsl,imx8mn-usb
+ - const: fsl,imx7d-usb
- items:
- const: fsl,imx6sll-usb
- const: fsl,imx6ul-usb
--
2.37.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH V2 6/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX8DXL/M[M,N] support
2022-10-14 9:51 ` [PATCH V2 6/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX8DXL/M[M,N] support Peng Fan (OSS)
@ 2022-10-14 13:33 ` Rob Herring
2022-10-14 13:54 ` Rob Herring
0 siblings, 1 reply; 24+ messages in thread
From: Rob Herring @ 2022-10-14 13:33 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: krzysztof.kozlowski+dt, linux-usb, linux-arm-kernel, xu.yang_2,
kernel, linux-imx, festevam, linux-kernel, Peng Fan, devicetree,
s.hauer, jun.li, robh+dt, gregkh, shawnguo
On Fri, 14 Oct 2022 17:51:48 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add i.MX8MM/N compatible strings, which are compatible with i.MX7D.
> Add i.MX8DXL compatible string, which is compatible with i.MX7ULP.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
usb@10024000: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx27-apf27dev.dtb
arch/arm/boot/dts/imx27-apf27.dtb
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
arch/arm/boot/dts/imx27-pdk.dtb
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
usb@10024000: clocks: [[1, 75], [1, 62], [1, 15]] is too long
arch/arm/boot/dts/imx27-apf27dev.dtb
arch/arm/boot/dts/imx27-apf27.dtb
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
arch/arm/boot/dts/imx27-pdk.dtb
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
usb@10024000: compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/imx27-apf27dev.dtb
arch/arm/boot/dts/imx27-apf27.dtb
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
arch/arm/boot/dts/imx27-pdk.dtb
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
usb@10024200: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx27-apf27dev.dtb
arch/arm/boot/dts/imx27-apf27.dtb
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
arch/arm/boot/dts/imx27-pdk.dtb
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
usb@10024200: clocks: [[1, 75], [1, 62], [1, 15]] is too long
arch/arm/boot/dts/imx27-apf27dev.dtb
arch/arm/boot/dts/imx27-apf27.dtb
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
arch/arm/boot/dts/imx27-pdk.dtb
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
usb@10024200: compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/imx27-apf27dev.dtb
arch/arm/boot/dts/imx27-apf27.dtb
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
arch/arm/boot/dts/imx27-pdk.dtb
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
usb@10024400: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx27-apf27dev.dtb
arch/arm/boot/dts/imx27-apf27.dtb
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
arch/arm/boot/dts/imx27-pdk.dtb
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
usb@10024400: clocks: [[1, 75], [1, 62], [1, 15]] is too long
arch/arm/boot/dts/imx27-apf27dev.dtb
arch/arm/boot/dts/imx27-apf27.dtb
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
arch/arm/boot/dts/imx27-pdk.dtb
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
usb@10024400: compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/imx27-apf27dev.dtb
arch/arm/boot/dts/imx27-apf27.dtb
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
arch/arm/boot/dts/imx27-pdk.dtb
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
usb@12500000: reg: [[307232768, 512], [307233280, 512]] is too long
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
usb@12500000: '#reset-cells', 'clock-names', 'reset-names', 'resets', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
usb@12520000: reg: [[307363840, 512], [307364352, 512]] is too long
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
usb@12520000: '#reset-cells', 'clock-names', 'reset-names', 'resets', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
usb@12530000: reg: [[307429376, 512], [307429888, 512]] is too long
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
usb@12530000: '#reset-cells', 'clock-names', 'reset-names', 'resets', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
usb@2184000: 'adp-disable', 'fsl,anatop', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx6sll-evk.dtb
arch/arm/boot/dts/imx6sll-kobo-clarahd.dtb
arch/arm/boot/dts/imx6sll-kobo-librah2o.dtb
arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
arch/arm/boot/dts/imx6ull-colibri-aster.dtb
arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
arch/arm/boot/dts/imx6ull-colibri-iris.dtb
arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dtb
usb@2184000: 'adp-disable', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx6dl-mba6a.dtb
arch/arm/boot/dts/imx6dl-mba6b.dtb
arch/arm/boot/dts/imx6dl-yapp4-draco.dtb
arch/arm/boot/dts/imx6dl-yapp4-hydra.dtb
arch/arm/boot/dts/imx6dl-yapp4-orion.dtb
arch/arm/boot/dts/imx6dl-yapp4-ursa.dtb
arch/arm/boot/dts/imx6q-bosch-acc.dtb
arch/arm/boot/dts/imx6q-mba6a.dtb
arch/arm/boot/dts/imx6q-mba6b.dtb
arch/arm/boot/dts/imx6q-pistachio.dtb
arch/arm/boot/dts/imx6qp-mba6b.dtb
arch/arm/boot/dts/imx6qp-yapp4-crux-plus.dtb
arch/arm/boot/dts/imx6q-var-dt6customboard.dtb
arch/arm/boot/dts/imx6q-yapp4-crux.dtb
arch/arm/boot/dts/imx6sl-tolino-shine2hd.dtb
arch/arm/boot/dts/imx6sl-tolino-shine3.dtb
arch/arm/boot/dts/imx6sl-tolino-vision5.dtb
usb@2184000: 'fsl,anatop' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx6sx-nitrogen6sx.dtb
arch/arm/boot/dts/imx6sx-sabreauto.dtb
arch/arm/boot/dts/imx6sx-sdb.dtb
arch/arm/boot/dts/imx6sx-sdb-mqs.dtb
arch/arm/boot/dts/imx6sx-sdb-reva.dtb
arch/arm/boot/dts/imx6sx-sdb-sai.dtb
arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb
arch/arm/boot/dts/imx6sx-udoo-neo-basic.dtb
arch/arm/boot/dts/imx6sx-udoo-neo-extended.dtb
arch/arm/boot/dts/imx6sx-udoo-neo-full.dtb
arch/arm/boot/dts/imx6ul-14x14-evk.dtb
arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
arch/arm/boot/dts/imx6ul-geam.dtb
arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
arch/arm/boot/dts/imx6ul-isiot-nand.dtb
arch/arm/boot/dts/imx6ull-14x14-evk.dtb
arch/arm/boot/dts/imx6ul-liteboard.dtb
arch/arm/boot/dts/imx6ull-jozacp.dtb
arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
arch/arm/boot/dts/imx6ull-opos6uldev.dtb
arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
arch/arm/boot/dts/imx6ul-opos6uldev.dtb
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
arch/arm/boot/dts/imx6ul-pico-pi.dtb
arch/arm/boot/dts/imx6ul-prti6g.dtb
arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
arch/arm/boot/dts/imx6ulz-14x14-evk.dtb
usb@2184200: 'maximum-speed' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx6qp-zii-rdu2.dtb
arch/arm/boot/dts/imx6q-zii-rdu2.dtb
usb@2184200: 'reset-gpios' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx6q-b450v3.dtb
arch/arm/boot/dts/imx6q-b650v3.dtb
arch/arm/boot/dts/imx6q-b850v3.dtb
arch/arm/boot/dts/imx6q-dms-ba16.dtb
arch/arm/boot/dts/imx6sx-nitrogen6sx.dtb
usb@2184400: 'fsl,anatop' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx6sx-nitrogen6sx.dtb
arch/arm/boot/dts/imx6sx-sabreauto.dtb
arch/arm/boot/dts/imx6sx-sdb.dtb
arch/arm/boot/dts/imx6sx-sdb-mqs.dtb
arch/arm/boot/dts/imx6sx-sdb-reva.dtb
arch/arm/boot/dts/imx6sx-sdb-sai.dtb
arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb
arch/arm/boot/dts/imx6sx-udoo-neo-basic.dtb
arch/arm/boot/dts/imx6sx-udoo-neo-extended.dtb
arch/arm/boot/dts/imx6sx-udoo-neo-full.dtb
usb@30b10000: 'adp-disable', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx7d-mba7.dtb
arch/arm/boot/dts/imx7s-mba7.dtb
usb@30b20000: 'adp-disable', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx7d-flex-concentrator.dtb
arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb
arch/arm/boot/dts/imx7d-mba7.dtb
usb@30b20000: 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx7d-remarkable2.dtb
usb@32e40000: 'adp-disable', 'clock-names', 'hnp-disable', 'port', 'power-domains', 'srp-disable', 'usb-role-switch' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb
arch/arm64/boot/dts/freescale/imx8mm-evk.dtb
arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dtb
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dtb
arch/arm64/boot/dts/freescale/imx8mn-evk.dtb
usb@32e40000: 'adp-disable', 'clock-names', 'hnp-disable', 'power-domains', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb
arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb
arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb
arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb
arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb
arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb
usb@32e40000: 'adp-disable', 'clock-names', 'power-domains', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb
usb@32e40000: 'clock-names', 'power-domains' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb
arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb
arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dtb
arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dtb
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2.dtb
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dtb
arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dtb
arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dtb
usb@32e40000: 'clock-names', 'power-domains', 'usb-role-switch' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb
arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb
usb@32e50000: 'adp-disable', 'clock-names', 'hnp-disable', 'power-domains', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb
usb@32e50000: 'clock-names', 'power-domains' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb
arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb
arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb
arch/arm64/boot/dts/freescale/imx8mm-evk.dtb
arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb
arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb
arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb
arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb
arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb
arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb
arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb
arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb
usb@32e50000: 'clock-names', 'power-domains', 'usb1@1' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dtb
usb@40330000: 'adp-disable', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx7ulp-com.dtb
arch/arm/boot/dts/imx7ulp-evk.dtb
usb@53ff4000: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-svga.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-vga.dtb
arch/arm/boot/dts/imx25-karo-tx25.dtb
arch/arm/boot/dts/imx25-pdk.dtb
arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
arch/arm/boot/dts/imx35-pdk.dtb
usb@53ff4000: clocks: [[2, 9], [2, 70], [2, 8]] is too long
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-svga.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-vga.dtb
arch/arm/boot/dts/imx25-karo-tx25.dtb
arch/arm/boot/dts/imx25-pdk.dtb
usb@53ff4000: clocks: [[2, 9], [2, 73], [2, 28]] is too long
arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
arch/arm/boot/dts/imx35-pdk.dtb
usb@53ff4000: compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
arch/arm/boot/dts/imx35-pdk.dtb
usb@53ff4400: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
arch/arm/boot/dts/imx35-pdk.dtb
usb@53ff4400: 'clock-names', 'maximum-speed' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-svga.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-vga.dtb
arch/arm/boot/dts/imx25-karo-tx25.dtb
arch/arm/boot/dts/imx25-pdk.dtb
usb@53ff4400: clocks: [[2, 9], [2, 70], [2, 8]] is too long
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-svga.dtb
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-vga.dtb
arch/arm/boot/dts/imx25-karo-tx25.dtb
arch/arm/boot/dts/imx25-pdk.dtb
usb@53ff4400: clocks: [[2, 9], [2, 73], [2, 28]] is too long
arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
arch/arm/boot/dts/imx35-pdk.dtb
usb@53ff4400: compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
arch/arm/boot/dts/imx35-pdk.dtb
usb@73f80200: 'maximum-speed' does not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/imx51-zii-rdu1.dtb
usb@78d9000: interrupts: [[0, 134, 4], [0, 140, 4]] is too long
arch/arm64/boot/dts/qcom/apq8016-sbc.dtb
arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dtb
arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dtb
arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dtb
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dtb
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dtb
arch/arm64/boot/dts/qcom/msm8916-mtp.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb
arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dtb
arch/arm/boot/dts/qcom-apq8016-sbc.dtb
arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dtb
usb@78d9000: reg: [[126717952, 512], [126718464, 512]] is too long
arch/arm64/boot/dts/qcom/apq8016-sbc.dtb
arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dtb
arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dtb
arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dtb
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dtb
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dtb
arch/arm64/boot/dts/qcom/msm8916-mtp.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb
arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dtb
arch/arm/boot/dts/qcom-apq8016-sbc.dtb
arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dtb
usb@78d9000: '#reset-cells', 'adp-disable', 'clock-names', 'hnp-disable', 'reset-names', 'resets', 'srp-disable', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm64/boot/dts/qcom/apq8016-sbc.dtb
arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dtb
arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dtb
arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dtb
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dtb
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dtb
arch/arm64/boot/dts/qcom/msm8916-mtp.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb
arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dtb
arch/arm/boot/dts/qcom-apq8016-sbc.dtb
arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dtb
usb@7d000000: 'nvidia,needs-double-reset', 'nvidia,phy', 'operating-points-v2', 'power-domains', 'reset-names', 'resets' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-E1565.dtb
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-PM269.dtb
arch/arm/boot/dts/tegra30-asus-nexus7-tilapia-E1565.dtb
arch/arm/boot/dts/tegra30-asus-tf201.dtb
arch/arm/boot/dts/tegra30-asus-tf300t.dtb
arch/arm/boot/dts/tegra30-asus-tf300tg.dtb
arch/arm/boot/dts/tegra30-asus-tf700t.dtb
arch/arm/boot/dts/tegra30-beaver.dtb
arch/arm/boot/dts/tegra30-ouya.dtb
arch/arm/boot/dts/tegra30-pegatron-chagall.dtb
usb@7d000000: 'nvidia,phy', 'reset-names', 'resets' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/tegra114-asus-tf701t.dtb
arch/arm/boot/dts/tegra114-dalmore.dtb
arch/arm/boot/dts/tegra124-jetson-tk1.dtb
usb@c5000000: 'nvidia,needs-double-reset', 'nvidia,phy', 'operating-points-v2', 'power-domains', 'reset-names', 'resets' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/tegra20-acer-a500-picasso.dtb
arch/arm/boot/dts/tegra20-asus-tf101.dtb
arch/arm/boot/dts/tegra20-paz00.dtb
usb@f9a55000: reg: [[4188360704, 512], [4188361216, 512]] is too long
arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dtb
arch/arm/boot/dts/qcom-apq8026-lg-lenok.dtb
arch/arm/boot/dts/qcom-apq8074-dragonboard.dtb
arch/arm/boot/dts/qcom-msm8226-samsung-s3ve3g.dtb
arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dtb
arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dtb
arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dtb
arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dtb
arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb
arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-honami.dtb
usb@f9a55000: '#reset-cells', 'adp-disable', 'clock-names', 'hnp-disable', 'phy-select', 'reset-names', 'resets', 'srp-disable', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/qcom-apq8074-dragonboard.dtb
arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dtb
arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dtb
arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dtb
arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dtb
arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb
arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-honami.dtb
usb@f9a55000: '#reset-cells', 'adp-disable', 'clock-names', 'hnp-disable', 'reset-names', 'resets', 'srp-disable', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dtb
arch/arm/boot/dts/qcom-apq8026-lg-lenok.dtb
arch/arm/boot/dts/qcom-msm8226-samsung-s3ve3g.dtb
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH V2 6/6] dt-bindings: usb: ci-hdrc-usb2: add i.MX8DXL/M[M,N] support
2022-10-14 13:33 ` Rob Herring
@ 2022-10-14 13:54 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-10-14 13:54 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: krzysztof.kozlowski+dt, linux-usb, linux-arm-kernel, xu.yang_2,
kernel, linux-imx, festevam, linux-kernel, Peng Fan, devicetree,
s.hauer, jun.li, gregkh, shawnguo
On Fri, Oct 14, 2022 at 08:33:51AM -0500, Rob Herring wrote:
> On Fri, 14 Oct 2022 17:51:48 +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add i.MX8MM/N compatible strings, which are compatible with i.MX7D.
> > Add i.MX8DXL compatible string, which is compatible with i.MX7ULP.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
The list of warnings after the conversion should be what you intend
to fix in dts files. This looks like things in the schema need to be
fixed. Like referencing usb-drd.yaml for example.
>
>
> usb@10024000: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx27-apf27dev.dtb
> arch/arm/boot/dts/imx27-apf27.dtb
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
> arch/arm/boot/dts/imx27-pdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
>
> usb@10024000: clocks: [[1, 75], [1, 62], [1, 15]] is too long
> arch/arm/boot/dts/imx27-apf27dev.dtb
> arch/arm/boot/dts/imx27-apf27.dtb
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
> arch/arm/boot/dts/imx27-pdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
>
> usb@10024000: compatible: 'oneOf' conditional failed, one must be fixed:
> arch/arm/boot/dts/imx27-apf27dev.dtb
> arch/arm/boot/dts/imx27-apf27.dtb
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
> arch/arm/boot/dts/imx27-pdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
>
> usb@10024200: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx27-apf27dev.dtb
> arch/arm/boot/dts/imx27-apf27.dtb
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
> arch/arm/boot/dts/imx27-pdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
>
> usb@10024200: clocks: [[1, 75], [1, 62], [1, 15]] is too long
> arch/arm/boot/dts/imx27-apf27dev.dtb
> arch/arm/boot/dts/imx27-apf27.dtb
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
> arch/arm/boot/dts/imx27-pdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
>
> usb@10024200: compatible: 'oneOf' conditional failed, one must be fixed:
> arch/arm/boot/dts/imx27-apf27dev.dtb
> arch/arm/boot/dts/imx27-apf27.dtb
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
> arch/arm/boot/dts/imx27-pdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
>
> usb@10024400: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx27-apf27dev.dtb
> arch/arm/boot/dts/imx27-apf27.dtb
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
> arch/arm/boot/dts/imx27-pdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
>
> usb@10024400: clocks: [[1, 75], [1, 62], [1, 15]] is too long
> arch/arm/boot/dts/imx27-apf27dev.dtb
> arch/arm/boot/dts/imx27-apf27.dtb
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
> arch/arm/boot/dts/imx27-pdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
>
> usb@10024400: compatible: 'oneOf' conditional failed, one must be fixed:
> arch/arm/boot/dts/imx27-apf27dev.dtb
> arch/arm/boot/dts/imx27-apf27.dtb
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb
> arch/arm/boot/dts/imx27-pdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dtb
> arch/arm/boot/dts/imx27-phytec-phycore-rdk.dtb
>
> usb@12500000: reg: [[307232768, 512], [307233280, 512]] is too long
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> usb@12500000: '#reset-cells', 'clock-names', 'reset-names', 'resets', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> usb@12520000: reg: [[307363840, 512], [307364352, 512]] is too long
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> usb@12520000: '#reset-cells', 'clock-names', 'reset-names', 'resets', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> usb@12530000: reg: [[307429376, 512], [307429888, 512]] is too long
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> usb@12530000: '#reset-cells', 'clock-names', 'reset-names', 'resets', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> usb@2184000: 'adp-disable', 'fsl,anatop', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx6sll-evk.dtb
> arch/arm/boot/dts/imx6sll-kobo-clarahd.dtb
> arch/arm/boot/dts/imx6sll-kobo-librah2o.dtb
> arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
> arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
> arch/arm/boot/dts/imx6ull-colibri-aster.dtb
> arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
> arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
> arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
> arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
> arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
> arch/arm/boot/dts/imx6ull-colibri-iris.dtb
> arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
> arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
> arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
> arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
> arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
> arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
> arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
> arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
> arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
> arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
> arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dtb
>
> usb@2184000: 'adp-disable', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx6dl-mba6a.dtb
> arch/arm/boot/dts/imx6dl-mba6b.dtb
> arch/arm/boot/dts/imx6dl-yapp4-draco.dtb
> arch/arm/boot/dts/imx6dl-yapp4-hydra.dtb
> arch/arm/boot/dts/imx6dl-yapp4-orion.dtb
> arch/arm/boot/dts/imx6dl-yapp4-ursa.dtb
> arch/arm/boot/dts/imx6q-bosch-acc.dtb
> arch/arm/boot/dts/imx6q-mba6a.dtb
> arch/arm/boot/dts/imx6q-mba6b.dtb
> arch/arm/boot/dts/imx6q-pistachio.dtb
> arch/arm/boot/dts/imx6qp-mba6b.dtb
> arch/arm/boot/dts/imx6qp-yapp4-crux-plus.dtb
> arch/arm/boot/dts/imx6q-var-dt6customboard.dtb
> arch/arm/boot/dts/imx6q-yapp4-crux.dtb
> arch/arm/boot/dts/imx6sl-tolino-shine2hd.dtb
> arch/arm/boot/dts/imx6sl-tolino-shine3.dtb
> arch/arm/boot/dts/imx6sl-tolino-vision5.dtb
>
> usb@2184000: 'fsl,anatop' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx6sx-nitrogen6sx.dtb
> arch/arm/boot/dts/imx6sx-sabreauto.dtb
> arch/arm/boot/dts/imx6sx-sdb.dtb
> arch/arm/boot/dts/imx6sx-sdb-mqs.dtb
> arch/arm/boot/dts/imx6sx-sdb-reva.dtb
> arch/arm/boot/dts/imx6sx-sdb-sai.dtb
> arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-basic.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-extended.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-full.dtb
> arch/arm/boot/dts/imx6ul-14x14-evk.dtb
> arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
> arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
> arch/arm/boot/dts/imx6ul-geam.dtb
> arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
> arch/arm/boot/dts/imx6ul-isiot-nand.dtb
> arch/arm/boot/dts/imx6ull-14x14-evk.dtb
> arch/arm/boot/dts/imx6ul-liteboard.dtb
> arch/arm/boot/dts/imx6ull-jozacp.dtb
> arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
> arch/arm/boot/dts/imx6ull-opos6uldev.dtb
> arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
> arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
> arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
> arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
> arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
> arch/arm/boot/dts/imx6ul-opos6uldev.dtb
> arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
> arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
> arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
> arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
> arch/arm/boot/dts/imx6ul-pico-pi.dtb
> arch/arm/boot/dts/imx6ul-prti6g.dtb
> arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
> arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
> arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
> arch/arm/boot/dts/imx6ulz-14x14-evk.dtb
>
> usb@2184200: 'maximum-speed' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx6qp-zii-rdu2.dtb
> arch/arm/boot/dts/imx6q-zii-rdu2.dtb
>
> usb@2184200: 'reset-gpios' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx6q-b450v3.dtb
> arch/arm/boot/dts/imx6q-b650v3.dtb
> arch/arm/boot/dts/imx6q-b850v3.dtb
> arch/arm/boot/dts/imx6q-dms-ba16.dtb
> arch/arm/boot/dts/imx6sx-nitrogen6sx.dtb
>
> usb@2184400: 'fsl,anatop' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx6sx-nitrogen6sx.dtb
> arch/arm/boot/dts/imx6sx-sabreauto.dtb
> arch/arm/boot/dts/imx6sx-sdb.dtb
> arch/arm/boot/dts/imx6sx-sdb-mqs.dtb
> arch/arm/boot/dts/imx6sx-sdb-reva.dtb
> arch/arm/boot/dts/imx6sx-sdb-sai.dtb
> arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-basic.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-extended.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-full.dtb
>
> usb@30b10000: 'adp-disable', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx7d-mba7.dtb
> arch/arm/boot/dts/imx7s-mba7.dtb
>
> usb@30b20000: 'adp-disable', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx7d-flex-concentrator.dtb
> arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb
> arch/arm/boot/dts/imx7d-mba7.dtb
>
> usb@30b20000: 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx7d-remarkable2.dtb
>
> usb@32e40000: 'adp-disable', 'clock-names', 'hnp-disable', 'port', 'power-domains', 'srp-disable', 'usb-role-switch' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtb
> arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dtb
> arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dtb
> arch/arm64/boot/dts/freescale/imx8mn-evk.dtb
>
> usb@32e40000: 'adp-disable', 'clock-names', 'hnp-disable', 'power-domains', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb
> arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb
> arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb
> arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb
> arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb
> arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb
>
> usb@32e40000: 'adp-disable', 'clock-names', 'power-domains', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb
>
> usb@32e40000: 'clock-names', 'power-domains' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb
> arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb
> arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb
> arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dtb
> arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb
> arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dtb
> arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2.dtb
> arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dtb
> arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dtb
> arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dtb
>
> usb@32e40000: 'clock-names', 'power-domains', 'usb-role-switch' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb
> arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb
>
> usb@32e50000: 'adp-disable', 'clock-names', 'hnp-disable', 'power-domains', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb
>
> usb@32e50000: 'clock-names', 'power-domains' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb
> arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb
> arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb
> arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtb
> arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb
> arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb
> arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb
> arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb
> arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb
> arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb
> arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb
> arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb
>
> usb@32e50000: 'clock-names', 'power-domains', 'usb1@1' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dtb
>
> usb@40330000: 'adp-disable', 'hnp-disable', 'srp-disable' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx7ulp-com.dtb
> arch/arm/boot/dts/imx7ulp-evk.dtb
>
> usb@53ff4000: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-svga.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-vga.dtb
> arch/arm/boot/dts/imx25-karo-tx25.dtb
> arch/arm/boot/dts/imx25-pdk.dtb
> arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
> arch/arm/boot/dts/imx35-pdk.dtb
>
> usb@53ff4000: clocks: [[2, 9], [2, 70], [2, 8]] is too long
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-svga.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-vga.dtb
> arch/arm/boot/dts/imx25-karo-tx25.dtb
> arch/arm/boot/dts/imx25-pdk.dtb
>
> usb@53ff4000: clocks: [[2, 9], [2, 73], [2, 28]] is too long
> arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
> arch/arm/boot/dts/imx35-pdk.dtb
>
> usb@53ff4000: compatible: 'oneOf' conditional failed, one must be fixed:
> arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
> arch/arm/boot/dts/imx35-pdk.dtb
>
> usb@53ff4400: 'clock-names' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
> arch/arm/boot/dts/imx35-pdk.dtb
>
> usb@53ff4400: 'clock-names', 'maximum-speed' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-svga.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-vga.dtb
> arch/arm/boot/dts/imx25-karo-tx25.dtb
> arch/arm/boot/dts/imx25-pdk.dtb
>
> usb@53ff4400: clocks: [[2, 9], [2, 70], [2, 8]] is too long
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-svga.dtb
> arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-dvi-vga.dtb
> arch/arm/boot/dts/imx25-karo-tx25.dtb
> arch/arm/boot/dts/imx25-pdk.dtb
>
> usb@53ff4400: clocks: [[2, 9], [2, 73], [2, 28]] is too long
> arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
> arch/arm/boot/dts/imx35-pdk.dtb
>
> usb@53ff4400: compatible: 'oneOf' conditional failed, one must be fixed:
> arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
> arch/arm/boot/dts/imx35-pdk.dtb
>
> usb@73f80200: 'maximum-speed' does not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/imx51-zii-rdu1.dtb
>
> usb@78d9000: interrupts: [[0, 134, 4], [0, 140, 4]] is too long
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtb
> arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dtb
> arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dtb
> arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dtb
> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dtb
> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dtb
> arch/arm64/boot/dts/qcom/msm8916-mtp.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb
> arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dtb
> arch/arm/boot/dts/qcom-apq8016-sbc.dtb
> arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dtb
>
> usb@78d9000: reg: [[126717952, 512], [126718464, 512]] is too long
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtb
> arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dtb
> arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dtb
> arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dtb
> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dtb
> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dtb
> arch/arm64/boot/dts/qcom/msm8916-mtp.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb
> arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dtb
> arch/arm/boot/dts/qcom-apq8016-sbc.dtb
> arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dtb
>
> usb@78d9000: '#reset-cells', 'adp-disable', 'clock-names', 'hnp-disable', 'reset-names', 'resets', 'srp-disable', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtb
> arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dtb
> arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dtb
> arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dtb
> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dtb
> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dtb
> arch/arm64/boot/dts/qcom/msm8916-mtp.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dtb
> arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb
> arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dtb
> arch/arm/boot/dts/qcom-apq8016-sbc.dtb
> arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dtb
>
> usb@7d000000: 'nvidia,needs-double-reset', 'nvidia,phy', 'operating-points-v2', 'power-domains', 'reset-names', 'resets' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/tegra30-asus-nexus7-grouper-E1565.dtb
> arch/arm/boot/dts/tegra30-asus-nexus7-grouper-PM269.dtb
> arch/arm/boot/dts/tegra30-asus-nexus7-tilapia-E1565.dtb
> arch/arm/boot/dts/tegra30-asus-tf201.dtb
> arch/arm/boot/dts/tegra30-asus-tf300t.dtb
> arch/arm/boot/dts/tegra30-asus-tf300tg.dtb
> arch/arm/boot/dts/tegra30-asus-tf700t.dtb
> arch/arm/boot/dts/tegra30-beaver.dtb
> arch/arm/boot/dts/tegra30-ouya.dtb
> arch/arm/boot/dts/tegra30-pegatron-chagall.dtb
>
> usb@7d000000: 'nvidia,phy', 'reset-names', 'resets' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/tegra114-asus-tf701t.dtb
> arch/arm/boot/dts/tegra114-dalmore.dtb
> arch/arm/boot/dts/tegra124-jetson-tk1.dtb
>
> usb@c5000000: 'nvidia,needs-double-reset', 'nvidia,phy', 'operating-points-v2', 'power-domains', 'reset-names', 'resets' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/tegra20-acer-a500-picasso.dtb
> arch/arm/boot/dts/tegra20-asus-tf101.dtb
> arch/arm/boot/dts/tegra20-paz00.dtb
>
> usb@f9a55000: reg: [[4188360704, 512], [4188361216, 512]] is too long
> arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dtb
> arch/arm/boot/dts/qcom-apq8026-lg-lenok.dtb
> arch/arm/boot/dts/qcom-apq8074-dragonboard.dtb
> arch/arm/boot/dts/qcom-msm8226-samsung-s3ve3g.dtb
> arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dtb
> arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dtb
> arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dtb
> arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dtb
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-honami.dtb
>
> usb@f9a55000: '#reset-cells', 'adp-disable', 'clock-names', 'hnp-disable', 'phy-select', 'reset-names', 'resets', 'srp-disable', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/qcom-apq8074-dragonboard.dtb
> arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dtb
> arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dtb
> arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dtb
> arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dtb
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-honami.dtb
>
> usb@f9a55000: '#reset-cells', 'adp-disable', 'clock-names', 'hnp-disable', 'reset-names', 'resets', 'srp-disable', 'ulpi' do not match any of the regexes: 'ethernet@[0-9a-f]$'
> arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dtb
> arch/arm/boot/dts/qcom-apq8026-lg-lenok.dtb
> arch/arm/boot/dts/qcom-msm8226-samsung-s3ve3g.dtb
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread