From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E5FC433FE for ; Fri, 14 Oct 2022 20:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbiJNUmt (ORCPT ); Fri, 14 Oct 2022 16:42:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231504AbiJNUms (ORCPT ); Fri, 14 Oct 2022 16:42:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5DA5106A4D; Fri, 14 Oct 2022 13:42:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 70DEC61C3C; Fri, 14 Oct 2022 20:42:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7CAFC433B5; Fri, 14 Oct 2022 20:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665780162; bh=O2YPCkvYoPkPM51n6KuE/kCLXzRJRqmOqCJxc3Y7mZQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ErXdOE1Nm7fTP7QoH5gB7S2AdCRaYd2zN/6XSFY6kzVcntp6H8nDVfxYMaSg2jbpD ND8eh4tCScUhdfjq8dKMuGaF1H2a9BMhS7wVF+KTquILvLUw8dn5ZZPnNRV+LSnTPR hE2oQgKvcWdTMe9xzA2Adm+KaPmeaCAiUx5pGclOkMwFubWCrOekCbA/c3WLsM6uPm WTbdZthF0elbni9zYxYISQgK1xp0UO5VOyPg8pR9hH/szkf7RA7/9HSPg72P0G340X oQy+2mZVRvL0pWQsn91mp9BADJh6w0g2PkGkAFrLMzpm7ds9BQBh5eQEpihZNc2biO WiTGC6WMReSrQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221013112336.15438-3-johnson.wang@mediatek.com> References: <20221013112336.15438-1-johnson.wang@mediatek.com> <20221013112336.15438-3-johnson.wang@mediatek.com> Subject: Re: [PATCH v4 2/4] dt-bindings: arm: mediatek: Add new bindings of MediaTek frequency hopping From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, kuan-hsin.lee@mediatek.com, yu-chang.wang@mediatek.com, Johnson Wang , Edward-JW Yang To: Johnson Wang , angelogioacchino.delregno@collabora.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org Date: Fri, 14 Oct 2022 13:42:40 -0700 User-Agent: alot/0.10 Message-Id: <20221014204242.C7CAFC433B5@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Johnson Wang (2022-10-13 04:23:34) > Add the new binding documentation for MediaTek frequency hopping > and spread spectrum clocking control. >=20 > Co-developed-by: Edward-JW Yang > Signed-off-by: Edward-JW Yang > Signed-off-by: Johnson Wang > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: Rob Herring > --- > .../arm/mediatek/mediatek,mt8186-fhctl.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediat= ek,mt8186-fhctl.yaml >=20 > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt81= 86-fhctl.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8= 186-fhctl.yaml > new file mode 100644 > index 000000000000..59111946966c > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-fhct= l.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/mediatek/mediatek,mt8186-fhctl.ya= ml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek frequency hopping and spread spectrum clocking control The driver patch is in drivers/clk so why not put the binding in bindings/clock as well? > + > +maintainers: > + - Edward-JW Yang > + [...] > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + #include > + fhctl: fhctl@1000ce00 { Is it a clock-controller? 'fhctl' isn't a generic node name. > + compatible =3D "mediatek,mt8186-fhctl"; > + reg =3D <0x1000ce00 0x200>; > + clocks =3D <&apmixedsys CLK_APMIXED_MSDCPLL>; > + mediatek,hopping-ssc-percent =3D <3>;