* [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node
@ 2022-10-17 18:51 Caleb Connolly
2022-10-17 19:42 ` Rob Herring
2022-10-17 20:13 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Caleb Connolly @ 2022-10-17 18:51 UTC (permalink / raw)
To: caleb.connolly
Cc: Luca Weiss, Andy Gross, Bjorn Andersson, devicetree,
Konrad Dybcio, Krzysztof Kozlowski, Lee Jones, linux-arm-msm,
linux-kernel, Rob Herring, Stephen Boyd
Document the rradc node name, like adc-tm it's only used on a few
platforms, so differentiate it from the standard adc node.
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
V1: https://lore.kernel.org/linux-arm-msm/20221016175757.1911016-1-caleb.connolly@linaro.org/
Changes since v1:
* Add a new node instead of using the adc@ node
* no longer depend on Luca's patch
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 65cbc6dee545..631141f99bce 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -101,6 +101,10 @@ patternProperties:
type: object
$ref: /schemas/thermal/qcom-spmi-adc-tm5.yaml#
+ "^rradc@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/iio/adc/qcom,spmi-rradc.yaml#
+
"^audio-codec@[0-9a-f]+$":
type: object
additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
--
2.38.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node
2022-10-17 18:51 [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node Caleb Connolly
@ 2022-10-17 19:42 ` Rob Herring
2022-10-17 20:13 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-10-17 19:42 UTC (permalink / raw)
To: Caleb Connolly
Cc: Luca Weiss, Andy Gross, Bjorn Andersson, devicetree,
Konrad Dybcio, Krzysztof Kozlowski, Lee Jones, linux-arm-msm,
linux-kernel, Stephen Boyd
On Mon, Oct 17, 2022 at 1:52 PM Caleb Connolly
<caleb.connolly@linaro.org> wrote:
>
> Document the rradc node name, like adc-tm it's only used on a few
> platforms, so differentiate it from the standard adc node.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>
> V1: https://lore.kernel.org/linux-arm-msm/20221016175757.1911016-1-caleb.connolly@linaro.org/
> Changes since v1:
> * Add a new node instead of using the adc@ node
> * no longer depend on Luca's patch
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
Doesn't apply to rc1.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node
2022-10-17 18:51 [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node Caleb Connolly
2022-10-17 19:42 ` Rob Herring
@ 2022-10-17 20:13 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-17 20:13 UTC (permalink / raw)
To: Caleb Connolly
Cc: Luca Weiss, Andy Gross, Bjorn Andersson, devicetree,
Konrad Dybcio, Krzysztof Kozlowski, Lee Jones, linux-arm-msm,
linux-kernel, Rob Herring, Stephen Boyd
On 17/10/2022 14:51, Caleb Connolly wrote:
> Document the rradc node name, like adc-tm it's only used on a few
> platforms, so differentiate it from the standard adc node.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>
> V1: https://lore.kernel.org/linux-arm-msm/20221016175757.1911016-1-caleb.connolly@linaro.org/
> Changes since v1:
> * Add a new node instead of using the adc@ node
> * no longer depend on Luca's patch
This is not what I proposed. The node name should stay adc as it is
generic. I propose to do it the same way as in
f4b632da13cf0ee39cdbd4ff08d1961ed50e3c14
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-17 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-17 18:51 [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node Caleb Connolly
2022-10-17 19:42 ` Rob Herring
2022-10-17 20:13 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).