From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C3AC433FE for ; Mon, 17 Oct 2022 20:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229914AbiJQUu4 (ORCPT ); Mon, 17 Oct 2022 16:50:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbiJQUuz (ORCPT ); Mon, 17 Oct 2022 16:50:55 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C52D6C97D for ; Mon, 17 Oct 2022 13:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666039849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZUPaVA9mOe9qz31NtPQ5gA4/QtVOU/DOfiSg8H5xwzc=; b=CykiKLYjjU6qpzUp6cOPg5P9nlzKO1oWGY0rox78CPn5zB5IpURDn07ky3b+wm7qkwZ2I7 ZuE2mGySBW1/xhablAyAM/aAlLfvG9NSZNs3QYN+M2zdm3Xr6r2G517jIb5gXQ+vr5M0kn fjsVMR3IxmbMwZIqmKL0xwmd1A0e8u4= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-651-u7sbsJMbNbGpH_owVFXyZA-1; Mon, 17 Oct 2022 16:50:48 -0400 X-MC-Unique: u7sbsJMbNbGpH_owVFXyZA-1 Received: by mail-oo1-f71.google.com with SMTP id t10-20020a4a760a000000b004809c721ac0so5175556ooc.4 for ; Mon, 17 Oct 2022 13:50:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZUPaVA9mOe9qz31NtPQ5gA4/QtVOU/DOfiSg8H5xwzc=; b=yvHCo2q77m3z4obW55HsQWsdS6J5XqBcLzp5KJSJiT4YLxr+iBggFjjbBeKw/GY7y1 57xhcabFhole0Kjd3kRKkz1vvH8/uirG9QJ+jzeYnRN0Fh0nwJoQRtdonS1aJ+Zah+Z6 IUQksa5tJhqLGt5lrxQwf5jOBepvQ1nZoUeiwfvJWkB4SM6C62KRY8HUUVq6Ujs3G7nb KgNne5HylEB310gkcnhtQ+g5iQ6YCvZ0MvXt6hpj96Sk8gaFQbVxPxvPx01pvojFMEEe HN2yLdCdL5LCkYKJqS0o/+jxxCaGljPWQTw+cbmRw5RGn0UYyxAdyZZ0WxRJoEyNu+RN sbJQ== X-Gm-Message-State: ACrzQf3BuuG8YX37VoS/l/2dl6GMhnyA0e/4OmkiwHOVcxEeS/dEhcub nJU4UonwdQ/c/yOShqAxu2qCTuXCcU+yCfuQ2Hm3IwQ8iqVkvhRo9a/6XNZ1ghWVPOgVrrvii2I es7LG+nGKEueQtEchzUfY2w== X-Received: by 2002:a4a:eb10:0:b0:475:bf9b:e6ba with SMTP id f16-20020a4aeb10000000b00475bf9be6bamr5039473ooj.33.1666039846597; Mon, 17 Oct 2022 13:50:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7edLgl7Vg1Gy/zyvTAwhkrXRUgoyjTw6/UNJC5o7zT06WFRmqDS5N4NTFiBpM5ix4JIIz/Zw== X-Received: by 2002:a4a:eb10:0:b0:475:bf9b:e6ba with SMTP id f16-20020a4aeb10000000b00475bf9be6bamr5039462ooj.33.1666039846353; Mon, 17 Oct 2022 13:50:46 -0700 (PDT) Received: from halaney-x13s ([2600:1700:1ff0:d0e0::21]) by smtp.gmail.com with ESMTPSA id 184-20020a4a1ac1000000b0044df311eee1sm4599264oof.33.2022.10.17.13.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 13:50:45 -0700 (PDT) Date: Mon, 17 Oct 2022 15:50:43 -0500 From: Andrew Halaney To: Johan Hovold Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc8280xp: fix USB0 PHY PCS_MISC registers Message-ID: <20221017205043.wgys4c7ybb4ga4o7@halaney-x13s> References: <20220919094454.1574-1-johan+linaro@kernel.org> <20220919094454.1574-2-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220919094454.1574-2-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Mon, Sep 19, 2022 at 11:44:51AM +0200, Johan Hovold wrote: > The USB0 SS PHY node had the PCS_MISC register block (0x1200) replaced > with PCS_USB (0x1700). > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Johan Hovold Reviewed-by: Andrew Halaney Thanks for the patch, I think this patch makes sense from what I'm seeing of upstream's expectations (that register space should be PCS_MISC's) downstream, register names, and offsets. Being verbose because it took me a little bit to figure out, but here's the offset and registers I found downstream which correlate to your change: /* Module: USB3_PCS_MISC_USB3_PCS_MISC_USB3_PCS_MISC */ #define USB3_PCS_MISC_TYPEC_CTRL 0x1200 #define USB3_PCS_MISC_TYPEC_PWRDN_CTRL 0x1204 #define USB3_PCS_MISC_PCS_MISC_CONFIG1 0x1208 #define USB3_PCS_MISC_CLAMP_ENABLE 0x120C #define USB3_PCS_MISC_TYPEC_STATUS 0x1210 #define USB3_PCS_MISC_PLACEHOLDER_STATUS 0x1214 Your description of the PCS_USB region accidentally being used in the prior version also adds up with what I see. Thanks, Andrew > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 49ea8b5612fc..e8905445ca19 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1184,7 +1184,7 @@ usb_0_ssphy: usb3-phy@88eb400 { > <0 0x088ec400 0 0x1f0>, > <0 0x088eba00 0 0x100>, > <0 0x088ebc00 0 0x3ec>, > - <0 0x088ec700 0 0x64>; > + <0 0x088ec200 0 0x18>; > #phy-cells = <0>; > #clock-cells = <0>; > clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; > -- > 2.35.1 >