From: Marco Felsch <m.felsch@pengutronix.de>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
devicetree@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/15] arm64: dts: imx8mp-evk: fix BUCK/LDO voltage
Date: Thu, 20 Oct 2022 13:02:57 +0200 [thread overview]
Message-ID: <20221020110257.5ojjq2j2c53hevnt@pengutronix.de> (raw)
In-Reply-To: <20221020095934.1659449-4-peng.fan@oss.nxp.com>
Hi Peng,
On 22-10-20, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Per PCA9450C datasheet, the voltage range as below:
> BUCK1 0.6 - 2.1875
> BUCK2 0.6 - 2.1875
> BUCK4 0.6 - 3.4
> BUCK5 0.6 - 3.4
> BUCK6 0.6 - 3.4
>
> LDO1 1.6-1.9, 3.0-3.3
> LDO2 0.8 – 1.15
> LDO3 0.8 - 3.3
> LDO4 0.8 - 3.3
> LDO5 1.8 - 3.3
>
> So correct them, and also add LDO[2,4]
In the DTS you specify voltage constraints for a specific hardware and
not the one supported by the PMIC. What the PMIC supports (min/max) is
specified within the driver.
Regards,
Marco
>
> Fixes: 5497bc2a2bff ("arm64: dts: imx8mp-evk: Add PMIC device")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 44 +++++++++++++-------
> 1 file changed, 30 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> index b4c1ef2559f2..a4cddc5a8620 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> @@ -248,8 +248,8 @@ pmic@25 {
> regulators {
> BUCK1 {
> regulator-name = "BUCK1";
> - regulator-min-microvolt = <720000>;
> - regulator-max-microvolt = <1000000>;
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <2187500>;
> regulator-boot-on;
> regulator-always-on;
> regulator-ramp-delay = <3125>;
> @@ -257,8 +257,8 @@ BUCK1 {
>
> reg_arm: BUCK2 {
> regulator-name = "BUCK2";
> - regulator-min-microvolt = <720000>;
> - regulator-max-microvolt = <1025000>;
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <2187500>;
> regulator-boot-on;
> regulator-always-on;
> regulator-ramp-delay = <3125>;
> @@ -268,40 +268,56 @@ reg_arm: BUCK2 {
>
> BUCK4 {
> regulator-name = "BUCK4";
> - regulator-min-microvolt = <3000000>;
> - regulator-max-microvolt = <3600000>;
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <3400000>;
> regulator-boot-on;
> regulator-always-on;
> };
>
> BUCK5 {
> regulator-name = "BUCK5";
> - regulator-min-microvolt = <1650000>;
> - regulator-max-microvolt = <1950000>;
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <3400000>;
> regulator-boot-on;
> regulator-always-on;
> };
>
> BUCK6 {
> regulator-name = "BUCK6";
> - regulator-min-microvolt = <1045000>;
> - regulator-max-microvolt = <1155000>;
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <3400000>;
> regulator-boot-on;
> regulator-always-on;
> };
>
> LDO1 {
> regulator-name = "LDO1";
> - regulator-min-microvolt = <1650000>;
> - regulator-max-microvolt = <1950000>;
> + regulator-min-microvolt = <1600000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + LDO2 {
> + regulator-name = "LDO2";
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <1150000>;
> regulator-boot-on;
> regulator-always-on;
> };
>
> LDO3 {
> regulator-name = "LDO3";
> - regulator-min-microvolt = <1710000>;
> - regulator-max-microvolt = <1890000>;
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo4: LDO4 {
> + regulator-name = "LDO4";
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> regulator-always-on;
> };
> --
> 2.37.1
>
>
>
next prev parent reply other threads:[~2022-10-20 11:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 9:59 [PATCH 00/15] arm64: dts: imx8m-evk: misc dts update Peng Fan (OSS)
2022-10-20 9:59 ` [PATCH 01/15] arm64: dts: imx8mp: add mlmix power domain Peng Fan (OSS)
2022-10-20 9:59 ` [PATCH 02/15] arm64: dts: imx8mp-evk: correct pcie pad settings Peng Fan (OSS)
2022-10-20 9:59 ` [PATCH 03/15] arm64: dts: imx8mp-evk: fix BUCK/LDO voltage Peng Fan (OSS)
2022-10-20 11:02 ` Marco Felsch [this message]
2022-10-21 9:13 ` Peng Fan
2022-10-21 9:44 ` Jacky Bai
2022-10-20 9:59 ` [PATCH 04/15] ARM64: dts: imx8mp-evk: add pwm support Peng Fan (OSS)
2022-10-20 11:04 ` Marco Felsch
2022-10-20 9:59 ` [PATCH 05/15] arm64: dts: imx8mp-evk: enable uart1/3 ports Peng Fan (OSS)
2022-10-20 11:07 ` Marco Felsch
2022-10-21 8:55 ` Peng Fan
2022-10-21 9:09 ` Marco Felsch
2022-10-21 9:31 ` Peng Fan
2022-10-21 9:53 ` Marco Felsch
2022-10-20 9:59 ` [PATCH 06/15] arm64: dts: imx8mp-evk: enable fspi nor on imx8mp evk Peng Fan (OSS)
2022-10-20 11:12 ` Marco Felsch
2022-10-20 9:59 ` [PATCH 07/15] arm64: dts: imx8mp-evk: enable I2C2 node Peng Fan (OSS)
2022-10-20 12:21 ` Marco Felsch
2022-10-20 9:59 ` [PATCH 08/15] arm64: dts: imx8mn-evk: update vdd_soc dvs voltage Peng Fan (OSS)
2022-10-20 9:59 ` [PATCH 09/15] arm64: dts: imx8mn-evk: set off-on-delay-us in regulator Peng Fan (OSS)
2022-10-20 9:59 ` [PATCH 10/15] arm64: dts: imx8mn-evk: add i2c gpio recovery settings Peng Fan (OSS)
2022-10-20 9:59 ` [PATCH 11/15] arm64: dts: imx8mn-evk: enable uart1 Peng Fan (OSS)
2022-10-20 9:59 ` [PATCH 12/15] arm64: dts: imx8mn-evk: enable usdhc1 Peng Fan (OSS)
2022-10-20 9:59 ` [PATCH 13/15] arm64: dts: imx8mm-evk: Enable usdhc1 to support wifi Peng Fan (OSS)
2022-10-20 9:59 ` [PATCH 14/15] arm64: dts: imx8m[m,p]-evk: change to use off-on-delay-us in regulator Peng Fan (OSS)
2022-10-20 14:13 ` [PATCH 14/15] arm64: dts: imx8m[m, p]-evk: " Marco Felsch
2022-10-20 9:59 ` [PATCH 15/15] arm64: dts: imx8mm-evk: add vcc supply for pca6416 Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020110257.5ojjq2j2c53hevnt@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).