From: Rob Herring <robh@kernel.org>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: linux-mmc@vger.kernel.org, ulf.hansson@linaro.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
jh80.chung@samsung.com, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCHv5 1/6] dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon"
Date: Thu, 20 Oct 2022 18:01:51 -0500 [thread overview]
Message-ID: <20221020230151.GA1957503-robh@kernel.org> (raw)
In-Reply-To: <166622207591.14373.6525811988033372211.robh@kernel.org>
On Wed, Oct 19, 2022 at 06:31:53PM -0500, Rob Herring wrote:
> On Wed, 19 Oct 2022 12:06:52 -0500, Dinh Nguyen wrote:
> > Document the optional "altr,sysmgr-syscon" binding that is used to
> > access the System Manager register that controls the SDMMC clock
> > phase.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> > ---
> > v5: document reg shift
> > v4: add else statement
> > v3: document that the "altr,sysmgr-syscon" binding is only applicable to
> > "altr,socfpga-dw-mshc"
> > v2: document "altr,sysmgr-syscon" in the MMC section
> > ---
> > .../bindings/mmc/synopsys-dw-mshc.yaml | 32 +++++++++++++++++--
> > 1 file changed, 29 insertions(+), 3 deletions(-)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> dwmmc0@ff704000: $nodename:0: 'dwmmc0@ff704000' does not match '^mmc(@.*)?$'
Not necessary for this series, but it would be nice if existing warnings
were fixed before adding new things. Especially since most of the
warnings on this common bindings are all socfpga. It may become
required at some point, not just nice.
The node name is the cause of most/all the unevaluated property
warnings.
> arch/arm/boot/dts/socfpga_arria5_socdk.dtb
> arch/arm/boot/dts/socfpga_cyclone5_chameleon96.dtb
> arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dtb
> arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dtb
> arch/arm/boot/dts/socfpga_cyclone5_socdk.dtb
> arch/arm/boot/dts/socfpga_cyclone5_sockit.dtb
> arch/arm/boot/dts/socfpga_cyclone5_socrates.dtb
> arch/arm/boot/dts/socfpga_cyclone5_sodia.dtb
> arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dtb
> arch/arm/boot/dts/socfpga_vt.dtb
>
> dwmmc0@ff704000: 'altr,sysmgr-syscon' is a required property
> arch/arm/boot/dts/socfpga_arria5_socdk.dtb
> arch/arm/boot/dts/socfpga_cyclone5_chameleon96.dtb
> arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dtb
> arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dtb
> arch/arm/boot/dts/socfpga_cyclone5_socdk.dtb
> arch/arm/boot/dts/socfpga_cyclone5_sockit.dtb
> arch/arm/boot/dts/socfpga_cyclone5_socrates.dtb
> arch/arm/boot/dts/socfpga_cyclone5_sodia.dtb
I thought it was optional? New required properties are a possible ABI
break.
Rob
next prev parent reply other threads:[~2022-10-20 23:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 17:06 [PATCHv5 0/6] arm: socfpga: use clk-phase-sd-hs Dinh Nguyen
2022-10-19 17:06 ` [PATCHv5 1/6] dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon" Dinh Nguyen
2022-10-19 23:31 ` Rob Herring
2022-10-20 23:01 ` Rob Herring [this message]
2022-10-20 18:20 ` Krzysztof Kozlowski
2022-10-19 17:06 ` [PATCHv5 2/6] arm64: dts: socfpga: Add clk-phase-sd-hs property to the sdmmc node Dinh Nguyen
2022-10-19 17:06 ` [PATCHv5 3/6] arm: " Dinh Nguyen
2022-10-19 17:06 ` [PATCHv5 4/6] mmc: dw_mmc-pltfm: socfpga: add method to configure clk-phase Dinh Nguyen
2022-10-21 13:32 ` Krzysztof Kozlowski
2022-10-21 15:17 ` Dinh Nguyen
2022-10-19 17:06 ` [PATCHv5 5/6] clk: socfpga: remove the setting of clk-phase for sdmmc_clk Dinh Nguyen
2022-10-19 17:06 ` [PATCHv5 6/6] arm: dts: socfpga: remove "clk-phase" in sdmmc_clk Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020230151.GA1957503-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).