From: Rob Herring <robh@kernel.org>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: ldewangan@nvidia.com, jonathanh@nvidia.com, vkoul@kernel.org,
thierry.reding@gmail.com, p.zabel@pengutronix.de,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, sfr@canb.auug.org.au
Subject: Re: [PATCH RESEND v2 2/3] arm64: tegra: Add dma-channel-mask in GPCDMA node
Date: Thu, 20 Oct 2022 21:18:25 -0500 [thread overview]
Message-ID: <20221021021825.GB2181729-robh@kernel.org> (raw)
In-Reply-To: <20221020083322.36431-3-akhilrajeev@nvidia.com>
On Thu, Oct 20, 2022 at 02:03:21PM +0530, Akhil R wrote:
> Add dma-channel-mask property in Tegra GPCDMA device tree node.
>
> The property would help to specify the channels to be used in
> kernel and reserve few for the firmware. This was previously
> achieved by limiting the channel number to 31 in the driver.
> Now since we can list all 32 channels, update the interrupts
> property as well to list all 32 interrupts.
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 4 +++-
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 4 +++-
> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 4 +++-
> 3 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> index 6602fe421ee8..db479064ff72 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> @@ -78,7 +78,8 @@
> reg = <0x0 0x2600000 0x0 0x210000>;
> resets = <&bpmp TEGRA186_RESET_GPCDMA>;
> reset-names = "gpcdma";
> - interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>,
> + interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>,
Adding an interrupt onto the beginning? Also an ABI issue.
If you want to break the ABI, you have to explain that you are and why
it is okay on that platform.
Rob
next prev parent reply other threads:[~2022-10-21 2:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 8:33 [PATCH RESEND v2 0/3] Tegra GCPDMA: Add dma-channel-mask support Akhil R
2022-10-20 8:33 ` [PATCH RESEND v2 1/3] dt-bindings: dmaengine: Add dma-channel-mask to Tegra GPCDMA Akhil R
2022-10-27 13:38 ` Krzysztof Kozlowski
2022-10-20 8:33 ` [PATCH RESEND v2 2/3] arm64: tegra: Add dma-channel-mask in GPCDMA node Akhil R
2022-10-21 2:18 ` Rob Herring [this message]
2022-10-20 8:33 ` [PATCH RESEND v2 3/3] dmaengine: tegra: Add support for dma-channel-mask Akhil R
2022-10-21 2:16 ` Rob Herring
2022-10-26 4:44 ` Akhil R
2022-10-26 9:30 ` Jon Hunter
2022-10-27 10:13 ` Akhil R
2022-11-01 11:40 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021021825.GB2181729-robh@kernel.org \
--to=robh@kernel.org \
--cc=akhilrajeev@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sfr@canb.auug.org.au \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).