devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6dl-yapp4: Do not allow PM to switch PU regulator off on Q/QP
@ 2022-10-04 15:39 Petr Benes
  2022-10-24  2:25 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Petr Benes @ 2022-10-04 15:39 UTC (permalink / raw)
  To: Rob Herring, Shawn Guo
  Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, Petr Benes, petrben,
	stable, Michal Vokáč

Fix our design flaw in supply voltage distribution on the Quad and QuadPlus
based boards.

The problem is that we supply the SoC cache (VDD_CACHE_CAP) from VDD_PU
instead of VDD_SOC. The VDD_PU internal regulator can be disabled by PM
if VPU or GPU is not used. If that happens the system freezes. To prevent
that configure the reg_pu regulator to be always on.

Fixes: 0de4ab81ab26 ("ARM: dts: imx6dl-yapp4: Add Y Soft IOTA Crux/Crux+ board")
Cc: petrben@gmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Petr Benes <petr.benes@ysoft.com>
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
 arch/arm/boot/dts/imx6q-yapp4-crux.dts       | 4 ++++
 arch/arm/boot/dts/imx6qp-yapp4-crux-plus.dts | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-yapp4-crux.dts b/arch/arm/boot/dts/imx6q-yapp4-crux.dts
index deb18c57cf18..22f647eb12e7 100644
--- a/arch/arm/boot/dts/imx6q-yapp4-crux.dts
+++ b/arch/arm/boot/dts/imx6q-yapp4-crux.dts
@@ -45,6 +45,10 @@ &oled_1309 {
 	status = "okay";
 };
 
+&reg_pu {
+	regulator-always-on;
+};
+
 &reg_usb_h1_vbus {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/imx6qp-yapp4-crux-plus.dts b/arch/arm/boot/dts/imx6qp-yapp4-crux-plus.dts
index a450a77f920f..b580ce891f7e 100644
--- a/arch/arm/boot/dts/imx6qp-yapp4-crux-plus.dts
+++ b/arch/arm/boot/dts/imx6qp-yapp4-crux-plus.dts
@@ -45,6 +45,10 @@ &oled_1309 {
 	status = "okay";
 };
 
+&reg_pu {
+	regulator-always-on;
+};
+
 &reg_usb_h1_vbus {
 	status = "okay";
 };
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: imx6dl-yapp4: Do not allow PM to switch PU regulator off on Q/QP
  2022-10-04 15:39 [PATCH] ARM: dts: imx6dl-yapp4: Do not allow PM to switch PU regulator off on Q/QP Petr Benes
@ 2022-10-24  2:25 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2022-10-24  2:25 UTC (permalink / raw)
  To: Petr Benes
  Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, petrben, stable,
	Michal Vokáč

On Tue, Oct 04, 2022 at 05:39:20PM +0200, Petr Benes wrote:
> Fix our design flaw in supply voltage distribution on the Quad and QuadPlus
> based boards.
> 
> The problem is that we supply the SoC cache (VDD_CACHE_CAP) from VDD_PU
> instead of VDD_SOC. The VDD_PU internal regulator can be disabled by PM
> if VPU or GPU is not used. If that happens the system freezes. To prevent
> that configure the reg_pu regulator to be always on.
> 
> Fixes: 0de4ab81ab26 ("ARM: dts: imx6dl-yapp4: Add Y Soft IOTA Crux/Crux+ board")
> Cc: petrben@gmail.com
> Cc: stable@vger.kernel.org
> Signed-off-by: Petr Benes <petr.benes@ysoft.com>
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-24  2:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-04 15:39 [PATCH] ARM: dts: imx6dl-yapp4: Do not allow PM to switch PU regulator off on Q/QP Petr Benes
2022-10-24  2:25 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).