devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 08/13] phy: qcom-qmp-usb: rename PHY ops structure
Date: Mon, 24 Oct 2022 12:06:27 +0200	[thread overview]
Message-ID: <20221024100632.20549-9-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221024100632.20549-1-johan+linaro@kernel.org>

Rename the PHY operation structure so that it has a "phy_ops" suffix and
move it next to the implementation.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index 2e603831e45e..4a7b961d2965 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
@@ -2149,6 +2149,13 @@ static int qmp_usb_set_mode(struct phy *phy, enum phy_mode mode, int submode)
 	return 0;
 }
 
+static const struct phy_ops qmp_usb_phy_ops = {
+	.init		= qmp_usb_enable,
+	.exit		= qmp_usb_disable,
+	.set_mode	= qmp_usb_set_mode,
+	.owner		= THIS_MODULE,
+};
+
 static void qmp_usb_enable_autonomous_mode(struct qmp_usb *qmp)
 {
 	const struct qmp_phy_cfg *cfg = qmp->cfg;
@@ -2366,13 +2373,6 @@ static int phy_pipe_clk_register(struct qmp_usb *qmp, struct device_node *np)
 	return devm_add_action_or_reset(qmp->dev, phy_clk_release_provider, np);
 }
 
-static const struct phy_ops qmp_usb_ops = {
-	.init		= qmp_usb_enable,
-	.exit		= qmp_usb_disable,
-	.set_mode	= qmp_usb_set_mode,
-	.owner		= THIS_MODULE,
-};
-
 static void __iomem *qmp_usb_iomap(struct device *dev, struct device_node *np,
 					int index, bool exclusive)
 {
@@ -2451,7 +2451,7 @@ static int qmp_usb_create(struct qmp_usb *qmp, struct device_node *np)
 				     "failed to get pipe clock\n");
 	}
 
-	generic_phy = devm_phy_create(dev, np, &qmp_usb_ops);
+	generic_phy = devm_phy_create(dev, np, &qmp_usb_phy_ops);
 	if (IS_ERR(generic_phy)) {
 		ret = PTR_ERR(generic_phy);
 		dev_err(dev, "failed to create PHY: %d\n", ret);
-- 
2.37.3


  parent reply	other threads:[~2022-10-24 10:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 10:06 [PATCH 00/13] phy: qcom-qmp-usb: fix sc8280xp binding Johan Hovold
2022-10-24 10:06 ` [PATCH 01/13] phy: qcom-qmp-usb: fix sc8280xp PCS_USB offset Johan Hovold
2022-10-24 13:32   ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 02/13] phy: qcom-qmp-usb: sort device-id table Johan Hovold
2022-10-24 13:33   ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 03/13] phy: qcom-qmp-usb: move " Johan Hovold
2022-10-24 13:33   ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 04/13] phy: qcom-qmp-usb: move pm ops Johan Hovold
2022-10-24 13:33   ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 05/13] phy: qcom-qmp-usb: merge driver data Johan Hovold
2022-10-24 13:33   ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 06/13] phy: qcom-qmp-usb: clean up device-tree parsing Johan Hovold
2022-10-24 13:34   ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 07/13] phy: qcom-qmp-usb: clean up probe initialisation Johan Hovold
2022-10-24 13:34   ` Dmitry Baryshkov
2022-10-24 10:06 ` Johan Hovold [this message]
2022-10-24 13:34   ` [PATCH 08/13] phy: qcom-qmp-usb: rename PHY ops structure Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 09/13] phy: qcom-qmp-usb: clean up PHY init Johan Hovold
2022-10-24 13:34   ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 10/13] dt-bindings: phy: qcom,qmp-usb: rename current bindings Johan Hovold
2022-10-28  2:12   ` Krzysztof Kozlowski
2022-10-24 10:06 ` [PATCH 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding Johan Hovold
2022-10-28  2:15   ` Krzysztof Kozlowski
2022-10-28  6:09     ` Johan Hovold
2022-10-28  6:13       ` Johan Hovold
2022-10-28 13:05       ` Vinod Koul
2022-10-24 10:06 ` [PATCH 12/13] phy: qcom-qmp-usb: restructure PHY creation Johan Hovold
2022-10-24 13:35   ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 13/13] phy: qcom-qmp-usb: add support for updated sc8280xp binding Johan Hovold
2022-10-24 13:35   ` Dmitry Baryshkov
2022-10-24 13:38     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221024100632.20549-9-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).