* [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc
@ 2022-10-24 11:54 Heiko Thiery
2022-10-24 11:57 ` Fabio Estevam
2022-10-24 12:26 ` Marco Felsch
0 siblings, 2 replies; 6+ messages in thread
From: Heiko Thiery @ 2022-10-24 11:54 UTC (permalink / raw)
To: devicetree, linux-arm-kernel, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Heiko Thiery
With that delay U-Boot is not able to store the environment variables in
the SD card. Since the delay is not required it can be remove.
Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
v3:
- Improve commit message and explain why it is a fix (thanks to Fabio)
v2:
- add Fixes tag
arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
index a91c136797f6..21442e04a632 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
@@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
- off-on-delay-us = <20000>;
enable-active-high;
};
};
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc
2022-10-24 11:54 [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc Heiko Thiery
@ 2022-10-24 11:57 ` Fabio Estevam
2022-10-24 12:26 ` Marco Felsch
1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2022-10-24 11:57 UTC (permalink / raw)
To: Heiko Thiery
Cc: devicetree, linux-arm-kernel, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team
Hi Heiko,
On Mon, Oct 24, 2022 at 8:54 AM Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> With that delay U-Boot is not able to store the environment variables in
> the SD card. Since the delay is not required it can be remove.
>
> Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)
>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v3:
> - Improve commit message and explain why it is a fix (thanks to Fabio)
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc
2022-10-24 11:54 [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc Heiko Thiery
2022-10-24 11:57 ` Fabio Estevam
@ 2022-10-24 12:26 ` Marco Felsch
2022-10-24 12:52 ` Heiko Thiery
1 sibling, 1 reply; 6+ messages in thread
From: Marco Felsch @ 2022-10-24 12:26 UTC (permalink / raw)
To: Heiko Thiery
Cc: devicetree, linux-arm-kernel, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Hi Heiko,
On 22-10-24, Heiko Thiery wrote:
> With that delay U-Boot is not able to store the environment variables in
> the SD card. Since the delay is not required it can be remove.
Now I'm curious, since this doesn't tell us the why, it just tell us
about the end result. I'm asking because the NXP EVKs have an issue with
the sd-card power line capacity and we need this delay to reach a level
which is marked as low within the sd-spec.
Regards,
Marco
> Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)
>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v3:
> - Improve commit message and explain why it is a fix (thanks to Fabio)
>
> v2:
> - add Fixes tag
>
> arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> index a91c136797f6..21442e04a632 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> @@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> - off-on-delay-us = <20000>;
> enable-active-high;
> };
> };
> --
> 2.30.2
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc
2022-10-24 12:26 ` Marco Felsch
@ 2022-10-24 12:52 ` Heiko Thiery
2022-10-24 12:56 ` Marco Felsch
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Thiery @ 2022-10-24 12:52 UTC (permalink / raw)
To: Marco Felsch
Cc: devicetree, linux-arm-kernel, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Hi Marco,
Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch
<m.felsch@pengutronix.de>:
>
> Hi Heiko,
>
> On 22-10-24, Heiko Thiery wrote:
> > With that delay U-Boot is not able to store the environment variables in
> > the SD card. Since the delay is not required it can be remove.
>
> Now I'm curious, since this doesn't tell us the why, it just tell us
> about the end result. I'm asking because the NXP EVKs have an issue with
> the sd-card power line capacity and we need this delay to reach a level
> which is marked as low within the sd-spec.
I must admit that I do not know at all why this entry was made. I have
now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts
I see no delay here.
--
Heiko
> Regards,
> Marco
>
>
> > Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)
> >
> > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> > ---
> > v3:
> > - Improve commit message and explain why it is a fix (thanks to Fabio)
> >
> > v2:
> > - add Fixes tag
> >
> > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > index a91c136797f6..21442e04a632 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > @@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> > regulator-min-microvolt = <3300000>;
> > regulator-max-microvolt = <3300000>;
> > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> > - off-on-delay-us = <20000>;
> > enable-active-high;
> > };
> > };
> > --
> > 2.30.2
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc
2022-10-24 12:52 ` Heiko Thiery
@ 2022-10-24 12:56 ` Marco Felsch
2022-10-24 13:07 ` Heiko Thiery
0 siblings, 1 reply; 6+ messages in thread
From: Marco Felsch @ 2022-10-24 12:56 UTC (permalink / raw)
To: Heiko Thiery
Cc: devicetree, linux-arm-kernel, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
On 22-10-24, Heiko Thiery wrote:
> Hi Marco,
>
> Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch
> <m.felsch@pengutronix.de>:
> >
> > Hi Heiko,
> >
> > On 22-10-24, Heiko Thiery wrote:
> > > With that delay U-Boot is not able to store the environment variables in
> > > the SD card. Since the delay is not required it can be remove.
> >
> > Now I'm curious, since this doesn't tell us the why, it just tell us
> > about the end result. I'm asking because the NXP EVKs have an issue with
> > the sd-card power line capacity and we need this delay to reach a level
> > which is marked as low within the sd-spec.
>
> I must admit that I do not know at all why this entry was made. I have
> now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts
> I see no delay here.
Please see <20221024031351.4135651-10-peng.fan@oss.nxp.com>, they will
be added.
Regards,
Marco
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc
2022-10-24 12:56 ` Marco Felsch
@ 2022-10-24 13:07 ` Heiko Thiery
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Thiery @ 2022-10-24 13:07 UTC (permalink / raw)
To: Marco Felsch
Cc: devicetree, linux-arm-kernel, linux-kernel, Rob Herring,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Hi Marco,
Am Mo., 24. Okt. 2022 um 14:58 Uhr schrieb Marco Felsch
<m.felsch@pengutronix.de>:
>
> On 22-10-24, Heiko Thiery wrote:
> > Hi Marco,
> >
> > Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch
> > <m.felsch@pengutronix.de>:
> > >
> > > Hi Heiko,
> > >
> > > On 22-10-24, Heiko Thiery wrote:
> > > > With that delay U-Boot is not able to store the environment variables in
> > > > the SD card. Since the delay is not required it can be remove.
> > >
> > > Now I'm curious, since this doesn't tell us the why, it just tell us
> > > about the end result. I'm asking because the NXP EVKs have an issue with
> > > the sd-card power line capacity and we need this delay to reach a level
> > > which is marked as low within the sd-spec.
> >
> > I must admit that I do not know at all why this entry was made. I have
> > now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts
> > I see no delay here.
>
> Please see <20221024031351.4135651-10-peng.fan@oss.nxp.com>, they will
> be added.
I think I have to re-check that and especially why U-Boot is not able
with that setting to access the SD card for writing the environment.
Thanks!
>
> Regards,
> Marco
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-24 21:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 11:54 [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc Heiko Thiery
2022-10-24 11:57 ` Fabio Estevam
2022-10-24 12:26 ` Marco Felsch
2022-10-24 12:52 ` Heiko Thiery
2022-10-24 12:56 ` Marco Felsch
2022-10-24 13:07 ` Heiko Thiery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).