[PATCH] dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum

[PATCH] dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum

[Matt Ranostay]

Several J7 platforms use adc_tsc_fck instead of fck for clock naming. To
avoid warnings from dt-schema on invalid clock naming; create an enum with
both fck, and adc_tsc_fck options.

Signed-off-by: Matt Ranostay <mranostay@ti.com>
---
 Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
index 34bf6a01436f..fbb44531ed88 100644
--- a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
@@ -28,7 +28,9 @@ properties:
     maxItems: 1
 
   clock-names:
-    const: fck
+    enum:
+      - fck
+      - adc_tsc_fck
 
   dmas:
     items:
-- 
2.38.GIT

Re: [PATCH] dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum

[Miquel Raynal]

Hi Matt,

mranostay@ti.com wrote on Mon, 24 Oct 2022 03:07:06 -0700:

> Several J7 platforms use adc_tsc_fck instead of fck for clock naming. To
> avoid warnings from dt-schema on invalid clock naming; create an enum with
> both fck, and adc_tsc_fck options.

Looks like I've missed this definition when introducing the bindings.
But in practice this property looks very k3 specific and is not used
anywhere else so would it be worth considering renaming the properties
in the DT instead? There won't be any backward compatibility issue
apparently.

> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
>  Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> index 34bf6a01436f..fbb44531ed88 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> @@ -28,7 +28,9 @@ properties:
>      maxItems: 1
>  
>    clock-names:
> -    const: fck
> +    enum:
> +      - fck
> +      - adc_tsc_fck
>  
>    dmas:
>      items:


Thanks,
Miquèl

Re: [PATCH] dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum

[Matt Ranostay]

On Mon, Oct 24, 2022 at 01:34:20PM +0200, Miquel Raynal wrote:
> Hi Matt,
> 
> mranostay@ti.com wrote on Mon, 24 Oct 2022 03:07:06 -0700:
> 
> > Several J7 platforms use adc_tsc_fck instead of fck for clock naming. To
> > avoid warnings from dt-schema on invalid clock naming; create an enum with
> > both fck, and adc_tsc_fck options.
> 
> Looks like I've missed this definition when introducing the bindings.
> But in practice this property looks very k3 specific and is not used
> anywhere else so would it be worth considering renaming the properties
> in the DT instead? There won't be any backward compatibility issue
> apparently.
>

That should work as well, and probably is a better solution.
I'll send a patchset in the near future with those changes.

- Matt


> > Signed-off-by: Matt Ranostay <mranostay@ti.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> > index 34bf6a01436f..fbb44531ed88 100644
> > --- a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> > @@ -28,7 +28,9 @@ properties:
> >      maxItems: 1
> >  
> >    clock-names:
> > -    const: fck
> > +    enum:
> > +      - fck
> > +      - adc_tsc_fck
> >  
> >    dmas:
> >      items:
> 
> 
> Thanks,
> Miquèl