* [PATCH] dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum
@ 2022-10-24 10:07 Matt Ranostay
2022-10-24 11:34 ` Miquel Raynal
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2022-10-24 10:07 UTC (permalink / raw)
To: lee, robh+dt, krzysztof.kozlowski+dt, miquel.raynal
Cc: devicetree, Matt Ranostay
Several J7 platforms use adc_tsc_fck instead of fck for clock naming. To
avoid warnings from dt-schema on invalid clock naming; create an enum with
both fck, and adc_tsc_fck options.
Signed-off-by: Matt Ranostay <mranostay@ti.com>
---
Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
index 34bf6a01436f..fbb44531ed88 100644
--- a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
@@ -28,7 +28,9 @@ properties:
maxItems: 1
clock-names:
- const: fck
+ enum:
+ - fck
+ - adc_tsc_fck
dmas:
items:
--
2.38.GIT
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum
2022-10-24 10:07 [PATCH] dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum Matt Ranostay
@ 2022-10-24 11:34 ` Miquel Raynal
2022-10-24 12:36 ` Matt Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: Miquel Raynal @ 2022-10-24 11:34 UTC (permalink / raw)
To: Matt Ranostay; +Cc: lee, robh+dt, krzysztof.kozlowski+dt, devicetree
Hi Matt,
mranostay@ti.com wrote on Mon, 24 Oct 2022 03:07:06 -0700:
> Several J7 platforms use adc_tsc_fck instead of fck for clock naming. To
> avoid warnings from dt-schema on invalid clock naming; create an enum with
> both fck, and adc_tsc_fck options.
Looks like I've missed this definition when introducing the bindings.
But in practice this property looks very k3 specific and is not used
anywhere else so would it be worth considering renaming the properties
in the DT instead? There won't be any backward compatibility issue
apparently.
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
> Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> index 34bf6a01436f..fbb44531ed88 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> @@ -28,7 +28,9 @@ properties:
> maxItems: 1
>
> clock-names:
> - const: fck
> + enum:
> + - fck
> + - adc_tsc_fck
>
> dmas:
> items:
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum
2022-10-24 11:34 ` Miquel Raynal
@ 2022-10-24 12:36 ` Matt Ranostay
0 siblings, 0 replies; 3+ messages in thread
From: Matt Ranostay @ 2022-10-24 12:36 UTC (permalink / raw)
To: Miquel Raynal; +Cc: lee, robh+dt, krzysztof.kozlowski+dt, devicetree
On Mon, Oct 24, 2022 at 01:34:20PM +0200, Miquel Raynal wrote:
> Hi Matt,
>
> mranostay@ti.com wrote on Mon, 24 Oct 2022 03:07:06 -0700:
>
> > Several J7 platforms use adc_tsc_fck instead of fck for clock naming. To
> > avoid warnings from dt-schema on invalid clock naming; create an enum with
> > both fck, and adc_tsc_fck options.
>
> Looks like I've missed this definition when introducing the bindings.
> But in practice this property looks very k3 specific and is not used
> anywhere else so would it be worth considering renaming the properties
> in the DT instead? There won't be any backward compatibility issue
> apparently.
>
That should work as well, and probably is a better solution.
I'll send a patchset in the near future with those changes.
- Matt
> > Signed-off-by: Matt Ranostay <mranostay@ti.com>
> > ---
> > Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> > index 34bf6a01436f..fbb44531ed88 100644
> > --- a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> > @@ -28,7 +28,9 @@ properties:
> > maxItems: 1
> >
> > clock-names:
> > - const: fck
> > + enum:
> > + - fck
> > + - adc_tsc_fck
> >
> > dmas:
> > items:
>
>
> Thanks,
> Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-24 13:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 10:07 [PATCH] dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum Matt Ranostay
2022-10-24 11:34 ` Miquel Raynal
2022-10-24 12:36 ` Matt Ranostay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).