From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com, Derek Fang <derek.fang@realtek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies
Date: Mon, 24 Oct 2022 11:06:49 -0400 [thread overview]
Message-ID: <20221024150649.wbd54lcvgrj4kxgu@notapiano> (raw)
In-Reply-To: <ae460461-5c20-9180-456c-8c01a4b1a7f1@linaro.org>
On Sat, Oct 22, 2022 at 12:39:56PM -0400, Krzysztof Kozlowski wrote:
> On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote:
> > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties
> > for them.
> >
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > ---
> >
> > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> > index ea53a55015c4..ca1037e76f96 100644
> > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> > @@ -90,6 +90,10 @@ properties:
> > "#sound-dai-cells":
> > const: 0
> >
> > + AVDD-supply: true
> > +
> > + MICVDD-supply: true
> > +
>
> How about keeping some order in the list of properties?
The current properties don't seem to follow any particular order and keeping the
supplies grouped together seemed reasonable. What ordering do you suggest?
Thanks,
Nícolas
next prev parent reply other threads:[~2022-10-24 16:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 19:09 [PATCH 0/3] Add missing dt-binding properties to rt5682(s) Nícolas F. R. A. Prado
2022-10-21 19:09 ` [PATCH 1/3] ASoC: dt-bindings: realtek,rt5682s: Add #sound-dai-cells Nícolas F. R. A. Prado
2022-10-21 19:16 ` David Heidelberg
2022-10-22 16:38 ` Krzysztof Kozlowski
2022-10-21 19:09 ` [PATCH 2/3] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
2022-10-21 19:17 ` David Heidelberg
2022-10-22 16:39 ` Krzysztof Kozlowski
2022-10-24 15:06 ` Nícolas F. R. A. Prado [this message]
2022-10-24 16:26 ` Krzysztof Kozlowski
2022-10-22 16:40 ` Krzysztof Kozlowski
2022-10-21 19:09 ` [PATCH 3/3] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
2022-10-22 16:41 ` Krzysztof Kozlowski
2022-10-24 16:00 ` Nícolas F. R. A. Prado
2022-10-24 16:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024150649.wbd54lcvgrj4kxgu@notapiano \
--to=nfraprado@collabora.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox