From: Rob Herring <robh@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-watchdog@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
linux-kernel@vger.kernel.org, wim@linux-watchdog.org,
linux@roeck-us.net, andrew@aj.id.au, joel@jms.id.au,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: watchdog: aspeed: Document aspeed,pre-timeout-irq-us
Date: Mon, 24 Oct 2022 13:44:23 -0500 [thread overview]
Message-ID: <20221024184423.GA2023764-robh@kernel.org> (raw)
In-Reply-To: <20221021151559.781983-3-eajames@linux.ibm.com>
On Fri, Oct 21, 2022 at 10:15:59AM -0500, Eddie James wrote:
> Document this new property for the pre-timeout interrupt.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> index a8197632d6d2..81d2c35ca7e3 100644
> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> @@ -40,12 +40,17 @@ Optional properties:
> specified no external signal is sent.
> - aspeed,ext-pulse-duration: External signal pulse duration in microseconds
>
> -Optional properties for AST2500-compatible watchdogs:
> +Optional properties for AST2500 and AST2600 compatible watchdogs:
> - aspeed,ext-push-pull: If aspeed,external-signal is present, set the pin's
> drive type to push-pull. The default is open-drain.
> - aspeed,ext-active-high: If aspeed,external-signal is present and and the pin
> is configured as push-pull, then set the pulse
> polarity to active-high. The default is active-low.
> + - aspeed,pre-timeout-irq-us: If aspeed,pre-timeout-irq-us is non-zero, the
> + pre-timeout interrupt will be enabled for the
> + watchdog. The interrupt will fire the specified
> + number of microseconds before the watchdog expires
> + and trigger a kernel panic.
A pre-timeout interrupt is fairly common. Come up with a common property
please. You'll need to be clear if the time is from wdog restart or time
before final timeout.
Rob
next prev parent reply other threads:[~2022-10-24 20:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 15:15 [PATCH 0/2] watchdog: aspeed: Add pre-timeout interrupt support Eddie James
2022-10-21 15:15 ` [PATCH 1/2] " Eddie James
2022-10-21 16:56 ` Guenter Roeck
2022-10-21 19:39 ` Eddie James
2022-10-22 4:00 ` Guenter Roeck
2022-11-01 20:54 ` Eddie James
2022-10-21 15:15 ` [PATCH 2/2] dt-bindings: watchdog: aspeed: Document aspeed,pre-timeout-irq-us Eddie James
2022-10-22 16:20 ` Krzysztof Kozlowski
2022-10-24 18:44 ` Rob Herring [this message]
2022-10-24 19:03 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024184423.GA2023764-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).