From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2 v1] usb: phy: phy-gpio-vbus-usb: Add devicetree bindings
Date: Mon, 24 Oct 2022 14:16:35 -0500 [thread overview]
Message-ID: <20221024191635.GA2060090-robh@kernel.org> (raw)
In-Reply-To: <20221022121149.3329641-1-linus.walleij@linaro.org>
On Sat, Oct 22, 2022 at 02:11:48PM +0200, Linus Walleij wrote:
> This adds a simple device tree binding for a GPIO-based
> VBUS detection PHY.
>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../bindings/phy/phy-usb-vbus-gpio.yaml | 47 +++++++++++++++++++
> 1 file changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/phy-usb-vbus-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-usb-vbus-gpio.yaml b/Documentation/devicetree/bindings/phy/phy-usb-vbus-gpio.yaml
> new file mode 100644
> index 000000000000..4e10b58f8235
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/phy-usb-vbus-gpio.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/phy-usb-vbus-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO-based VBUS detection USB PHY
> +
> +maintainers:
> + - Linus Walleij <linus.walleij@linaro.org>
> +
> +description: A VBUS event occurs when a USB plug is attached to
> + a USB host and peripheral, the voltage (VBUS) is exposed from the
> + host to the peripheral when the last of the two ends of the
> + cable is plugged in. This can be either on the host side or on
> + the peripheral side, whichever comes last. It is possible to
> + provide a very simple USB VBUS detection mechanism by using a
> + GPIO line that will trigger on an edge event on the VBUS
> + pin.
We already have Vbus GPIOs in the USB connector binding and there is
also the usb-nop-transceiver. Surely one of those works for you?
Preferably the former.
Rob
prev parent reply other threads:[~2022-10-24 21:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 12:11 [PATCH 1/2 v1] usb: phy: phy-gpio-vbus-usb: Add devicetree bindings Linus Walleij
2022-10-24 19:16 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024191635.GA2060090-robh@kernel.org \
--to=robh@kernel.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).