* [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1
@ 2022-10-24 23:38 Christian Marangi
2022-11-06 8:01 ` Brian Norris
2022-11-07 3:11 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Christian Marangi @ 2022-10-24 23:38 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Christian Marangi, Hendrik Koerner
It was reported non working mmc with this option enabled.
Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't
be run at 1.8v.
Disable it to restore correct functionality of this SoC feature.
Tested-by: Hendrik Koerner <koerhen@web.de>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
arch/arm/boot/dts/qcom-ipq8064.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
index 90c08b51680a..01ff24560ee6 100644
--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
@@ -756,7 +756,6 @@ sdcc1: mmc@12400000 {
non-removable;
cap-sd-highspeed;
cap-mmc-highspeed;
- mmc-ddr-1_8v;
vmmc-supply = <&vsdcc_fixed>;
dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
dma-names = "tx", "rx";
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1
2022-10-24 23:38 [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1 Christian Marangi
@ 2022-11-06 8:01 ` Brian Norris
2022-11-07 3:11 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2022-11-06 8:01 UTC (permalink / raw)
To: Christian Marangi
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
Hendrik Koerner
On Tue, Oct 25, 2022 at 01:38:17AM +0200, Christian Marangi wrote:
> It was reported non working mmc with this option enabled.
> Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't
> be run at 1.8v.
> Disable it to restore correct functionality of this SoC feature.
>
> Tested-by: Hendrik Koerner <koerhen@web.de>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Perhaps there's some board where this property makes sense, but it seems
like something that should be added when needed in the leaf DTS, and not
supplied in the base DTSI. So:
Reviewed-by: Brian Norris <computersforpeace@gmail.com>
This also fixes problems I've seen on my systems, so:
Tested-by: Brian Norris <computersforpeace@gmail.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1
2022-10-24 23:38 [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1 Christian Marangi
2022-11-06 8:01 ` Brian Norris
@ 2022-11-07 3:11 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-11-07 3:11 UTC (permalink / raw)
To: krzysztof.kozlowski+dt, devicetree, Rob Herring, linux-arm-msm,
Christian Marangi, konrad.dybcio, linux-kernel, Andy Gross
Cc: koerhen
On Tue, 25 Oct 2022 01:38:17 +0200, Christian Marangi wrote:
> It was reported non working mmc with this option enabled.
> Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't
> be run at 1.8v.
> Disable it to restore correct functionality of this SoC feature.
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1
commit: c9713e4ede1e5d044b64fe4d3cbb84223625637f
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-07 3:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 23:38 [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1 Christian Marangi
2022-11-06 8:01 ` Brian Norris
2022-11-07 3:11 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).