[PATCH 0/4] RK3588 Audio Support

[PATCH 0/4] RK3588 Audio Support

[Nicolas Frattaroli]

This patchset refactors the Rockchip I2S/TDM driver in order to
support the RK3588 SoC, and then adds the necessary compatible
string to load the driver for it.

Patch 1 rectifies a problem with the bindings where we were too
strict about requiring the rockchip,grf property. Most features
of this audio device don't need access to the GRF to function.

Patch 2 modifies the driver to adjust its behaviour to what the
changed bindings now allow, namely using most things without the
GRF.

Patch 3 and 4 are boring compatible string stuff that enables
RK3588 support. No special data is needed to initialise the
driver for this instance of the I2S/TDM IP.

Nicolas Frattaroli (4):
  ASoC: dt-bindings: rockchip: i2s-tdm: Make grf property optional
  ASoC: rockchip: i2s_tdm: Make the grf property optional
  ASoC: dt-bindings: rockchip: i2s-tdm: Add RK3588 compatible
  ASoC: rockchip: i2s_tdm: Add support for RK3588

 .../bindings/sound/rockchip,i2s-tdm.yaml      |  2 +-
 sound/soc/rockchip/rockchip_i2s_tdm.c         | 19 ++++++++++++++-----
 2 files changed, 15 insertions(+), 6 deletions(-)

-- 
2.38.1

[PATCH 1/4] ASoC: dt-bindings: rockchip: i2s-tdm: Make grf property optional

[Nicolas Frattaroli]

Turns out most things don't require the GRF, so making the property
optional is the obvious move.

Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
---
 Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
index 6a7c004bef17..8646cdc692d7 100644
--- a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
+++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
@@ -135,7 +135,6 @@ required:
   - clock-names
   - resets
   - reset-names
-  - rockchip,grf
   - "#sound-dai-cells"
 
 additionalProperties: false
-- 
2.38.1

Re: [PATCH 1/4] ASoC: dt-bindings: rockchip: i2s-tdm: Make grf property optional

[Krzysztof Kozlowski]

On 25/10/2022 08:41, Nicolas Frattaroli wrote:
> Turns out most things don't require the GRF, so making the property
> optional is the obvious move.
> 
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 3/4] ASoC: dt-bindings: rockchip: i2s-tdm: Add RK3588 compatible

[Nicolas Frattaroli]

This adds the compatible string for the RK3588 SoC.

Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
---
 Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
index 8646cdc692d7..0503f4f3fb1a 100644
--- a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
+++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
@@ -21,6 +21,7 @@ properties:
       - rockchip,rk1808-i2s-tdm
       - rockchip,rk3308-i2s-tdm
       - rockchip,rk3568-i2s-tdm
+      - rockchip,rk3588-i2s-tdm
       - rockchip,rv1126-i2s-tdm
 
   reg:
-- 
2.38.1

Re: [PATCH 3/4] ASoC: dt-bindings: rockchip: i2s-tdm: Add RK3588 compatible

[Krzysztof Kozlowski]

On 25/10/2022 08:41, Nicolas Frattaroli wrote:
> This adds the compatible string for the RK3588 SoC.
> 
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 0/4] RK3588 Audio Support

[Mark Brown]

On Tue, 25 Oct 2022 14:41:28 +0200, Nicolas Frattaroli wrote:
> This patchset refactors the Rockchip I2S/TDM driver in order to
> support the RK3588 SoC, and then adds the necessary compatible
> string to load the driver for it.
> 
> Patch 1 rectifies a problem with the bindings where we were too
> strict about requiring the rockchip,grf property. Most features
> of this audio device don't need access to the GRF to function.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: dt-bindings: rockchip: i2s-tdm: Make grf property optional
      commit: 1024a5b29e90a18530588b3f161e81cf3fae7dcf
[2/4] ASoC: rockchip: i2s_tdm: Make the grf property optional
      commit: d980004e349049a3fcbffc6096d14896f6a122ed
[3/4] ASoC: dt-bindings: rockchip: i2s-tdm: Add RK3588 compatible
      commit: 0643fd3669f5c33bab5b05a813459a2d00a83465
[4/4] ASoC: rockchip: i2s_tdm: Add support for RK3588
      commit: c619bd4268ff9895760dab303b4eb15ed3d0f7e9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark