From: Horatiu Vultur - M31836 <Horatiu.Vultur@microchip.com>
To: Claudiu Beznea - M18063 <Claudiu.Beznea@microchip.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
Nicolas Ferre - M43238 <Nicolas.Ferre@microchip.com>,
UNGLinuxDriver <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH] ARM: dts: lan966x: Enable sgpio on pcb8291
Date: Wed, 26 Oct 2022 19:38:13 +0200 [thread overview]
Message-ID: <20221026173813.wdpueueziirxdgq5@soft-dev3-1> (raw)
In-Reply-To: <fb12f594-5d71-dc35-c37e-b357e51b6b3c@microchip.com>
The 10/26/2022 07:47, Claudiu Beznea - M18063 wrote:
> Hi, Horatiu,
Hi Claudiu,
>
> On 19.10.2022 10:51, Horatiu Vultur wrote:
> > Enable sgpio node on pcb8291 as this is needed to be able to control
> > the LEDs on this board. Otherwise the LEDs support on the board will
> > not be available.
>
> Do we need a fixes tag for this?
I was not 100% sure that I need to add the tag, but I will send
another version where I will add the tag.
>
> > On the other board pcb8309 the sgpio is already enabled because it
> > needed to access the SFP ports.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > arch/arm/boot/dts/lan966x-pcb8291.dts | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > index f4f054cdf2a87..3a3d76af86122 100644
> > --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> > +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > @@ -69,6 +69,12 @@ can0_b_pins: can0-b-pins {
> > pins = "GPIO_35", "GPIO_36";
> > function = "can0_b";
> > };
> > +
> > + sgpio_a_pins: sgpio-a-pins {
> > + /* SCK, D0, D1, LD */
> > + pins = "GPIO_32", "GPIO_33", "GPIO_34", "GPIO_35";
> > + function = "sgpio_a";
> > + };
> > };
> >
> > &can0 {
> > @@ -118,6 +124,20 @@ &serdes {
> > status = "okay";
> > };
> >
> > +&sgpio {
> > + pinctrl-0 = <&sgpio_a_pins>;
> > + pinctrl-names = "default";
> > + microchip,sgpio-port-ranges = <0 3>, <8 11>;
> > + status = "okay";
> > +
> > + gpio@0 {
> > + ngpios = <64>;
> > + };
> > + gpio@1 {
> > + ngpios = <64>;
> > + };
> > +};
> > +
> > &switch {
> > status = "okay";
> > };
>
--
/Horatiu
prev parent reply other threads:[~2022-10-26 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 7:51 [PATCH] ARM: dts: lan966x: Enable sgpio on pcb8291 Horatiu Vultur
2022-10-26 7:47 ` Claudiu.Beznea
2022-10-26 17:38 ` Horatiu Vultur - M31836 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026173813.wdpueueziirxdgq5@soft-dev3-1 \
--to=horatiu.vultur@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).