* [PATCH] ARM: dts: lan966x: Enable sgpio on pcb8291
@ 2022-10-19 7:51 Horatiu Vultur
2022-10-26 7:47 ` Claudiu.Beznea
0 siblings, 1 reply; 3+ messages in thread
From: Horatiu Vultur @ 2022-10-19 7:51 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, claudiu.beznea, nicolas.ferre,
UNGLinuxDriver, Horatiu Vultur
Enable sgpio node on pcb8291 as this is needed to be able to control
the LEDs on this board. Otherwise the LEDs support on the board will
not be available.
On the other board pcb8309 the sgpio is already enabled because it
needed to access the SFP ports.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
arch/arm/boot/dts/lan966x-pcb8291.dts | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
index f4f054cdf2a87..3a3d76af86122 100644
--- a/arch/arm/boot/dts/lan966x-pcb8291.dts
+++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
@@ -69,6 +69,12 @@ can0_b_pins: can0-b-pins {
pins = "GPIO_35", "GPIO_36";
function = "can0_b";
};
+
+ sgpio_a_pins: sgpio-a-pins {
+ /* SCK, D0, D1, LD */
+ pins = "GPIO_32", "GPIO_33", "GPIO_34", "GPIO_35";
+ function = "sgpio_a";
+ };
};
&can0 {
@@ -118,6 +124,20 @@ &serdes {
status = "okay";
};
+&sgpio {
+ pinctrl-0 = <&sgpio_a_pins>;
+ pinctrl-names = "default";
+ microchip,sgpio-port-ranges = <0 3>, <8 11>;
+ status = "okay";
+
+ gpio@0 {
+ ngpios = <64>;
+ };
+ gpio@1 {
+ ngpios = <64>;
+ };
+};
+
&switch {
status = "okay";
};
--
2.38.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Enable sgpio on pcb8291
2022-10-19 7:51 [PATCH] ARM: dts: lan966x: Enable sgpio on pcb8291 Horatiu Vultur
@ 2022-10-26 7:47 ` Claudiu.Beznea
2022-10-26 17:38 ` Horatiu Vultur - M31836
0 siblings, 1 reply; 3+ messages in thread
From: Claudiu.Beznea @ 2022-10-26 7:47 UTC (permalink / raw)
To: Horatiu.Vultur, devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, Nicolas.Ferre, UNGLinuxDriver
Hi, Horatiu,
On 19.10.2022 10:51, Horatiu Vultur wrote:
> Enable sgpio node on pcb8291 as this is needed to be able to control
> the LEDs on this board. Otherwise the LEDs support on the board will
> not be available.
Do we need a fixes tag for this?
> On the other board pcb8309 the sgpio is already enabled because it
> needed to access the SFP ports.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> arch/arm/boot/dts/lan966x-pcb8291.dts | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index f4f054cdf2a87..3a3d76af86122 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -69,6 +69,12 @@ can0_b_pins: can0-b-pins {
> pins = "GPIO_35", "GPIO_36";
> function = "can0_b";
> };
> +
> + sgpio_a_pins: sgpio-a-pins {
> + /* SCK, D0, D1, LD */
> + pins = "GPIO_32", "GPIO_33", "GPIO_34", "GPIO_35";
> + function = "sgpio_a";
> + };
> };
>
> &can0 {
> @@ -118,6 +124,20 @@ &serdes {
> status = "okay";
> };
>
> +&sgpio {
> + pinctrl-0 = <&sgpio_a_pins>;
> + pinctrl-names = "default";
> + microchip,sgpio-port-ranges = <0 3>, <8 11>;
> + status = "okay";
> +
> + gpio@0 {
> + ngpios = <64>;
> + };
> + gpio@1 {
> + ngpios = <64>;
> + };
> +};
> +
> &switch {
> status = "okay";
> };
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Enable sgpio on pcb8291
2022-10-26 7:47 ` Claudiu.Beznea
@ 2022-10-26 17:38 ` Horatiu Vultur - M31836
0 siblings, 0 replies; 3+ messages in thread
From: Horatiu Vultur - M31836 @ 2022-10-26 17:38 UTC (permalink / raw)
To: Claudiu Beznea - M18063
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Nicolas Ferre - M43238, UNGLinuxDriver
The 10/26/2022 07:47, Claudiu Beznea - M18063 wrote:
> Hi, Horatiu,
Hi Claudiu,
>
> On 19.10.2022 10:51, Horatiu Vultur wrote:
> > Enable sgpio node on pcb8291 as this is needed to be able to control
> > the LEDs on this board. Otherwise the LEDs support on the board will
> > not be available.
>
> Do we need a fixes tag for this?
I was not 100% sure that I need to add the tag, but I will send
another version where I will add the tag.
>
> > On the other board pcb8309 the sgpio is already enabled because it
> > needed to access the SFP ports.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > arch/arm/boot/dts/lan966x-pcb8291.dts | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > index f4f054cdf2a87..3a3d76af86122 100644
> > --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> > +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > @@ -69,6 +69,12 @@ can0_b_pins: can0-b-pins {
> > pins = "GPIO_35", "GPIO_36";
> > function = "can0_b";
> > };
> > +
> > + sgpio_a_pins: sgpio-a-pins {
> > + /* SCK, D0, D1, LD */
> > + pins = "GPIO_32", "GPIO_33", "GPIO_34", "GPIO_35";
> > + function = "sgpio_a";
> > + };
> > };
> >
> > &can0 {
> > @@ -118,6 +124,20 @@ &serdes {
> > status = "okay";
> > };
> >
> > +&sgpio {
> > + pinctrl-0 = <&sgpio_a_pins>;
> > + pinctrl-names = "default";
> > + microchip,sgpio-port-ranges = <0 3>, <8 11>;
> > + status = "okay";
> > +
> > + gpio@0 {
> > + ngpios = <64>;
> > + };
> > + gpio@1 {
> > + ngpios = <64>;
> > + };
> > +};
> > +
> > &switch {
> > status = "okay";
> > };
>
--
/Horatiu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-26 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-19 7:51 [PATCH] ARM: dts: lan966x: Enable sgpio on pcb8291 Horatiu Vultur
2022-10-26 7:47 ` Claudiu.Beznea
2022-10-26 17:38 ` Horatiu Vultur - M31836
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).