From: Rob Herring <robh@kernel.org>
To: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
krzysztof.kozlowski+dt@linaro.org, marex@denx.de,
jirislaby@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] dt_bindings: rs485: Add binding for GPIO that controls Rx enable during Tx
Date: Wed, 26 Oct 2022 15:59:14 -0500 [thread overview]
Message-ID: <20221026205914.GA1294440-robh@kernel.org> (raw)
In-Reply-To: <20221026165049.9541-2-cniedermaier@dh-electronics.com>
On Wed, Oct 26, 2022 at 06:50:46PM +0200, Christoph Niedermaier wrote:
> Add the binding for a generic definition of a GPIO, that controls whether Rx
> is connected or disconnected by an electrical circuit to have the ability
> to receive the signals on the bus during sending or disable receiving during
> sending.
>
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> ---
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Marek Vasut <marex@denx.de>
> Cc: devicetree@vger.kernel.org
> To: linux-serial@vger.kernel.org
> To: linux-arm-kernel@lists.infradead.org
> ---
> Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml
> index 90a1bab40f05..0ebd7690f85d 100644
> --- a/Documentation/devicetree/bindings/serial/rs485.yaml
> +++ b/Documentation/devicetree/bindings/serial/rs485.yaml
> @@ -51,6 +51,10 @@ properties:
> description: GPIO pin to enable RS485 bus termination.
> maxItems: 1
>
> + rs485-rx-during-tx-gpios:
> + description: GPIO pin to control RS485 Rx enable during Tx.
Active state means do what? And inactive? This is an output gating the
RX signal or an input telling the receiver what to do during tx? The
description is not adequate.
How does this property relate to 'rs485-rx-during-tx' Any combination of
the 2 being present or not is okay? If not, you need some constraints.
Rob
next prev parent reply other threads:[~2022-10-26 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221026165049.9541-1-cniedermaier@dh-electronics.com>
2022-10-26 16:50 ` [PATCH 1/4] dt_bindings: rs485: Add binding for GPIO that controls Rx enable during Tx Christoph Niedermaier
2022-10-26 20:59 ` Rob Herring [this message]
2022-10-27 12:06 ` Christoph Niedermaier
2022-10-28 6:20 ` Alexander Dahl
2022-10-28 8:27 ` Christoph Niedermaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026205914.GA1294440-robh@kernel.org \
--to=robh@kernel.org \
--cc=cniedermaier@dh-electronics.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).