From: Michael Walle <michael@walle.cc>
To: Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Heiko Thiery <heiko.thiery@gmail.com>,
Michael Walle <michael@walle.cc>
Subject: [PATCH] Revert "arm64: dts: ls1028a: sl28: use ocelot-8021q tagging by default"
Date: Thu, 27 Oct 2022 13:32:48 +0200 [thread overview]
Message-ID: <20221027113248.420216-1-michael@walle.cc> (raw)
This reverts commit be0b178c50c37a666d54f435da71cf9f008362a0.
This commit will break networking on the sl28 boards if the tagger is
not compiled into the kernel. If a non-default tagger is used, the
kernel doesn't do a request_module(). Fixing that is also not that
trivial because the tagger modules are loaded by ids, not by name.
Thus for now, just revert to the default tagger until that is fixed.
Fixes: be0b178c50c3 ("arm64: dts: ls1028a: sl28: use ocelot-8021q tagging by default")
Reported-by: Heiko Thiery <heiko.thiery@gmail.com>
Signed-off-by: Michael Walle <michael@walle.cc>
---
Vladimir, I'm not sure how to fix that one. Adding aliases to the tagger
modules? Something like "MODULE_ALIAS("dsa_tag-ocelot-8021q");" and then do
a request_module() in dsa_find_tagger_by_name(), too?
.../arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index 72429b37a8b4..771c50c7f50a 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -324,14 +324,6 @@ &lpuart1 {
status = "okay";
};
-&mscc_felix_port4 {
- dsa-tag-protocol = "ocelot-8021q";
-};
-
-&mscc_felix_port5 {
- dsa-tag-protocol = "ocelot-8021q";
-};
-
&usb0 {
status = "okay";
};
--
2.30.2
next reply other threads:[~2022-10-27 11:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 11:32 Michael Walle [this message]
2022-10-27 12:05 ` [PATCH] Revert "arm64: dts: ls1028a: sl28: use ocelot-8021q tagging by default" Vladimir Oltean
2022-10-27 12:27 ` Vladimir Oltean
2022-10-27 12:40 ` Vladimir Oltean
2022-10-27 13:00 ` Michael Walle
2022-10-27 13:54 ` Vladimir Oltean
2022-10-27 16:00 ` Michael Walle
2022-10-27 18:04 ` Vladimir Oltean
2022-10-27 19:10 ` Michael Walle
2022-10-27 20:36 ` Vladimir Oltean
2022-10-27 16:14 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027113248.420216-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=devicetree@vger.kernel.org \
--cc=heiko.thiery@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).