From: Stephen Boyd <sboyd@kernel.org>
To: Siarhei Volkau <lis8215@gmail.com>
Cc: Siarhei Volkau <lis8215@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Cercueil <paul@crapouillou.net>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v6 3/3] clk: Add Ingenic JZ4755 CGU driver
Date: Thu, 27 Oct 2022 14:57:14 -0700 [thread overview]
Message-ID: <20221027215716.77250C433D6@smtp.kernel.org> (raw)
In-Reply-To: <20221027192024.484320-4-lis8215@gmail.com>
Quoting Siarhei Volkau (2022-10-27 12:20:23)
> diff --git a/drivers/clk/ingenic/jz4755-cgu.c b/drivers/clk/ingenic/jz4755-cgu.c
> new file mode 100644
> index 000000000..d2eb3ae0c
> --- /dev/null
> +++ b/drivers/clk/ingenic/jz4755-cgu.c
> @@ -0,0 +1,346 @@
[...]
> +static void __init jz4755_cgu_init(struct device_node *np)
> +{
> + int retval;
> +
> + cgu = ingenic_cgu_new(jz4755_cgu_clocks,
> + ARRAY_SIZE(jz4755_cgu_clocks), np);
> + if (!cgu) {
> + pr_err("%s: failed to initialise CGU\n", __func__);
> + return;
> + }
> +
> + retval = ingenic_cgu_register_clocks(cgu);
> + if (retval)
> + pr_err("%s: failed to register CGU Clocks\n", __func__);
> +
> + ingenic_cgu_register_syscore_ops(cgu);
> +}
> +CLK_OF_DECLARE_DRIVER(jz4755_cgu, "ingenic,jz4755-cgu", jz4755_cgu_init);
Is there another driver that probes this device? CLK_OF_DECLARE_DRIVER()
is for the situation where we want to probe this device again with
another platform driver. Please add a comment indicating what that other
driver is.
next prev parent reply other threads:[~2022-10-27 21:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 19:20 [PATCH v6 0/3] Add Ingenic JZ4755 CGU driver Siarhei Volkau
2022-10-27 19:20 ` [PATCH v6 1/3] dt-bindings: ingenic: Add support for the JZ4755 CGU Siarhei Volkau
2022-10-27 21:51 ` Stephen Boyd
2022-10-27 19:20 ` [PATCH v6 2/3] dt-bindings: clock: Add Ingenic JZ4755 CGU header Siarhei Volkau
2022-10-27 21:51 ` Stephen Boyd
2022-10-27 19:20 ` [PATCH v6 3/3] clk: Add Ingenic JZ4755 CGU driver Siarhei Volkau
2022-10-27 20:24 ` Paul Cercueil
2022-10-27 21:57 ` Stephen Boyd [this message]
2022-10-28 4:39 ` Siarhei Volkau
2022-10-28 7:48 ` Paul Cercueil
2022-11-01 19:22 ` Stephen Boyd
2022-11-01 20:31 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027215716.77250C433D6@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lis8215@gmail.com \
--cc=mturquette@baylibre.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).