devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Bryan Brattlof <bb@ti.com>, Le Jin <le.jin@siemens.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	<linux-arm-kernel@lists.infradead.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Andrew Davis <afd@ti.com>
Subject: [PATCH 09/11] arm64: dts: ti: k3-am65: Enable PCIe nodes at the board level
Date: Fri, 28 Oct 2022 09:24:15 -0500	[thread overview]
Message-ID: <20221028142417.10642-10-afd@ti.com> (raw)
In-Reply-To: <20221028142417.10642-1-afd@ti.com>

PCIe nodes defined in the top-level AM65x SoC dtsi files are incomplete
and will not be functional unless they are extended with a SerDes PHY.
And usually only one of the two modes can be used at a time as they
share a SerDes link.

As the PHY and mode is only known at the board integration level, these
nodes should only be enabled when provided with this information.

Disable the PCIe nodes in the dtsi files and only enable the ones that
are actually pinned out on a given board.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 .../boot/dts/ti/k3-am65-iot2050-common.dtsi      | 13 +------------
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi         |  4 ++++
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts   | 16 ----------------
 3 files changed, 5 insertions(+), 28 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
index c431d670757ba..dd7c6aee8c613 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
@@ -632,15 +632,8 @@ dpi_out: endpoint {
 	};
 };
 
-&pcie0_rc {
-	status = "disabled";
-};
-
-&pcie0_ep {
-	status = "disabled";
-};
-
 &pcie1_rc {
+	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&minipcie_pins_default>;
 
@@ -650,10 +643,6 @@ &pcie1_rc {
 	reset-gpios = <&wkup_gpio0 27 GPIO_ACTIVE_HIGH>;
 };
 
-&pcie1_ep {
-	status = "disabled";
-};
-
 &mailbox0_cluster0 {
 	interrupts = <436>;
 
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 9cdde6e25e7de..9081c791a3123 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -720,6 +720,7 @@ pcie0_rc: pcie@5500000 {
 		interrupts = <GIC_SPI 340 IRQ_TYPE_EDGE_RISING>;
 		msi-map = <0x0 &gic_its 0x0 0x10000>;
 		device_type = "pci";
+		status = "disabled";
 	};
 
 	pcie0_ep: pcie-ep@5500000 {
@@ -733,6 +734,7 @@ pcie0_ep: pcie-ep@5500000 {
 		max-link-speed = <2>;
 		dma-coherent;
 		interrupts = <GIC_SPI 340 IRQ_TYPE_EDGE_RISING>;
+		status = "disabled";
 	};
 
 	pcie1_rc: pcie@5600000 {
@@ -753,6 +755,7 @@ pcie1_rc: pcie@5600000 {
 		interrupts = <GIC_SPI 355 IRQ_TYPE_EDGE_RISING>;
 		msi-map = <0x0 &gic_its 0x10000 0x10000>;
 		device_type = "pci";
+		status = "disabled";
 	};
 
 	pcie1_ep: pcie-ep@5600000 {
@@ -766,6 +769,7 @@ pcie1_ep: pcie-ep@5600000 {
 		max-link-speed = <2>;
 		dma-coherent;
 		interrupts = <GIC_SPI 355 IRQ_TYPE_EDGE_RISING>;
+		status = "disabled";
 	};
 
 	mcasp0: mcasp@2b00000 {
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index bf6a6fe3d7ba3..a61060c6bc198 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -415,22 +415,6 @@ &serdes1 {
 	status = "disabled";
 };
 
-&pcie0_rc {
-	status = "disabled";
-};
-
-&pcie0_ep {
-	status = "disabled";
-};
-
-&pcie1_rc {
-	status = "disabled";
-};
-
-&pcie1_ep {
-	status = "disabled";
-};
-
 &mailbox0_cluster0 {
 	interrupts = <436>;
 
-- 
2.37.3


  parent reply	other threads:[~2022-10-28 14:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 14:24 [PATCH 00/11] AM65x Disable Incomplete DT Nodes Andrew Davis
2022-10-28 14:24 ` [PATCH 01/11] arm64: dts: ti: k3-am65: Enable UART nodes at the board level Andrew Davis
2022-10-28 14:24 ` [PATCH 02/11] arm64: dts: ti: k3-am65: Enable I2C " Andrew Davis
2022-10-28 14:24 ` [PATCH 03/11] arm64: dts: ti: k3-am65: Enable SPI " Andrew Davis
2022-10-28 14:24 ` [PATCH 04/11] arm64: dts: ti: k3-am65: Enable EPWM " Andrew Davis
2022-10-28 14:24 ` [PATCH 05/11] arm64: dts: ti: k3-am65: Enable ECAP " Andrew Davis
2022-10-28 14:24 ` [PATCH 06/11] arm64: dts: ti: k3-am65: MDIO pinmux should belong to the MDIO node Andrew Davis
2022-10-28 14:24 ` [PATCH 07/11] arm64: dts: ti: k3-am65: Enable MDIO nodes at the board level Andrew Davis
2022-10-28 14:24 ` [PATCH 08/11] arm64: dts: ti: k3-am65: Enable MCAN " Andrew Davis
2022-10-28 14:24 ` Andrew Davis [this message]
2022-10-28 14:24 ` [PATCH 10/11] arm64: dts: ti: k3-am65: Enable Mailbox " Andrew Davis
2022-10-28 14:24 ` [PATCH 11/11] arm64: dts: ti: k3-am65: Enable McASP " Andrew Davis
2022-10-31 14:54 ` [PATCH 00/11] AM65x Disable Incomplete DT Nodes Bryan Brattlof
2022-11-03 13:20 ` Jan Kiszka
2022-11-04  2:57 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028142417.10642-10-afd@ti.com \
    --to=afd@ti.com \
    --cc=bb@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=le.jin@siemens.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).