From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A151FA3742 for ; Fri, 28 Oct 2022 13:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbiJ1NpD (ORCPT ); Fri, 28 Oct 2022 09:45:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231236AbiJ1Noz (ORCPT ); Fri, 28 Oct 2022 09:44:55 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65FCDB10; Fri, 28 Oct 2022 06:44:37 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 8247740008; Fri, 28 Oct 2022 13:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1666964675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+nLdRj+8OUj3qiwCvpQ1lxFy6TRepZB0071YCG29E8=; b=imB9yEPn61l8qq77msz4sIun2w4ZFowREgZ1KGLqw0HpfzW22oyTt8UIJ2iCq2LZ6EXWW7 DpQeM3QKho8/TuGAjFrbRvGAccykwijKa4vJks31PHn/hJBR7Ts3T7/OdsEgaNA/uYuMGy Z+ll5Rz10DhCAh0sqgUKTTqI+cE8aZu99SScC14NJLbppEeuvGjoOtRNBHR2f3M+eUxACz ytGKlDHk7FMU4vyVMSgMRs+XOW/sWEx3l5FBn4vVwHXWM6F/AraZcURVvStTSGOyA/g81A hPcqNRfLmGaBUfXuF6lalkjIfFS9kuTUAm8a1aHzQh9h4DBOyRakzco2dBRNlA== Date: Fri, 28 Oct 2022 15:44:31 +0200 From: Miquel Raynal To: Rob Herring Cc: Paolo Abeni , Robert Marko , Michael Walle , devicetree@vger.kernel.org, Jakub Kicinski , Thomas Petazzoni , "David S. Miller" , Russell King , Srinivas Kandagatla , Rob Herring , Maxime Chevallier , linux-kernel@vger.kernel.org, Marcin Wojtas , Eric Dumazet , Krzysztof Kozlowski , netdev@vger.kernel.org Subject: Re: [PATCH 2/5] dt-bindings: nvmem: add YAML schema for the ONIE tlv layout Message-ID: <20221028154431.0096ab70@xps-13> In-Reply-To: <166695949292.1076993.16137208250373047416.robh@kernel.org> References: <20221028092337.822840-1-miquel.raynal@bootlin.com> <20221028092337.822840-3-miquel.raynal@bootlin.com> <166695949292.1076993.16137208250373047416.robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob & Krzysztof, robh@kernel.org wrote on Fri, 28 Oct 2022 07:20:05 -0500: > On Fri, 28 Oct 2022 11:23:34 +0200, Miquel Raynal wrote: > > Add a schema for the ONIE tlv NVMEM layout that can be found on any ONIE > > compatible networking device. > >=20 > > Signed-off-by: Miquel Raynal > > --- > > .../nvmem/layouts/onie,tlv-layout.yaml | 96 +++++++++++++++++++ > > 1 file changed, 96 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/oni= e,tlv-layout.yaml > > =20 >=20 > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): >=20 > yamllint warnings/errors: >=20 > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/nvmem/layouts/onie,tlv-layout.example.d= tb:0:0: /example-0/onie: failed to match any schema with compatible: ['onie= ,tlv-layout', 'vendor,device'] Oh right, I wanted to ask about this under the three --- but I forgot. Here was my question: How do we make the checker happy with an example where the second compatible can be almost anything (any nvmem-compatible device) but the first one should be the layout? (this is currently what Michael's proposal uses). > doc reference errors (make refcheckdocs): >=20 > See https://patchwork.ozlabs.org/patch/ >=20 > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. >=20 > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: >=20 > pip3 install dtschema --upgrade >=20 > Please check and re-submit. >=20 Thanks, Miqu=C3=A8l