devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH RESEND v2 01/13] phy: qcom-qmp-usb: fix sc8280xp PCS_USB offset
Date: Fri, 28 Oct 2022 18:04:23 +0200	[thread overview]
Message-ID: <20221028160435.26948-2-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221028160435.26948-1-johan+linaro@kernel.org>

The PCS_USB register block lives at an offset of 0x1000 from the PCS
region on SC8280XP so add the missing offset to avoid corrupting
unrelated registers on runtime suspend.

Note that the current binding is broken as it does not describe the
PCS_USB region and the PCS register size does not cover PCS_USB and the
regions in between. As Linux currently maps full pages, simply adding
the offset to driver works until the binding has been fixed.

Fixes: c0c7769cdae2 ("phy: qcom-qmp: Add SC8280XP USB3 UNI phy")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index d0c433197080..82af28f4a91b 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
@@ -1682,6 +1682,7 @@ static const struct qmp_phy_cfg sc8280xp_usb3_uniphy_cfg = {
 	.vreg_list		= qmp_phy_vreg_l,
 	.num_vregs		= ARRAY_SIZE(qmp_phy_vreg_l),
 	.regs			= qmp_v4_usb3phy_regs_layout,
+	.pcs_usb_offset		= 0x1000,
 };
 
 static const struct qmp_phy_cfg qmp_v3_usb3_uniphy_cfg = {
-- 
2.37.3


  reply	other threads:[~2022-10-28 16:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 16:04 [PATCH RESEND v2 00/13] phy: qcom-qmp-usb: fix sc8280xp binding Johan Hovold
2022-10-28 16:04 ` Johan Hovold [this message]
2022-10-28 16:04 ` [PATCH RESEND v2 02/13] phy: qcom-qmp-usb: sort device-id table Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 03/13] phy: qcom-qmp-usb: move " Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 04/13] phy: qcom-qmp-usb: move pm ops Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 05/13] phy: qcom-qmp-usb: merge driver data Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 06/13] phy: qcom-qmp-usb: clean up device-tree parsing Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 07/13] phy: qcom-qmp-usb: clean up probe initialisation Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 08/13] phy: qcom-qmp-usb: rename PHY ops structure Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 09/13] phy: qcom-qmp-usb: clean up PHY init Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 10/13] dt-bindings: phy: qcom,qmp-usb: rename current bindings Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding Johan Hovold
2022-11-04 21:40   ` Rob Herring
2022-10-28 16:04 ` [PATCH RESEND v2 12/13] phy: qcom-qmp-usb: restructure PHY creation Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 13/13] phy: qcom-qmp-usb: add support for updated sc8280xp binding Johan Hovold
2022-11-05  7:29 ` [PATCH RESEND v2 00/13] phy: qcom-qmp-usb: fix " Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028160435.26948-2-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).