From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH RESEND v2 08/13] phy: qcom-qmp-usb: rename PHY ops structure
Date: Fri, 28 Oct 2022 18:04:30 +0200 [thread overview]
Message-ID: <20221028160435.26948-9-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221028160435.26948-1-johan+linaro@kernel.org>
Rename the PHY operation structure so that it has a "phy_ops" suffix and
move it next to the implementation.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index 2e603831e45e..4a7b961d2965 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
@@ -2149,6 +2149,13 @@ static int qmp_usb_set_mode(struct phy *phy, enum phy_mode mode, int submode)
return 0;
}
+static const struct phy_ops qmp_usb_phy_ops = {
+ .init = qmp_usb_enable,
+ .exit = qmp_usb_disable,
+ .set_mode = qmp_usb_set_mode,
+ .owner = THIS_MODULE,
+};
+
static void qmp_usb_enable_autonomous_mode(struct qmp_usb *qmp)
{
const struct qmp_phy_cfg *cfg = qmp->cfg;
@@ -2366,13 +2373,6 @@ static int phy_pipe_clk_register(struct qmp_usb *qmp, struct device_node *np)
return devm_add_action_or_reset(qmp->dev, phy_clk_release_provider, np);
}
-static const struct phy_ops qmp_usb_ops = {
- .init = qmp_usb_enable,
- .exit = qmp_usb_disable,
- .set_mode = qmp_usb_set_mode,
- .owner = THIS_MODULE,
-};
-
static void __iomem *qmp_usb_iomap(struct device *dev, struct device_node *np,
int index, bool exclusive)
{
@@ -2451,7 +2451,7 @@ static int qmp_usb_create(struct qmp_usb *qmp, struct device_node *np)
"failed to get pipe clock\n");
}
- generic_phy = devm_phy_create(dev, np, &qmp_usb_ops);
+ generic_phy = devm_phy_create(dev, np, &qmp_usb_phy_ops);
if (IS_ERR(generic_phy)) {
ret = PTR_ERR(generic_phy);
dev_err(dev, "failed to create PHY: %d\n", ret);
--
2.37.3
next prev parent reply other threads:[~2022-10-28 16:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:04 [PATCH RESEND v2 00/13] phy: qcom-qmp-usb: fix sc8280xp binding Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 01/13] phy: qcom-qmp-usb: fix sc8280xp PCS_USB offset Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 02/13] phy: qcom-qmp-usb: sort device-id table Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 03/13] phy: qcom-qmp-usb: move " Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 04/13] phy: qcom-qmp-usb: move pm ops Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 05/13] phy: qcom-qmp-usb: merge driver data Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 06/13] phy: qcom-qmp-usb: clean up device-tree parsing Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 07/13] phy: qcom-qmp-usb: clean up probe initialisation Johan Hovold
2022-10-28 16:04 ` Johan Hovold [this message]
2022-10-28 16:04 ` [PATCH RESEND v2 09/13] phy: qcom-qmp-usb: clean up PHY init Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 10/13] dt-bindings: phy: qcom,qmp-usb: rename current bindings Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding Johan Hovold
2022-11-04 21:40 ` Rob Herring
2022-10-28 16:04 ` [PATCH RESEND v2 12/13] phy: qcom-qmp-usb: restructure PHY creation Johan Hovold
2022-10-28 16:04 ` [PATCH RESEND v2 13/13] phy: qcom-qmp-usb: add support for updated sc8280xp binding Johan Hovold
2022-11-05 7:29 ` [PATCH RESEND v2 00/13] phy: qcom-qmp-usb: fix " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028160435.26948-9-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).