devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Fix UniPhier USB3 controller node names in example
Date: Fri, 28 Oct 2022 14:35:41 -0500	[thread overview]
Message-ID: <20221028193541.GA2183248-robh@kernel.org> (raw)
In-Reply-To: <20221027044920.23194-2-hayashi.kunihiko@socionext.com>

On Thu, Oct 27, 2022 at 01:49:19PM +0900, Kunihiko Hayashi wrote:
> The word "glue" is ambiguous for the controller node name. Should put
> "usb-controller" instead of "usb-glue" on the controller node.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml  | 2 +-
>  .../devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> index 21e4414eea60..8ce57898fb96 100644
> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> @@ -146,7 +146,7 @@ additionalProperties: false
>  
>  examples:
>    - |
> -    usb-glue@65b00000 {
> +    usb-controller@65b00000 {
>          compatible = "socionext,uniphier-ld20-dwc3-glue", "simple-mfd";
>          #address-cells = <1>;
>          #size-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
> index 4c26d2d2303d..ba60b7add4f7 100644
> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
> @@ -131,7 +131,7 @@ additionalProperties: false
>  
>  examples:
>    - |
> -    usb-glue@65b00000 {
> +    usb-controller@65b00000 {
>          compatible = "socionext,uniphier-ld20-dwc3-glue",
>                       "simple-mfd";

This and a bunch of other Socionext compatibles in examples throw 
warnings because there is not a schema for them:

Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.example.dtb:0:0: /example-0/usb-controller@65b00000: failed to match any schema with compatible: ['socionext,uniphier-ld20-dwc3-glue', 'simple-mfd']
Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.example.dtb:0:0: /example-0/usb-controller@65b00000: failed to match any schema with compatible: ['socionext,uniphier-ld20-dwc3-glue', 'simple-mfd']


The remaining warnings are preventing turning the warning on by default, 
so fixing them would be nice.

Rob

  reply	other threads:[~2022-10-28 19:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  4:49 [PATCH 0/2] dt-bindings: phy: Fix UniPhier controller node names Kunihiko Hayashi
2022-10-27  4:49 ` [PATCH 1/2] dt-bindings: phy: Fix UniPhier USB3 controller node names in example Kunihiko Hayashi
2022-10-28 19:35   ` Rob Herring [this message]
2022-10-27  4:49 ` [PATCH 2/2] dt-bindings: phy: Fix UniPhier SATA " Kunihiko Hayashi
2022-10-28 19:38   ` Rob Herring
2022-11-01  9:10     ` Kunihiko Hayashi
2022-11-01 19:31       ` Rob Herring
2022-11-01 23:14         ` Kunihiko Hayashi
2022-11-05  7:34           ` Vinod Koul
2022-11-07  2:36             ` Kunihiko Hayashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028193541.GA2183248-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mhiramat@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).