From: Rob Herring <robh@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] ASoC: dt-bindings: wcd938x: fix codec reset line polarity in example
Date: Fri, 28 Oct 2022 14:39:45 -0500 [thread overview]
Message-ID: <20221028193945.GA2192436-robh@kernel.org> (raw)
In-Reply-To: <20221027074652.1044235-6-dmitry.torokhov@gmail.com>
On Thu, Oct 27, 2022 at 12:46:52AM -0700, Dmitry Torokhov wrote:
> The driver for the codec, when resetting the chip, first drives the line
> low, and then high. This means that the line is active low. Change the
> annotation in the example DTS accordingly.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> index 51547190f709..2f5e0df93872 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> @@ -112,7 +112,7 @@ examples:
> - |
> codec {
> compatible = "qcom,wcd9380-codec";
> - reset-gpios = <&tlmm 32 0>;
> + reset-gpios = <&tlmm 32 GPIO_ACTIVE_LOW>;
Missing a header for this.
> #sound-dai-cells = <1>;
> qcom,tx-device = <&wcd938x_tx>;
> qcom,rx-device = <&wcd938x_rx>;
> --
> 2.38.0.135.g90850a2211-goog
>
>
next prev parent reply other threads:[~2022-10-28 19:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 7:46 [PATCH 1/6] arm64: dts: qcom: msm8996: fix sound card reset line polarity Dmitry Torokhov
2022-10-27 7:46 ` [PATCH 2/6] ASoC: dt-bindings: wcd9335: fix reset line polarity in example Dmitry Torokhov
2022-10-27 13:44 ` Krzysztof Kozlowski
2022-10-27 7:46 ` [PATCH 3/6] arm64: dts: qcom: sm8250-mtp: fix reset line polarity Dmitry Torokhov
2022-10-27 7:46 ` [PATCH 4/6] arm64: dts: qcom: sc7280: fix codec reset line polarity for CRD 3.0/3.1 Dmitry Torokhov
2022-10-27 7:46 ` [PATCH 5/6] arm64: dts: qcom: sc7280: fix codec reset line polarity for CRD 1.0/2.0 Dmitry Torokhov
2022-10-27 7:46 ` [PATCH 6/6] ASoC: dt-bindings: wcd938x: fix codec reset line polarity in example Dmitry Torokhov
2022-10-27 13:44 ` Krzysztof Kozlowski
2022-10-28 19:39 ` Rob Herring [this message]
2022-11-07 3:12 ` (subset) [PATCH 1/6] arm64: dts: qcom: msm8996: fix sound card reset line polarity Bjorn Andersson
2022-11-25 21:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028193945.GA2192436-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).