* [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support
@ 2022-10-18 8:53 Alexander Stein
2022-10-18 8:53 ` [PATCH 2/2] arm64: defconfig: Add Renesas 9-series PCIe clock generator Alexander Stein
2022-10-29 3:54 ` [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Stein @ 2022-10-18 8:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Catalin Marinas, Will Deacon
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
devicetree, linux-arm-kernel
Add PCIe support on TQMa8MPxL module on MBa8MPxL mainboard.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
This is based on next-20221018 where imp8mp PCIe support has been
merged.
.../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 42 ++++++++++++++++++-
1 file changed, 41 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
index 7bf6f81e87b4..7a32379cd006 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
@@ -8,6 +8,7 @@
#include <dt-bindings/leds/common.h>
#include <dt-bindings/net/ti-dp83867.h>
+#include <dt-bindings/phy/phy-imx8-pcie.h>
#include <dt-bindings/pwm/pwm.h>
#include "imx8mp-tqma8mpql.dtsi"
@@ -48,6 +49,12 @@ backlight_lvds: backlight {
status = "disabled";
};
+ clk_xtal25: clk-xtal25 {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <25000000>;
+ };
+
gpio-keys {
compatible = "gpio-keys";
pinctrl-names = "default";
@@ -340,9 +347,16 @@ &gpio4 {
"", "", "", "",
"", "", "", "",
"", "", "DP_IRQ", "DSI_EN",
- "HDMI_OC#", "TEMP_EVENT#", "PCIE_CLK_OE#", "",
+ "HDMI_OC#", "TEMP_EVENT#", "PCIE_REFCLK_OE#", "",
"", "", "", "FAN_PWR",
"RTC_EVENT#", "CODEC_RST#", "", "";
+
+ pcie_refclkreq-hog {
+ gpio-hog;
+ gpios = <22 0>;
+ output-high;
+ line-name = "PCIE_REFCLK_OE#";
+ };
};
&gpio5 {
@@ -377,6 +391,13 @@ at24c02_54: eeprom@54 {
pagesize = <16>;
vcc-supply = <®_vcc_3v3>;
};
+
+ pcieclk: clk@6a {
+ compatible = "renesas,9fgv0241";
+ reg = <0x6a>;
+ clocks = <&clk_xtal25>;
+ #clock-cells = <1>;
+ };
};
&i2c4 {
@@ -407,6 +428,25 @@ &pcf85063 {
interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
};
+&pcie_phy {
+ fsl,clkreq-unsupported;
+ fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
+ clocks = <&pcieclk 0>;
+ clock-names = "ref";
+ status = "okay";
+};
+
+&pcie {
+ clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
+ <&clk IMX8MP_CLK_HSIO_AXI>,
+ <&clk IMX8MP_CLK_PCIE_ROOT>;
+ clock-names = "pcie", "pcie_bus", "pcie_aux";
+ assigned-clocks = <&clk IMX8MP_CLK_PCIE_AUX>;
+ assigned-clock-rates = <10000000>;
+ assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_50M>;
+ status = "okay";
+};
+
&pwm2 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pwm2>;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] arm64: defconfig: Add Renesas 9-series PCIe clock generator
2022-10-18 8:53 [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support Alexander Stein
@ 2022-10-18 8:53 ` Alexander Stein
2022-10-29 3:54 ` [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2022-10-18 8:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Catalin Marinas, Will Deacon
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
devicetree, linux-arm-kernel
MBa8MPxL (with TQMa8MPQL attached) needs this driver for PCIe reference
clock generation. Add it do default config.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 0b6af3348e79..d3f1bf5d7e15 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1049,6 +1049,7 @@ CONFIG_COMMON_CLK_CS2000_CP=y
CONFIG_COMMON_CLK_FSL_SAI=y
CONFIG_COMMON_CLK_S2MPS11=y
CONFIG_COMMON_CLK_PWM=y
+CONFIG_COMMON_CLK_RS9_PCIE=y
CONFIG_COMMON_CLK_VC5=y
CONFIG_COMMON_CLK_NPCM8XX=y
CONFIG_COMMON_CLK_BD718XX=m
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support
2022-10-18 8:53 [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support Alexander Stein
2022-10-18 8:53 ` [PATCH 2/2] arm64: defconfig: Add Renesas 9-series PCIe clock generator Alexander Stein
@ 2022-10-29 3:54 ` Shawn Guo
2022-11-01 9:10 ` Alexander Stein
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2022-10-29 3:54 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
Catalin Marinas, Will Deacon, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-arm-kernel
On Tue, Oct 18, 2022 at 10:53:29AM +0200, Alexander Stein wrote:
> Add PCIe support on TQMa8MPxL module on MBa8MPxL mainboard.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> This is based on next-20221018 where imp8mp PCIe support has been
> merged.
>
> .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 42 ++++++++++++++++++-
> 1 file changed, 41 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> index 7bf6f81e87b4..7a32379cd006 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> @@ -8,6 +8,7 @@
>
> #include <dt-bindings/leds/common.h>
> #include <dt-bindings/net/ti-dp83867.h>
> +#include <dt-bindings/phy/phy-imx8-pcie.h>
> #include <dt-bindings/pwm/pwm.h>
> #include "imx8mp-tqma8mpql.dtsi"
>
> @@ -48,6 +49,12 @@ backlight_lvds: backlight {
> status = "disabled";
> };
>
> + clk_xtal25: clk-xtal25 {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> + };
> +
> gpio-keys {
> compatible = "gpio-keys";
> pinctrl-names = "default";
> @@ -340,9 +347,16 @@ &gpio4 {
> "", "", "", "",
> "", "", "", "",
> "", "", "DP_IRQ", "DSI_EN",
> - "HDMI_OC#", "TEMP_EVENT#", "PCIE_CLK_OE#", "",
> + "HDMI_OC#", "TEMP_EVENT#", "PCIE_REFCLK_OE#", "",
> "", "", "", "FAN_PWR",
> "RTC_EVENT#", "CODEC_RST#", "", "";
> +
> + pcie_refclkreq-hog {
Hyphen is more recommended than underscore for node name.
> + gpio-hog;
> + gpios = <22 0>;
> + output-high;
> + line-name = "PCIE_REFCLK_OE#";
> + };
> };
>
> &gpio5 {
> @@ -377,6 +391,13 @@ at24c02_54: eeprom@54 {
> pagesize = <16>;
> vcc-supply = <®_vcc_3v3>;
> };
> +
> + pcieclk: clk@6a {
Should be clock-controller@6a?
Shawn
> + compatible = "renesas,9fgv0241";
> + reg = <0x6a>;
> + clocks = <&clk_xtal25>;
> + #clock-cells = <1>;
> + };
> };
>
> &i2c4 {
> @@ -407,6 +428,25 @@ &pcf85063 {
> interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
> };
>
> +&pcie_phy {
> + fsl,clkreq-unsupported;
> + fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> + clocks = <&pcieclk 0>;
> + clock-names = "ref";
> + status = "okay";
> +};
> +
> +&pcie {
> + clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> + <&clk IMX8MP_CLK_HSIO_AXI>,
> + <&clk IMX8MP_CLK_PCIE_ROOT>;
> + clock-names = "pcie", "pcie_bus", "pcie_aux";
> + assigned-clocks = <&clk IMX8MP_CLK_PCIE_AUX>;
> + assigned-clock-rates = <10000000>;
> + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_50M>;
> + status = "okay";
> +};
> +
> &pwm2 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_pwm2>;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support
2022-10-29 3:54 ` [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support Shawn Guo
@ 2022-11-01 9:10 ` Alexander Stein
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2022-11-01 9:10 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
Catalin Marinas, Will Deacon, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-arm-kernel
Hi Shawn,
thanks for your feedback.
Am Samstag, 29. Oktober 2022, 05:54:22 CET schrieb Shawn Guo:
> On Tue, Oct 18, 2022 at 10:53:29AM +0200, Alexander Stein wrote:
> > Add PCIe support on TQMa8MPxL module on MBa8MPxL mainboard.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > This is based on next-20221018 where imp8mp PCIe support has been
> > merged.
> >
> > .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 42 ++++++++++++++++++-
> > 1 file changed, 41 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> > b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index
> > 7bf6f81e87b4..7a32379cd006 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> > @@ -8,6 +8,7 @@
> >
> > #include <dt-bindings/leds/common.h>
> > #include <dt-bindings/net/ti-dp83867.h>
> >
> > +#include <dt-bindings/phy/phy-imx8-pcie.h>
> >
> > #include <dt-bindings/pwm/pwm.h>
> > #include "imx8mp-tqma8mpql.dtsi"
> >
> > @@ -48,6 +49,12 @@ backlight_lvds: backlight {
> >
> > status = "disabled";
> >
> > };
> >
> > + clk_xtal25: clk-xtal25 {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <25000000>;
> > + };
> > +
> >
> > gpio-keys {
> >
> > compatible = "gpio-keys";
> > pinctrl-names = "default";
> >
> > @@ -340,9 +347,16 @@ &gpio4 {
> >
> > "", "", "", "",
> > "", "", "", "",
> > "", "", "DP_IRQ", "DSI_EN",
> >
> > - "HDMI_OC#", "TEMP_EVENT#", "PCIE_CLK_OE#", "",
> > + "HDMI_OC#", "TEMP_EVENT#", "PCIE_REFCLK_OE#",
"",
> >
> > "", "", "", "FAN_PWR",
> > "RTC_EVENT#", "CODEC_RST#", "", "";
> >
> > +
> > + pcie_refclkreq-hog {
>
> Hyphen is more recommended than underscore for node name.
Ah, yes. Will fix that. Thanks for spotting.
> > + gpio-hog;
> > + gpios = <22 0>;
> > + output-high;
> > + line-name = "PCIE_REFCLK_OE#";
> > + };
> >
> > };
> >
> > &gpio5 {
> >
> > @@ -377,6 +391,13 @@ at24c02_54: eeprom@54 {
> >
> > pagesize = <16>;
> > vcc-supply = <®_vcc_3v3>;
> >
> > };
> >
> > +
> > + pcieclk: clk@6a {
>
> Should be clock-controller@6a?
I will actually go with clock-generator@6a as shown in the bindings example.
The vendor actually names it a clock generator.
Thanks
Alexander
> Shawn
>
> > + compatible = "renesas,9fgv0241";
> > + reg = <0x6a>;
> > + clocks = <&clk_xtal25>;
> > + #clock-cells = <1>;
> > + };
> >
> > };
> >
> > &i2c4 {
> >
> > @@ -407,6 +428,25 @@ &pcf85063 {
> >
> > interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
> >
> > };
> >
> > +&pcie_phy {
> > + fsl,clkreq-unsupported;
> > + fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> > + clocks = <&pcieclk 0>;
> > + clock-names = "ref";
> > + status = "okay";
> > +};
> > +
> > +&pcie {
> > + clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> > + <&clk IMX8MP_CLK_HSIO_AXI>,
> > + <&clk IMX8MP_CLK_PCIE_ROOT>;
> > + clock-names = "pcie", "pcie_bus", "pcie_aux";
> > + assigned-clocks = <&clk IMX8MP_CLK_PCIE_AUX>;
> > + assigned-clock-rates = <10000000>;
> > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_50M>;
> > + status = "okay";
> > +};
> > +
> >
> > &pwm2 {
> >
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_pwm2>;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-01 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-18 8:53 [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support Alexander Stein
2022-10-18 8:53 ` [PATCH 2/2] arm64: defconfig: Add Renesas 9-series PCIe clock generator Alexander Stein
2022-10-29 3:54 ` [PATCH 1/2] arm64: dts: tqma8mpql: add PCIe support Shawn Guo
2022-11-01 9:10 ` Alexander Stein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).