From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
UNGLinuxDriver@microchip.com, Sergey Shtylyov <s.shtylyov@omp.ru>,
Manivannan Sadhasivam <mani@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Jonathan Marek <jonathan@marek.ca>,
Martin Botka <martin.botka@somainline.org>,
Taniya Das <tdas@codeaurora.org>,
Christian Marangi <ansuelsmth@gmail.com>,
Stephan Gerhold <stephan@gerhold.net>,
Shawn Guo <shawn.guo@linaro.org>, Vinod Koul <vkoul@kernel.org>,
krishna Lanka <quic_vamslank@quicinc.com>,
Iskren Chernev <iskren.chernev@gmail.com>,
Del Regno <angelogioacchino.delregno@somainline.org>,
Robert Foss <robert.foss@linaro.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Govind Singh <govinds@codeaurora.org>,
Loic Poulain <loic.poulain@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Oleksij Rempel <linux@rempel-privat.de>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: constrain number of 'reg' in ethernet ports
Date: Sun, 30 Oct 2022 18:04:42 +0100 [thread overview]
Message-ID: <20221030170442.GA7508@pengutronix.de> (raw)
In-Reply-To: <20221028140326.43470-2-krzysztof.kozlowski@linaro.org>
On Fri, Oct 28, 2022 at 10:03:25AM -0400, Krzysztof Kozlowski wrote:
> 'reg' without any constraints allows multiple items which is not the
> intention for Ethernet controller's port number.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
For asix,ax88178.yaml and microchip,lan95xx.yaml
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> ---
>
> Please give it a time for Rob's bot to process this.
> ---
> Documentation/devicetree/bindings/net/asix,ax88178.yaml | 4 +++-
> Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 4 +++-
> .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 4 ++--
> .../devicetree/bindings/net/microchip,sparx5-switch.yaml | 3 ++-
> .../devicetree/bindings/net/mscc,vsc7514-switch.yaml | 3 ++-
> .../bindings/net/renesas,r8a779f0-ether-switch.yaml | 4 ++--
> 6 files changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/asix,ax88178.yaml b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
> index 1af52358de4c..a81dbc4792f6 100644
> --- a/Documentation/devicetree/bindings/net/asix,ax88178.yaml
> +++ b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
> @@ -27,7 +27,9 @@ properties:
> - usbb95,772b # ASIX AX88772B
> - usbb95,7e2b # ASIX AX88772B
>
> - reg: true
> + reg:
> + maxItems: 1
> +
> local-mac-address: true
> mac-address: true
>
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> index cf91fecd8909..3715c5f8f0e0 100644
> --- a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> @@ -39,7 +39,9 @@ properties:
> - usb424,9e08 # SMSC LAN89530 USB Ethernet Device
> - usb424,ec00 # SMSC9512/9514 USB Hub & Ethernet Device
>
> - reg: true
> + reg:
> + maxItems: 1
> +
> local-mac-address: true
> mac-address: true
>
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> index dc116f14750e..583d70c51be6 100644
> --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> @@ -83,8 +83,8 @@ properties:
> const: 0
>
> reg:
> - description:
> - Switch port number
> + items:
> + - description: Switch port number
>
> phys:
> description:
> diff --git a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> index 57ffeb8fc876..ccb912561446 100644
> --- a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> @@ -89,7 +89,8 @@ properties:
>
> properties:
> reg:
> - description: Switch port number
> + items:
> + - description: Switch port number
>
> phys:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> index ee0a504bdb24..1cf82955d75e 100644
> --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> @@ -109,7 +109,8 @@ properties:
>
> properties:
> reg:
> - description: Switch port number
> + items:
> + - description: Switch port number
>
> phy-handle: true
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml b/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml
> index 581fff8902f4..0eba66a29c6c 100644
> --- a/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml
> @@ -106,8 +106,8 @@ properties:
>
> properties:
> reg:
> - description:
> - Port number of ETHA (TSNA).
> + items:
> + - description: Port number of ETHA (TSNA).
>
> phys:
> maxItems: 1
> --
> 2.34.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-10-30 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 14:03 [PATCH 1/2] dt-bindings: clock: qcom,gcc-ipq8074: use common GCC schema Krzysztof Kozlowski
2022-10-28 14:03 ` [PATCH] dt-bindings: net: constrain number of 'reg' in ethernet ports Krzysztof Kozlowski
2022-10-30 17:04 ` Oleksij Rempel [this message]
2022-10-31 18:57 ` Rob Herring
2022-11-02 15:48 ` Krzysztof Kozlowski
2022-10-28 14:03 ` [PATCH 2/2] dt-bindings: clock: qcom: cleanup Krzysztof Kozlowski
2022-10-28 14:14 ` Jeffrey Hugo
2022-10-31 19:01 ` Rob Herring
2022-10-31 18:51 ` [PATCH 1/2] dt-bindings: clock: qcom,gcc-ipq8074: use common GCC schema Rob Herring
[not found] ` <20221101194805.9EE0EC433C1@smtp.kernel.org>
2022-11-02 16:28 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2022-10-28 1:54 [PATCH] dt-bindings: net: constrain number of 'reg' in ethernet ports Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030170442.GA7508@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=ansuelsmth@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=edumazet@google.com \
--cc=govinds@codeaurora.org \
--cc=horatiu.vultur@microchip.com \
--cc=iskren.chernev@gmail.com \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=loic.poulain@linaro.org \
--cc=mani@kernel.org \
--cc=martin.botka@somainline.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_vamslank@quicinc.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=sboyd@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
--cc=tdas@codeaurora.org \
--cc=vkoul@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).