From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F8E1C433FE for ; Tue, 1 Nov 2022 15:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231400AbiKAPQp (ORCPT ); Tue, 1 Nov 2022 11:16:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231450AbiKAPQX (ORCPT ); Tue, 1 Nov 2022 11:16:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 093B91CFC2 for ; Tue, 1 Nov 2022 08:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667315558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WhCfbrC+tKlaqwlNl94RimQiIKrtWvzi9RGBXnP5PaA=; b=i2Sqz2pyCUKmYYZV76++4Gj0YRSoInD+4WSDzF4LGw9iPfTvWaONweB6Hj14UIPcGS7rhh dNUrMK4Lnp7bRptbnE6Imf1APNdtFI4GHt5YX6YjxlNKW/fAj568r5fKap+q2xvWci647L EqQ2DsBwKaSFFNvz9Zu+6mqHcwM/IJc= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-460-TtU2fM6yOwKFl1fUyYsgZQ-1; Tue, 01 Nov 2022 11:12:37 -0400 X-MC-Unique: TtU2fM6yOwKFl1fUyYsgZQ-1 Received: by mail-oi1-f198.google.com with SMTP id z203-20020aca33d4000000b0035a0c54ff88so2593638oiz.6 for ; Tue, 01 Nov 2022 08:12:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WhCfbrC+tKlaqwlNl94RimQiIKrtWvzi9RGBXnP5PaA=; b=JYkfdQMEY0BP1PKB94FtzXaXYoPtoa5XHC/xxXOvxby67uXbTYcX77zy7Eoma6grSQ Mqzj5ZhgQEx9ftrNIBikSjjGp6H3+a4QycgaisnYKsvJ2NbYoJ3yHyuC+L1oSINgfoWa LJqfiFp/qBUvpyU6VJpOphbzJK5oFyidEIdvVLiE5Z2qumq8W2VSECsI8Qg8jjMMIpj5 viU7JXw2JUevmHJa188JlpJKgQ7cVFXlaUQQs/q6Ni4LvMvJiwTIrVYaCeAIQWQijkNJ GU9QTmaPTnjkZxj+b3hFMOqKliwPFayWMNuGmBAfAZ0XuuTeTe4MplJRSBFOnkvBdRrT gzDA== X-Gm-Message-State: ACrzQf3vwEFQgO7q+PwUGSlNKXJI0lscFOZxgnw3XTakpRgU1/psmPPC GCWPJIiaHUVT0Cfy55fLqcNYfiAqUcWJRTeG0c01TGB1NF7aYOZ0+oBDKzhtaBk2a34HuOC6dil 8QXxxx0gmBYIwHNWU50uTZA== X-Received: by 2002:a05:6830:2693:b0:661:e5be:54d with SMTP id l19-20020a056830269300b00661e5be054dmr10137058otu.365.1667315556269; Tue, 01 Nov 2022 08:12:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM793XlwTZxCVNxIGpeJvkdANMVrjJrL3o5j79HVnLEDlz/VJyPLPzK5QdqyGPayhDWk8QyQxQ== X-Received: by 2002:a05:6830:2693:b0:661:e5be:54d with SMTP id l19-20020a056830269300b00661e5be054dmr10137047otu.365.1667315556035; Tue, 01 Nov 2022 08:12:36 -0700 (PDT) Received: from halaney-x13s ([2600:1700:1ff0:d0e0::41]) by smtp.gmail.com with ESMTPSA id w67-20020acadf46000000b0035770fc6ca9sm3437879oig.16.2022.11.01.08.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 08:12:35 -0700 (PDT) Date: Tue, 1 Nov 2022 10:12:33 -0500 From: Andrew Halaney To: Manivannan Sadhasivam Cc: martin.petersen@oracle.com, jejb@linux.ibm.com, andersson@kernel.org, vkoul@kernel.org, krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, quic_cang@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org, dmitry.baryshkov@linaro.org Subject: Re: [PATCH v2 12/15] scsi: ufs: ufs-qcom: Fix the Qcom register name for offset 0xD0 Message-ID: <20221101151233.gsmmdbz7htkzpbps@halaney-x13s> References: <20221031180217.32512-1-manivannan.sadhasivam@linaro.org> <20221031180217.32512-13-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221031180217.32512-13-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Oct 31, 2022 at 11:32:14PM +0530, Manivannan Sadhasivam wrote: > On newer UFS revisions, the register at offset 0xD0 is called, > REG_UFS_PARAM0. Since the existing register, RETRY_TIMER_REG is not used > anywhere, it is safe to use the new name. > > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Andrew Halaney > --- > drivers/ufs/host/ufs-qcom.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h > index 9d96ac71b27f..7fe928b82753 100644 > --- a/drivers/ufs/host/ufs-qcom.h > +++ b/drivers/ufs/host/ufs-qcom.h > @@ -33,7 +33,8 @@ enum { > REG_UFS_TX_SYMBOL_CLK_NS_US = 0xC4, > REG_UFS_LOCAL_PORT_ID_REG = 0xC8, > REG_UFS_PA_ERR_CODE = 0xCC, > - REG_UFS_RETRY_TIMER_REG = 0xD0, > + /* On older UFS revisions, this register is called "RETRY_TIMER_REG" */ > + REG_UFS_PARAM0 = 0xD0, > REG_UFS_PA_LINK_STARTUP_TIMER = 0xD8, > REG_UFS_CFG1 = 0xDC, > REG_UFS_CFG2 = 0xE0, > -- > 2.25.1 >