From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB820C43217 for ; Wed, 2 Nov 2022 06:55:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230150AbiKBGzB (ORCPT ); Wed, 2 Nov 2022 02:55:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbiKBGy7 (ORCPT ); Wed, 2 Nov 2022 02:54:59 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B5E26125 for ; Tue, 1 Nov 2022 23:54:58 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id gw22so2430936pjb.3 for ; Tue, 01 Nov 2022 23:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SAOkUsCOtaiUhMk86kQHicWY7yq03GggkInJiFKNa+Q=; b=MEzPbgg3wLi8HrCN3s9iVF+0j0Dc4kIb18s95oTCxTrDTyY+/m2vVdT/sUzuJxecn4 Hzrno2UsQl5r3KZFn9b2YyR6ba5g+A4KBmbwC1fZ4Ad+luHhZA0i0AK/EJt4exBYhuC9 jiBXxdr2rpgDbI1r+ec3LZmDbhrPuA8XdHHVIdRnWB+AfsVaDv5X9Kg9nCDSmKprYYCA 4DCUHZRJaPiWGBZLOQ2k5PqDONrpf3VHnHSk4jM3kQChui4sC2Mp9b81qK3A/XCnQ7s/ zY3PWdqhuE+CNAhJYlaKPliCWGxkmeMhHv4TEIQqj8oICpAASQAgg/LhD9QwBYZh1P/s fh6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SAOkUsCOtaiUhMk86kQHicWY7yq03GggkInJiFKNa+Q=; b=gfL93/0tSBhZrI3zsFPQuvUX4ZFpDOqgLF/YuBK/R3dDSRAfxA/FZOHUyia3CxWjCV VTX7MZtL8pZAqM6Sen4zOPhfb/NFfoyK+Tz2LuwqQ0wZ5rgryveBr67+kUTBRcGWDprQ e5ChgrDR697O/pWOBeuf5lHoSB81OIBbA3wYTBkaL8sULTeRry+2+3b+pkXYEZ3iFaGp XjU/qpjj5HOdrl0wUlDktriru+PI0P1QZTbVwaXaUP22vti/dQZZSqdMclB+3Jr1YaL6 W8ykgPlkC1+ql8C4mviNx2w2l0cYV8SYtUy8G99hGP2bKGTxvk9zkK6kGkCCxEx+XmR2 PGnw== X-Gm-Message-State: ACrzQf2FVmQBQRILP41xAbyTylbuGKqzvXiKVKmyduXmCFQPEf7GGIse ux7wav6EAGxeHJhRmc26OeN/ X-Google-Smtp-Source: AMsMyM4rGLfxyF9kzZE9+p2ectELM6qqF7ZVRIHqYdn6aPcQGYorkM+oB/Tc8aqySRcJD/Zehi5olA== X-Received: by 2002:a17:902:ab89:b0:186:7cfc:cde8 with SMTP id f9-20020a170902ab8900b001867cfccde8mr23636607plr.9.1667372097729; Tue, 01 Nov 2022 23:54:57 -0700 (PDT) Received: from thinkpad ([117.193.209.178]) by smtp.gmail.com with ESMTPSA id m10-20020a170902f64a00b001769cfa5cd4sm7505787plg.49.2022.11.01.23.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 23:54:56 -0700 (PDT) Date: Wed, 2 Nov 2022 12:24:48 +0530 From: Manivannan Sadhasivam To: Viresh Kumar Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, rafael@kernel.org, robh+dt@kernel.org, johan@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 7/7] cpufreq: qcom-hw: Add CPU clock provider support Message-ID: <20221102065448.GA10650@thinkpad> References: <20221025073254.1564622-1-manivannan.sadhasivam@linaro.org> <20221025073254.1564622-8-manivannan.sadhasivam@linaro.org> <20221102042849.q3qnaoebeudpbpnv@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221102042849.q3qnaoebeudpbpnv@vireshk-i7> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Nov 02, 2022 at 09:58:49AM +0530, Viresh Kumar wrote: > On 25-10-22, 13:02, Manivannan Sadhasivam wrote: > > for (i = 0; i < num_domains; i++) { > > struct qcom_cpufreq_data *data = &qcom_cpufreq.data[i]; > > + static struct clk_init_data init = {}; > > Why not make this part of a driver level structure instead of static ? > And what will {} do ? Initialize to 0 ? static would have already done > that. > Good catch! "static" is not needed here. Thanks, Mani > -- > viresh -- மணிவண்ணன் சதாசிவம்