From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
linux-mtd@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Naga Sureshkumar Relli <nagasure@xilinx.com>,
Linus Walleij <linus.walleij@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 05/12] dt-bindings: mtd: onenand: Mention the expected node name
Date: Wed, 2 Nov 2022 16:46:57 -0500 [thread overview]
Message-ID: <20221102214657.GC459441-robh@kernel.org> (raw)
In-Reply-To: <20221102175007.4a4db2c9@xps-13>
On Wed, Nov 02, 2022 at 05:50:07PM +0100, Miquel Raynal wrote:
> Hi Rob,
>
> robh@kernel.org wrote on Mon, 31 Oct 2022 15:54:42 -0500:
>
> > On Sat, Oct 29, 2022 at 01:59:26AM +0200, Miquel Raynal wrote:
> > > The chip node name in this driver is expected to be different and should
> > > be prefixed with onenand instead of the regular "flash" string, so
> > > mention it.
> > >
> > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > ---
> > > Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> > > index a953f7397c40..8a79ad300216 100644
> > > --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> > > +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> > > @@ -15,6 +15,9 @@ description:
> > > as child nodes of the GPMC controller.
> > >
> > > properties:
> > > + $nodename:
> > > + pattern: "^onenand@[0-9],[0,9]$"
> >
> > I don't think it is worth enforcing node names that we
> > haven't defined in the spec. Wouldn't 'nand-controller' be appropriate?
>
> Actually I've added this pattern here because there are several users in
> the arm/boot/dts/ directory which use it, and the example below in this
> file also uses onenand@xxx.
>
> I can either fix the example to use nand-controller or add this pattern
> (I guess "deprecated: true" would not mean anything?). What do you
> prefer?
>
> If we decide to switch to the nand-controller@ name, shall I change the
> DTS as well?
I guess I'd just leave it as you have it.
Rob
next prev parent reply other threads:[~2022-11-02 21:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 23:59 [PATCH 00/12] Improve MTD bindings Miquel Raynal
2022-10-28 23:59 ` [PATCH 01/12] dt-bindings: mtd: Clarify all partition subnodes Miquel Raynal
2022-10-31 19:32 ` Rob Herring
2022-10-31 19:43 ` Rob Herring
2022-10-28 23:59 ` [PATCH 02/12] dt-bindings: mtd: Mention basic properties Miquel Raynal
2022-10-31 19:33 ` Rob Herring
2022-10-28 23:59 ` [PATCH 03/12] dt-bindings: mtd: Remove useless file about partitions Miquel Raynal
2022-10-31 19:35 ` Rob Herring
2022-10-28 23:59 ` [PATCH 04/12] dt-bindings: mtd: ingenic: Mark partitions in the controller node as deprecated Miquel Raynal
2022-10-30 13:50 ` Rob Herring
2022-10-31 19:46 ` Rob Herring
2022-10-28 23:59 ` [PATCH 05/12] dt-bindings: mtd: onenand: Mention the expected node name Miquel Raynal
2022-10-31 20:54 ` Rob Herring
2022-11-02 16:50 ` Miquel Raynal
2022-11-02 21:46 ` Rob Herring [this message]
2022-10-28 23:59 ` [PATCH 06/12] dt-bindings: mtd: nand-chip: Reference mtd.yaml Miquel Raynal
2022-10-31 20:55 ` Rob Herring
2022-10-28 23:59 ` [PATCH 07/12] dt-bindings: mtd: Drop common properties from NAND controllers Miquel Raynal
2022-10-31 20:55 ` Rob Herring
2022-10-28 23:59 ` [PATCH 08/12] dt-bindings: mtd: spi-nor: Drop common properties Miquel Raynal
2022-10-31 20:56 ` Rob Herring
2022-10-28 23:59 ` [PATCH 09/12] dt-bindings: mtd: phymap: Reuse the generic definitions Miquel Raynal
2022-10-30 13:50 ` Rob Herring
2022-10-28 23:59 ` [PATCH 10/12] dt-bindings: mtd: Drop object types when referencing other files Miquel Raynal
2022-10-31 20:59 ` Rob Herring
2022-10-28 23:59 ` [PATCH 11/12] dt-bindings: mtd: Argue in favor of keeping additionalProperties set to true Miquel Raynal
2022-10-31 21:01 ` Rob Herring
2022-10-28 23:59 ` [PATCH 12/12] dt-bindings: mtd: Constrain the list of parsers Miquel Raynal
2022-10-31 21:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102214657.GC459441-robh@kernel.org \
--to=robh@kernel.org \
--cc=Tudor.Ambarus@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mani@kernel.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=naga.sureshkumar.relli@xilinx.com \
--cc=nagasure@xilinx.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).