From: Sudeep Holla <sudeep.holla@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, cristian.marussi@arm.com, agross@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org,
quic_avajid@quicinc.com, Souvik.Chakravarty@arm.com,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [RFC 2/2] firmware: arm_scmi: Add SCMI QTI Memlat vendor protocol
Date: Thu, 3 Nov 2022 10:24:44 +0000 [thread overview]
Message-ID: <20221103102444.c5ngcxupohwdzntf@bogus> (raw)
In-Reply-To: <1667451512-9655-3-git-send-email-quic_sibis@quicinc.com>
On Thu, Nov 03, 2022 at 10:28:32AM +0530, Sibi Sankar wrote:
> Add support for the SCMI QTI memlat (memory latency) vendor protocol.
> The QTI memlat vendor protocol takes in several tuneables including the
> IPM ratio (Instructions Per Miss), bus bandwidth requirements and PMU
> maps to enable frequency scaling of various buses (L3/LLCC/DDR) performed
> by the memory latency governor running on the CPUSS Control Processor.
>
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
> drivers/firmware/arm_scmi/Kconfig | 10 +
> drivers/firmware/arm_scmi/Makefile | 1 +
> drivers/firmware/arm_scmi/qcom_memlat_vendor.c | 269 +++++++++++++++++++++++++
> include/linux/scmi_protocol.h | 36 ++++
> 4 files changed, 316 insertions(+)
> create mode 100644 drivers/firmware/arm_scmi/qcom_memlat_vendor.c
>
> diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig
> index a14f65444b35..814a3fc37dc1 100644
> --- a/drivers/firmware/arm_scmi/Kconfig
> +++ b/drivers/firmware/arm_scmi/Kconfig
> @@ -136,6 +136,16 @@ config ARM_SCMI_TRANSPORT_VIRTIO_ATOMIC_ENABLE
>
> endif #ARM_SCMI_PROTOCOL
>
> +config QTI_SCMI_MEMLAT_PROTOCOL
> + tristate "Qualcomm Technologies, Inc. SCMI MEMLAT vendor Protocol"
> + depends on ARM_SCMI_PROTOCOL && QCOM_CPUCP_MBOX
If you have set the transport correctly, there should be no need for any
such dependency.
> + help
> + The SCMI QTI memlat vendor protocol adds support for the frequency
> + scaling of buses (L3/LLCC/DDR) by the QTI HW memlat governor running
> + on the CPUSS Control Processor (CPUCP).
> +
> + Say Y here if you want to build this driver.
> +
I don't think it is scalable to have a config option for each vendor+protocol
Kconfig. IMO just one config for all qcom vendor protocol please.
--
Regards,
Sudeep
next prev parent reply other threads:[~2022-11-03 10:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 4:58 [RFC 0/2] Add support for SCMI QTI Memlat Vendor Protocol Sibi Sankar
2022-11-03 4:58 ` [RFC 1/2] dt-bindings: firmware: arm,scmi: Add support for memlat vendor protocol Sibi Sankar
2022-11-03 10:19 ` Sudeep Holla
2022-11-03 12:35 ` Rob Herring
2022-11-04 18:03 ` Rob Herring
2022-11-08 10:48 ` Sibi Sankar
2022-11-03 4:58 ` [RFC 2/2] firmware: arm_scmi: Add SCMI QTI Memlat " Sibi Sankar
2022-11-03 10:24 ` Sudeep Holla [this message]
2022-11-03 10:37 ` Sudeep Holla
2022-11-09 7:12 ` Sibi Sankar
2022-11-03 20:02 ` Matthias Kaehlcke
2022-11-08 11:06 ` Sibi Sankar
2022-11-03 9:41 ` [RFC 0/2] Add support for SCMI QTI Memlat Vendor Protocol Cristian Marussi
2022-11-08 11:01 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103102444.c5ngcxupohwdzntf@bogus \
--to=sudeep.holla@arm.com \
--cc=Souvik.Chakravarty@arm.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_avajid@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox