devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: andersson@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org,
	quic_jprakash@quicinc.com, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	steev@kali.org
Subject: Re: [PATCH v2 12/12] arm64: dts: qcom: sc8280xp-x13s: Add thermal zone support
Date: Thu, 3 Nov 2022 17:42:28 +0530	[thread overview]
Message-ID: <20221103121228.GB8434@thinkpad> (raw)
In-Reply-To: <e46c817b-1a3b-d20c-22e7-a67b7684f17b@somainline.org>

On Thu, Nov 03, 2022 at 11:02:30AM +0100, Konrad Dybcio wrote:
> 
> On 03/11/2022 06:50, Manivannan Sadhasivam wrote:
> > On Sat, Oct 29, 2022 at 04:29:05PM +0200, Konrad Dybcio wrote:
> > > 
> > > On 29.10.2022 07:14, Manivannan Sadhasivam wrote:
> > > > Add thermal zone support by making use of the thermistor SYS_THERM6.
> > > > Based on experiments, this thermistor seems to reflect the actual
> > > > surface temperature of the laptop.
> > > > 
> > > > For the cooling device, all BIG CPU cores are throttle down to keep the
> > > s/throttle/throttled
> > > 
> > > Is it okay to let the 4xA78C run at full throttle in thermal emergencies though?
> > I don't get it. Can you elaborate?
> 
> 8280xp has 4xA78C and 4xX1C. You only added the latter ones to the cooling
> map.
> 

Right, that's because the first 4 cores doesn't contribute to thermal much and
thottling them doesn't yield any thermal gain.

Thanks,
Mani

> 
> > 
> > > > temperature at a sane level.
> > > > 
> > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > > ---
> > > >   .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 46 +++++++++++++++++++
> > > >   1 file changed, 46 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > > > index ca77c19c6d0d..96e2fa72f782 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > > > @@ -29,6 +29,52 @@ backlight {
> > > >   		pinctrl-0 = <&edp_bl_en>, <&edp_bl_pwm>;
> > > >   	};
> > > > +	thermal-zones {
> > > > +		skin-temp-thermal {
> > > > +			polling-delay-passive = <250>;
> > > > +			polling-delay = <0>;
> > > > +			thermal-sensors = <&pmk8280_adc_tm 5>;
> > > > +
> > > > +			trips {
> > > > +				skin_temp_alert0: trip-point0 {
> > > > +					temperature = <55000>;
> > > > +					hysteresis = <1000>;
> > > > +					type = "passive";
> > > > +				};
> > > > +
> > > > +				skin_temp_alert1: trip-point1 {
> > > > +					temperature = <58000>;
> > > > +					hysteresis = <1000>;
> > > > +					type = "passive";
> > > > +				};
> > > > +
> > > > +				skin-temp-crit {
> > > > +					temperature = <73000>;
> > > Ouch, I didn't know we were serving burnt fingers at the cafeteria today :D
> > > 
> > > Or maybe this just looks scary.. The laptop looks plastic, so maybe it won't cause instant
> > > burns?
> > > 
> > 73c is what the reasonable number I came up with after some experiments. At
> > this point the temperature won't burn your finger but crossing this surely
> > would (that's what happening without this series).
> 
> Ok, then I suppose it's fine. Thanks!
> 
> 
> Konrad
> 
> > 
> > Thanks,
> > Mani
> > 
> > > Konrad
> > > > +					hysteresis = <1000>;
> > > > +					type = "critical";
> > > > +				};
> > > > +			};
> > > > +
> > > > +			cooling-maps {
> > > > +				map0 {
> > > > +					trip = <&skin_temp_alert0>;
> > > > +					cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > > > +							 <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > > > +							 <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > > > +							 <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > > > +				};
> > > > +
> > > > +				map1 {
> > > > +					trip = <&skin_temp_alert1>;
> > > > +					cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > > > +							 <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > > > +							 <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > > > +							 <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > > > +				};
> > > > +			};
> > > > +		};
> > > > +	};
> > > > +
> > > >   	vreg_edp_bl: regulator-edp-bl {
> > > >   		compatible = "regulator-fixed";

-- 
மணிவண்ணன் சதாசிவம்

  reply	other threads:[~2022-11-03 12:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-29  5:14 [PATCH v2 00/12] sc8280xp-pmic updates and X13s thermal zone support Manivannan Sadhasivam
2022-10-29  5:14 ` [PATCH v2 01/12] dt-bindings: iio: qcom: adc7-pm8350: Allow specifying SID for channels Manivannan Sadhasivam
2022-10-29 22:07   ` Dmitry Baryshkov
2022-10-31 21:33   ` Rob Herring
2022-11-02 20:06   ` Krzysztof Kozlowski
2022-10-29  5:14 ` [PATCH v2 02/12] arm64: dts: qcom: sc8280xp-pmics: Add temp alarm for PM8280_{1/2} PMICs Manivannan Sadhasivam
2022-10-29 14:13   ` Konrad Dybcio
2022-10-29  5:14 ` [PATCH v2 03/12] arm64: dts: qcom: sc8280xp-pmics: Add thermal zones " Manivannan Sadhasivam
2022-10-29 14:13   ` Konrad Dybcio
2022-10-29  5:14 ` [PATCH v2 04/12] arm64: dts: qcom: sc8280xp-pmics: Add support for PMK8280 RESIN input Manivannan Sadhasivam
2022-10-29 14:15   ` Konrad Dybcio
2022-10-29  5:14 ` [PATCH v2 05/12] arm64: dts: qcom: sc8280xp-pmics: Add PMK8280 ADC7 block Manivannan Sadhasivam
2022-10-29 14:15   ` Konrad Dybcio
2022-10-29 14:17     ` Konrad Dybcio
2022-11-02 20:07   ` Krzysztof Kozlowski
2022-10-29  5:14 ` [PATCH v2 06/12] arm64: dts: qcom: sc8280xp-pmics: Add support for TM5 block in PMK8280 Manivannan Sadhasivam
2022-10-29 14:16   ` Konrad Dybcio
2022-10-29  5:14 ` [PATCH v2 07/12] arm64: dts: qcom: sc8280xp-x13s: Enable PMK8280 RESIN input Manivannan Sadhasivam
2022-10-29 14:16   ` Konrad Dybcio
2022-10-29  5:14 ` [PATCH v2 08/12] arm64: dts: qcom: sc8280xp-x13s: Add PMK8280 VADC channels Manivannan Sadhasivam
2022-10-29 14:18   ` Konrad Dybcio
2022-11-02 20:07   ` Krzysztof Kozlowski
2022-10-29  5:14 ` [PATCH v2 09/12] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} " Manivannan Sadhasivam
2022-10-29 14:20   ` Konrad Dybcio
2022-11-02 20:08   ` Krzysztof Kozlowski
2022-10-29  5:14 ` [PATCH v2 10/12] arm64: dts: qcom: sc8280xp-x13s: Add PMR735A VADC channel Manivannan Sadhasivam
2022-10-29 14:20   ` Konrad Dybcio
2022-11-02 20:08   ` Krzysztof Kozlowski
2022-10-29  5:14 ` [PATCH v2 11/12] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} ADC_TM5 channels Manivannan Sadhasivam
2022-10-29 14:21   ` Konrad Dybcio
2022-11-02 20:08   ` Krzysztof Kozlowski
2022-10-29  5:14 ` [PATCH v2 12/12] arm64: dts: qcom: sc8280xp-x13s: Add thermal zone support Manivannan Sadhasivam
2022-10-29 14:29   ` Konrad Dybcio
2022-10-29 19:07     ` Steev Klimaszewski
2022-11-03  5:50     ` Manivannan Sadhasivam
2022-11-03 10:02       ` Konrad Dybcio
2022-11-03 12:12         ` Manivannan Sadhasivam [this message]
2022-10-29 19:26 ` [PATCH v2 00/12] sc8280xp-pmic updates and X13s " Steev Klimaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103121228.GB8434@thinkpad \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_jprakash@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=steev@kali.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).