devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cosmin Tanislav <demonsingur@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Cosmin Tanislav" <cosmin.tanislav@analog.com>
Subject: [PATCH v4 01/13] iio: temperature: ltc2983: make bulk write buffer DMA-safe
Date: Thu,  3 Nov 2022 15:00:29 +0200	[thread overview]
Message-ID: <20221103130041.2153295-2-demonsingur@gmail.com> (raw)
In-Reply-To: <20221103130041.2153295-1-demonsingur@gmail.com>

From: Cosmin Tanislav <cosmin.tanislav@analog.com>

regmap_bulk_write() does not guarantee implicit DMA-safety,
even though the current implementation duplicates the given
buffer. Do not rely on it.

Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
---
 drivers/iio/temperature/ltc2983.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
index b652d2b39bcf..ca1bb5f48988 100644
--- a/drivers/iio/temperature/ltc2983.c
+++ b/drivers/iio/temperature/ltc2983.c
@@ -209,6 +209,7 @@ struct ltc2983_data {
 	 * Holds the converted temperature
 	 */
 	__be32 temp __aligned(IIO_DMA_MINALIGN);
+	__be32 chan_val;
 };
 
 struct ltc2983_sensor {
@@ -313,19 +314,18 @@ static int __ltc2983_fault_handler(const struct ltc2983_data *st,
 	return 0;
 }
 
-static int __ltc2983_chan_assign_common(const struct ltc2983_data *st,
+static int __ltc2983_chan_assign_common(struct ltc2983_data *st,
 					const struct ltc2983_sensor *sensor,
 					u32 chan_val)
 {
 	u32 reg = LTC2983_CHAN_START_ADDR(sensor->chan);
-	__be32 __chan_val;
 
 	chan_val |= LTC2983_CHAN_TYPE(sensor->type);
 	dev_dbg(&st->spi->dev, "Assign reg:0x%04X, val:0x%08X\n", reg,
 		chan_val);
-	__chan_val = cpu_to_be32(chan_val);
-	return regmap_bulk_write(st->regmap, reg, &__chan_val,
-				 sizeof(__chan_val));
+	st->chan_val = cpu_to_be32(chan_val);
+	return regmap_bulk_write(st->regmap, reg, &st->chan_val,
+				 sizeof(st->chan_val));
 }
 
 static int __ltc2983_chan_custom_sensor_assign(struct ltc2983_data *st,
-- 
2.38.1


  reply	other threads:[~2022-11-03 13:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 13:00 [PATCH v4 00/13] Support more parts in LTC2983 Cosmin Tanislav
2022-11-03 13:00 ` Cosmin Tanislav [this message]
2022-11-03 13:00 ` [PATCH v4 02/13] dt-bindings: iio: temperature: ltc2983: add default values Cosmin Tanislav
2022-11-07 16:45   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 03/13] dt-bindings: iio: temperature: ltc2983: use hex for sensor address Cosmin Tanislav
2022-11-07 16:49   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 04/13] dt-bindings: iio: temperature: ltc2983: remove qutations from phandle ref Cosmin Tanislav
2022-11-07 16:49   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 05/13] dt-bindings: iio: temperature: ltc2983: describe matrix items Cosmin Tanislav
2022-11-07 16:52   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 06/13] dt-bindings: iio: temperature: ltc2983: require custom sensor tables Cosmin Tanislav
2022-11-07 16:54   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 07/13] dt-bindings: iio: temperature: ltc2983: require 4 wire rtd for current rotate Cosmin Tanislav
2022-11-07 16:55   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 08/13] dt-bindings: iio: temperature: ltc2983: change default excitation for custom thermistors Cosmin Tanislav
2022-11-07 18:08   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 09/13] dt-bindings: iio: temperature: ltc2983: refine descriptions Cosmin Tanislav
2022-11-07 18:10   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 10/13] dt-bindings: iio: temperature: ltc2983: describe broken mux delay property Cosmin Tanislav
2022-11-07 18:11   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 11/13] dt-bindings: iio: temperature: ltc2983: use generic node name in example Cosmin Tanislav
2022-11-07 18:13   ` Rob Herring
2022-11-08  8:37     ` Cosmin Tanislav
2022-11-12 15:43       ` Jonathan Cameron
2022-11-03 13:00 ` [PATCH v4 12/13] dt-bindings: iio: temperature: ltc2983: support more parts Cosmin Tanislav
2022-11-03 13:00 ` [PATCH v4 13/13] " Cosmin Tanislav
2022-11-06 17:14 ` [PATCH v4 00/13] Support more parts in LTC2983 Jonathan Cameron
2022-11-12 15:44   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103130041.2153295-2-demonsingur@gmail.com \
    --to=demonsingur@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=cosmin.tanislav@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).