From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: "Nancy.Lin" <nancy.lin@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
wim@linux-watchdog.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux@roeck-us.net, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"jason-jh . lin" <jason-jh.lin@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org, llvm@lists.linux.dev,
singo.chang@mediatek.com,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v27 05/11] soc: mediatek: refine code to use mtk_mmsys_update_bits API
Date: Thu, 3 Nov 2022 16:32:38 -0400 [thread overview]
Message-ID: <20221103203238.fryjwpgjtwccnjwu@notapiano> (raw)
In-Reply-To: <20221103032512.9144-6-nancy.lin@mediatek.com>
On Thu, Nov 03, 2022 at 11:25:06AM +0800, Nancy.Lin wrote:
[..]
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
[..]
> +static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, u32 mask, u32 val)
> +{
> + u32 tmp;
> +
> + tmp = readl_relaxed(mmsys->regs + offset);
> + tmp = (tmp & ~mask) | val;
You should mask the value before writing to prevent bad values from overwriting
bits outside the mask.
tmp = (tmp & ~mask) | (val & mask);
With that,
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
next prev parent reply other threads:[~2022-11-03 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221103032512.9144-1-nancy.lin@mediatek.com>
[not found] ` <20221103032512.9144-2-nancy.lin@mediatek.com>
2022-11-03 19:39 ` [PATCH v27 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195 Nícolas F. R. A. Prado
2022-11-04 9:19 ` Nancy Lin (林欣螢)
[not found] ` <20221103032512.9144-7-nancy.lin@mediatek.com>
2022-11-03 19:56 ` [PATCH v27 06/11] soc: mediatek: add mtk-mmsys config API for mt8195 vdosys1 Nícolas F. R. A. Prado
2022-11-04 9:31 ` Nancy Lin (林欣螢)
[not found] ` <20221103032512.9144-6-nancy.lin@mediatek.com>
2022-11-03 20:32 ` Nícolas F. R. A. Prado [this message]
2022-11-04 9:29 ` [PATCH v27 05/11] soc: mediatek: refine code to use mtk_mmsys_update_bits API Nancy Lin (林欣螢)
[not found] ` <20221103032512.9144-9-nancy.lin@mediatek.com>
2022-11-03 20:45 ` [PATCH v27 08/11] soc: mediatek: mmsys: add mmsys for support 64 reset bits Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103203238.fryjwpgjtwccnjwu@notapiano \
--to=nfraprado@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=nancy.lin@mediatek.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=singo.chang@mediatek.com \
--cc=wim@linux-watchdog.org \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).