From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E12D1C433FE for ; Thu, 3 Nov 2022 21:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230150AbiKCV2K (ORCPT ); Thu, 3 Nov 2022 17:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbiKCV2J (ORCPT ); Thu, 3 Nov 2022 17:28:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64EB820364; Thu, 3 Nov 2022 14:28:08 -0700 (PDT) Received: from notapiano (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id B5E7B6602962; Thu, 3 Nov 2022 21:28:04 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667510886; bh=Bo6jAy9n7EIhWM93CDe2w2Ldd+vTyxvumeVAJrhRaig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b0WJzCft7a5ZU1yL7SAlojfM2J+IppIcj0zQTcbb8pxyMVeyXLAVv3qWzQjUhxd0e P3q4fyK3Bm2btG0ROUqy0jkxR0SxW02pdciQQpSYXkrL60pupIlzUHbUtUUGYD+q5E q/5sSIdsFObiLXgH8pP9g67nLHAceARjocg06/z+uSuzorjo8+0irx1w+s2Xk7Ujcm UmmS0Bem2aJVxw0Ze2BZe9WXhdDxw/F4R69QT7KGNtdrOAv1QcRnFZLSqeFQuBsIeJ Al6WX/lm8O5B8VtxsP5Wswwi+gN6GUK1lOSG47tPrma/eorY5/VVKIYKEtnKmOBlUa P73ztZIw+DJpw== Date: Thu, 3 Nov 2022 17:28:00 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: "Nancy.Lin" Cc: Rob Herring , Matthias Brugger , Chun-Kuang Hu , Philipp Zabel , wim@linux-watchdog.org, AngeloGioacchino Del Regno , linux@roeck-us.net, David Airlie , Daniel Vetter , Nathan Chancellor , Nick Desaulniers , "jason-jh . lin" , Yongqiang Niu , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, llvm@lists.linux.dev, singo.chang@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v27 6/7] drm/mediatek: add drm ovl_adaptor sub driver for MT8195 Message-ID: <20221103212800.43nxlxpconqkasvc@notapiano> References: <20221103032610.9217-1-nancy.lin@mediatek.com> <20221103032610.9217-7-nancy.lin@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221103032610.9217-7-nancy.lin@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Nov 03, 2022 at 11:26:09AM +0800, Nancy.Lin wrote: > Add drm ovl_adaptor sub driver. Bring up ovl_adaptor sub driver if > the component exists in the path. > > Signed-off-by: Nancy.Lin > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: CK Hu > Tested-by: AngeloGioacchino Del Regno > Tested-by: Bo-Chen Chen > Tested-by: Nícolas F. R. A. Prado > Change-Id: I0501f3c80e78ec8279366cba9c137a2edd7a852e > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 61 ++++----- > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 129 ++++++++++++-------- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 50 +++++++- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 78 ++++++------ > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 12 +- > 6 files changed, 209 insertions(+), 123 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index 30dcb65d8a5a..ce5617ad04cb 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c [..] > int mtk_drm_crtc_create(struct drm_device *drm_dev, > - const enum mtk_ddp_comp_id *path, unsigned int path_len, > + const unsigned int *path, unsigned int path_len, Hi Nancy, why is 'enum mtk_ddp_comp_id' being changed to 'unsigned int' throughout this patch? Was this intentional? I saw that this change happened between v16 [1] and v17 [2], but I didn't see any reply or mention about this in the commit message or cover letter. Thanks, Nícolas [1] https://lore.kernel.org/all/20220318142009.2796-21-nancy.lin@mediatek.com/ [2] https://lore.kernel.org/all/20220416020749.29010-20-nancy.lin@mediatek.com/